diff mbox series

[avr] Fix avr build broken by r276985.

Message ID 19818313-26f0-c675-79b2-d7e3d284a2f3@gjlay.de
State New
Headers show
Series [avr] Fix avr build broken by r276985. | expand

Commit Message

Georg-Johann Lay Oct. 17, 2019, 11:18 a.m. UTC 
Hi,

r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from 
--params.  The patch fixes that by using flag_store_data_races = 1 instead.

Ok to apply?

Johann

	* config/avr/avr.c (avr_option_override): Fix broken build
	introduced by r276985.

Comments

Richard Biener Oct. 17, 2019, 11:20 a.m. UTC | #1 
On Thu, 17 Oct 2019, Georg-Johann Lay wrote:

> Hi,
> 
> r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from
> --params.  The patch fixes that by using flag_store_data_races = 1 instead.
> 
> Ok to apply?

OK and sorry for the breakage.

Richard.
Eric Botcazou Oct. 17, 2019, 11:22 a.m. UTC | #2 
> r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from
> --params.  The patch fixes that by using flag_store_data_races = 1 instead.

Note that you'll unconditionally override the user, unlike the original code.
Jakub Jelinek Oct. 17, 2019, 11:27 a.m. UTC | #3 
On Thu, Oct 17, 2019 at 01:22:54PM +0200, Eric Botcazou wrote:
> > r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from
> > --params.  The patch fixes that by using flag_store_data_races = 1 instead.
> 
> Note that you'll unconditionally override the user, unlike the original code.

Yeah, better make that
  if (!global_options_set.x_flag_store_data_races)
    flag_store_data_races = 1;

	Jakub
Georg-Johann Lay Oct. 17, 2019, 11:42 a.m. UTC | #4 
Am 10/17/19 um 1:22 PM schrieb Eric Botcazou:
>> r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from
>> --params.  The patch fixes that by using flag_store_data_races = 1 instead.
> 
> Note that you'll unconditionally override the user, unlike the original code.

You're right.  What about this one?

Johann


	Fix breakage introduced by r276985.
	* config/avr/avr.c (avr_option_override): Remove set of
	PARAM_ALLOW_STORE_DATA_RACES.
	* common/config/avr/avr-common.c (avr_option_optimization_table)
	[OPT_LEVELS_ALL]: Turn on -fallow-store-data-races.
Richard Biener Oct. 17, 2019, 12:19 p.m. UTC | #5 
On Thu, 17 Oct 2019, Georg-Johann Lay wrote:

> Am 10/17/19 um 1:22 PM schrieb Eric Botcazou:
> >> r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from
> >> --params.  The patch fixes that by using flag_store_data_races = 1 instead.
> > 
> > Note that you'll unconditionally override the user, unlike the original
> > code.
> 
> You're right.  What about this one?

LGTM.

> Johann
> 
> 
> 	Fix breakage introduced by r276985.
> 	* config/avr/avr.c (avr_option_override): Remove set of
> 	PARAM_ALLOW_STORE_DATA_RACES.
> 	* common/config/avr/avr-common.c (avr_option_optimization_table)
> 	[OPT_LEVELS_ALL]: Turn on -fallow-store-data-races.
> 
>
diff mbox series

Patch

Index: config/avr/avr.c
===================================================================
--- config/avr/avr.c	(revision 277097)
+++ config/avr/avr.c	(working copy)
@@ -746,9 +746,7 @@  avr_option_override (void)
      performance decrease. For the AVR though, disallowing data races
      introduces additional code in LIM and increases reg pressure.  */
 
-  maybe_set_param_value (PARAM_ALLOW_STORE_DATA_RACES, 1,
-                         global_options.x_param_values,
-                         global_options_set.x_param_values);
+  flag_store_data_races = 1;
 
   /* Unwind tables currently require a frame pointer for correctness,
      see toplev.c:process_options().  */