| Message ID | 20110523113709.4357b4ba.randy.dunlap@oracle.com |
|---|---|
| State | Accepted |
| Commit | 63da029015b5255915cd6d61f19ffc276ad4635d |
| Headers | show |
On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > Fix build warnings in physmap.h: > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Oh, this was missed during review. This was introduced in b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's tree, so I guess Russel could pick up your patch. CCed relevant people.
On Tue, 2011-05-24 at 08:53 +0300, Artem Bityutskiy wrote: > On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote: > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > Fix build warnings in physmap.h: > > > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > Oh, this was missed during review. This was introduced in > b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's > tree, so I guess Russel could pick up your patch. My big apologies, s/Russel/Russell/.
On Tue, May 24, 2011 at 08:58:03AM +0300, Artem Bityutskiy wrote: > On Tue, 2011-05-24 at 08:53 +0300, Artem Bityutskiy wrote: > > On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote: > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > > > Fix build warnings in physmap.h: > > > > > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > > > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > > > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > > > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > > > Oh, this was missed during review. This was introduced in > > b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's > > tree, so I guess Russel could pick up your patch. > > My big apologies, s/Russel/Russell/. Which patch? Neither of these messages contained Randy's patch and I wasn't included on the original posting.
On Tue, 2011-05-24 at 08:40 +0100, Russell King wrote: > On Tue, May 24, 2011 at 08:58:03AM +0300, Artem Bityutskiy wrote: > > On Tue, 2011-05-24 at 08:53 +0300, Artem Bityutskiy wrote: > > > On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote: > > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > > > > > Fix build warnings in physmap.h: > > > > > > > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > > > > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > > > > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > > > > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > > > > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > > > > > Oh, this was missed during review. This was introduced in > > > b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's > > > tree, so I guess Russel could pick up your patch. > > > > My big apologies, s/Russel/Russell/. > > Which patch? Neither of these messages contained Randy's patch and I > wasn't included on the original posting. Sorry, I assumed you'd look that lkml is in CC and would find it in lkml (I assumed you are subscribed there). I'll send this patch shortly.
--- linux-next-20110523.orig/include/linux/mtd/physmap.h +++ linux-next-20110523/include/linux/mtd/physmap.h @@ -19,6 +19,7 @@ #include <linux/mtd/partitions.h> struct map_info; +struct platform_device; struct physmap_flash_data { unsigned int width;