| Message ID | 20191014061549.3669-3-o.rempel@pengutronix.de |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | add dsa switch support for ar9331 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 2 errors, 1 warnings, 155 lines checked" |
On Mon, Oct 14, 2019 at 08:15:47AM +0200, Oleksij Rempel wrote: > Atheros AR9331 has built-in 5 port switch. The switch can be configured > to use all 5 or 4 ports. One of built-in PHYs can be used by first built-in > ethernet controller or to be used directly by the switch over second ethernet > controller. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/net/dsa/ar9331.txt | 155 ++++++++++++++++++ > 1 file changed, 155 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/dsa/ar9331.txt > > diff --git a/Documentation/devicetree/bindings/net/dsa/ar9331.txt b/Documentation/devicetree/bindings/net/dsa/ar9331.txt > new file mode 100644 > index 000000000000..b0f95fd19584 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/dsa/ar9331.txt > @@ -0,0 +1,155 @@ > +Atheros AR9331 built-in switch > +============================= > + > +It is a switch built-in to Atheros AR9331 WiSoC and addressable over internal > +MDIO bus. All PHYs are build-in as well. > + > +Required properties: > + > + - compatible: should be: "qca,ar9331-switch" > + - reg: Address on the MII bus for the switch. > + - resets : Must contain an entry for each entry in reset-names. > + - reset-names : Must include the following entries: "switch" > + - interrupt-parent: Phandle to the parent interrupt controller > + - interrupts: IRQ line for the switch > + - interrupt-controller: Indicates the switch is itself an interrupt > + controller. This is used for the PHY interrupts. > + - #interrupt-cells: must be 1 > + - mdio: Container of PHY and devices on the switches MDIO bus. > + > +See Documentation/devicetree/bindings/net/dsa/dsa.txt for a list of additional > +required and optional properties. > +Examples: > + > +eth0: ethernet@19000000 { > + compatible = "qca,ar9330-eth"; > + reg = <0x19000000 0x200>; > + interrupts = <4>; > + > + resets = <&rst 9>, <&rst 22>; > + reset-names = "mac", "mdio"; > + clocks = <&pll ATH79_CLK_AHB>, <&pll ATH79_CLK_AHB>; > + clock-names = "eth", "mdio"; > + > + phy-mode = "mii"; > + phy-handle = <&phy_port4>; This does not seem like a valid example. If phy_port4 is listed here, i would expect switch_port 5 to be totally missing? > +}; > + > +eth1: ethernet@1a000000 { > + compatible = "qca,ar9330-eth"; > + reg = <0x1a000000 0x200>; > + interrupts = <5>; > + resets = <&rst 13>, <&rst 23>; > + reset-names = "mac", "mdio"; > + clocks = <&pll ATH79_CLK_AHB>, <&pll ATH79_CLK_AHB>; > + clock-names = "eth", "mdio"; > + > + phy-mode = "gmii"; > + phy-handle = <&switch_port0>; > + > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; You also cannot have both a fixed-link and a phy-handle. > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + switch10: switch@10 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + compatible = "qca,ar9331-switch"; > + reg = <16>; Maybe don't mix up hex and decimal? switch16: switch@16. Andrew
On Wed, Oct 16, 2019 at 02:21:52PM +0200, Andrew Lunn wrote: > On Mon, Oct 14, 2019 at 08:15:47AM +0200, Oleksij Rempel wrote: > > Atheros AR9331 has built-in 5 port switch. The switch can be configured > > to use all 5 or 4 ports. One of built-in PHYs can be used by first built-in > > ethernet controller or to be used directly by the switch over second ethernet > > controller. > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > .../devicetree/bindings/net/dsa/ar9331.txt | 155 ++++++++++++++++++ > > 1 file changed, 155 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/dsa/ar9331.txt > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/ar9331.txt b/Documentation/devicetree/bindings/net/dsa/ar9331.txt > > new file mode 100644 > > index 000000000000..b0f95fd19584 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/dsa/ar9331.txt > > @@ -0,0 +1,155 @@ > > +Atheros AR9331 built-in switch > > +============================= > > + > > +It is a switch built-in to Atheros AR9331 WiSoC and addressable over internal > > +MDIO bus. All PHYs are build-in as well. > > + > > +Required properties: > > + > > + - compatible: should be: "qca,ar9331-switch" > > + - reg: Address on the MII bus for the switch. > > + - resets : Must contain an entry for each entry in reset-names. > > + - reset-names : Must include the following entries: "switch" > > + - interrupt-parent: Phandle to the parent interrupt controller > > + - interrupts: IRQ line for the switch > > + - interrupt-controller: Indicates the switch is itself an interrupt > > + controller. This is used for the PHY interrupts. > > + - #interrupt-cells: must be 1 > > + - mdio: Container of PHY and devices on the switches MDIO bus. > > + > > +See Documentation/devicetree/bindings/net/dsa/dsa.txt for a list of additional > > +required and optional properties. > > +Examples: > > + > > +eth0: ethernet@19000000 { > > + compatible = "qca,ar9330-eth"; > > + reg = <0x19000000 0x200>; > > + interrupts = <4>; > > + > > + resets = <&rst 9>, <&rst 22>; > > + reset-names = "mac", "mdio"; > > + clocks = <&pll ATH79_CLK_AHB>, <&pll ATH79_CLK_AHB>; > > + clock-names = "eth", "mdio"; > > + > > + phy-mode = "mii"; > > + phy-handle = <&phy_port4>; > > This does not seem like a valid example. If phy_port4 is listed here, > i would expect switch_port 5 to be totally missing? hm... right. phy4 can be used with switch_port 5 or eth0. Should i remove completely switch_port 5 node or it is enough to "disable" it. > > +}; > > + > > +eth1: ethernet@1a000000 { > > + compatible = "qca,ar9330-eth"; > > + reg = <0x1a000000 0x200>; > > + interrupts = <5>; > > + resets = <&rst 13>, <&rst 23>; > > + reset-names = "mac", "mdio"; > > + clocks = <&pll ATH79_CLK_AHB>, <&pll ATH79_CLK_AHB>; > > + clock-names = "eth", "mdio"; > > + > > + phy-mode = "gmii"; > > + phy-handle = <&switch_port0>; > > + > > + fixed-link { > > + speed = <1000>; > > + full-duplex; > > + }; > > You also cannot have both a fixed-link and a phy-handle. ok. > > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + switch10: switch@10 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + compatible = "qca,ar9331-switch"; > > + reg = <16>; > > Maybe don't mix up hex and decimal? switch16: switch@16. ok. will fix it. What is actually proper way to set the reg of switch? This switch is responding on range of phy addresses: any of two high bits of 5 bit phy address. Regards, Oleksij
On Mon, Oct 14, 2019 at 08:15:47AM +0200, Oleksij Rempel wrote: > Atheros AR9331 has built-in 5 port switch. The switch can be configured > to use all 5 or 4 ports. One of built-in PHYs can be used by first built-in > ethernet controller or to be used directly by the switch over second ethernet > controller. Hi Oleksij How exactly is this phy sharing controlled? I did not see anything in the driver. Is there a mux we need to set? Andrew
On 16.10.19 22:23, Andrew Lunn wrote: > On Mon, Oct 14, 2019 at 08:15:47AM +0200, Oleksij Rempel wrote: >> Atheros AR9331 has built-in 5 port switch. The switch can be configured >> to use all 5 or 4 ports. One of built-in PHYs can be used by first built-in >> ethernet controller or to be used directly by the switch over second ethernet >> controller. > > Hi Oleksij > > How exactly is this phy sharing controlled? I did not see anything in > the driver. Is there a mux we need to set? Currently it is not controlled at all, eth0 should be disabled and switch port5 enabled (or other way around) in devicetree. If both are enabled, it will be some how brocken. I don't know how to properly implement it. I assume, it should not be controlled by devicetree configuration and user should be able to do it dynamically from user space. Ideas, suggestions? Kind regards, Oleksij Rempel
diff --git a/Documentation/devicetree/bindings/net/dsa/ar9331.txt b/Documentation/devicetree/bindings/net/dsa/ar9331.txt new file mode 100644 index 000000000000..b0f95fd19584 --- /dev/null +++ b/Documentation/devicetree/bindings/net/dsa/ar9331.txt @@ -0,0 +1,155 @@ +Atheros AR9331 built-in switch +============================= + +It is a switch built-in to Atheros AR9331 WiSoC and addressable over internal +MDIO bus. All PHYs are build-in as well. + +Required properties: + + - compatible: should be: "qca,ar9331-switch" + - reg: Address on the MII bus for the switch. + - resets : Must contain an entry for each entry in reset-names. + - reset-names : Must include the following entries: "switch" + - interrupt-parent: Phandle to the parent interrupt controller + - interrupts: IRQ line for the switch + - interrupt-controller: Indicates the switch is itself an interrupt + controller. This is used for the PHY interrupts. + - #interrupt-cells: must be 1 + - mdio: Container of PHY and devices on the switches MDIO bus. + +See Documentation/devicetree/bindings/net/dsa/dsa.txt for a list of additional +required and optional properties. +Examples: + +eth0: ethernet@19000000 { + compatible = "qca,ar9330-eth"; + reg = <0x19000000 0x200>; + interrupts = <4>; + + resets = <&rst 9>, <&rst 22>; + reset-names = "mac", "mdio"; + clocks = <&pll ATH79_CLK_AHB>, <&pll ATH79_CLK_AHB>; + clock-names = "eth", "mdio"; + + phy-mode = "mii"; + phy-handle = <&phy_port4>; +}; + +eth1: ethernet@1a000000 { + compatible = "qca,ar9330-eth"; + reg = <0x1a000000 0x200>; + interrupts = <5>; + resets = <&rst 13>, <&rst 23>; + reset-names = "mac", "mdio"; + clocks = <&pll ATH79_CLK_AHB>, <&pll ATH79_CLK_AHB>; + clock-names = "eth", "mdio"; + + phy-mode = "gmii"; + phy-handle = <&switch_port0>; + + fixed-link { + speed = <1000>; + full-duplex; + }; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + switch10: switch@10 { + #address-cells = <1>; + #size-cells = <0>; + + compatible = "qca,ar9331-switch"; + reg = <16>; + resets = <&rst 8>; + reset-names = "switch"; + + interrupt-parent = <&miscintc>; + interrupts = <12>; + + interrupt-controller; + #interrupt-cells = <1>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + switch_port0: port@0 { + reg = <0>; + label = "cpu"; + ethernet = <ð1>; + + phy-mode = "gmii"; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; + + switch_port1: port@1 { + reg = <1>; + phy-handle = <&phy_port0>; + phy-mode = "internal"; + }; + + switch_port2: port@2 { + reg = <2>; + phy-handle = <&phy_port1>; + phy-mode = "internal"; + }; + + switch_port3: port@3 { + reg = <3>; + phy-handle = <&phy_port2>; + phy-mode = "internal"; + }; + + switch_port4: port@4 { + reg = <4>; + phy-handle = <&phy_port3>; + phy-mode = "internal"; + }; + + switch_port5: port@5 { + reg = <5>; + phy-handle = <&phy_port4>; + phy-mode = "internal"; + }; + }; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + interrupt-parent = <&switch10>; + + phy_port0: phy@0 { + reg = <0>; + interrupts = <0>; + }; + + phy_port1: phy@1 { + reg = <1>; + interrupts = <0>; + }; + + phy_port2: phy@2 { + reg = <2>; + interrupts = <0>; + }; + + phy_port3: phy@3 { + reg = <3>; + interrupts = <0>; + }; + + phy_port4: phy@4 { + reg = <4>; + interrupts = <0>; + }; + }; + }; + }; +};
Atheros AR9331 has built-in 5 port switch. The switch can be configured to use all 5 or 4 ports. One of built-in PHYs can be used by first built-in ethernet controller or to be used directly by the switch over second ethernet controller. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/net/dsa/ar9331.txt | 155 ++++++++++++++++++ 1 file changed, 155 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dsa/ar9331.txt