| Message ID | 20191011223818.7238-1-vgupta@synopsys.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC] asm-generic/tlb: stub out pmd_free_tlb() if __PAGETABLE_PMD_FOLDED | expand |
On Fri, Oct 11, 2019 at 3:38 PM Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > > This is inine with similar patches for nopud [1] and nop4d [2] cases. I don't think your patch is wrong, but wouldn't it be easier and cleaner to just do this instead --- a/include/asm-generic/pgtable-nopmd.h +++ b/include/asm-generic/pgtable-nopmd.h @@ -60,7 +60,7 @@ static inline pmd_t * pmd_offset(pud_t * pud, unsigned long address) static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) { } -#define __pmd_free_tlb(tlb, x, a) do { } while (0) +#define pmd_free_tlb(tlb, x, a) do { } while (0) #undef pmd_addr_end #define pmd_addr_end(addr, end) (end) and just rely on the regular "#ifndef pmd_free_tlb" in include/asm-generic/tlb.h? Completely untested. Linus
On 10/14/19 10:41 AM, Linus Torvalds wrote: > On Fri, Oct 11, 2019 at 3:38 PM Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: >> >> This is inine with similar patches for nopud [1] and nop4d [2] cases. > > I don't think your patch is wrong, but wouldn't it be easier and > cleaner to just do this instead > > --- a/include/asm-generic/pgtable-nopmd.h > +++ b/include/asm-generic/pgtable-nopmd.h > @@ -60,7 +60,7 @@ static inline pmd_t * pmd_offset(pud_t * pud, > unsigned long address) > static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) > { > } > -#define __pmd_free_tlb(tlb, x, a) do { } while (0) > +#define pmd_free_tlb(tlb, x, a) do { } while (0) > > #undef pmd_addr_end > #define pmd_addr_end(addr, end) (end) I suppose we could but (a) It would be asymmetric with the __p{u,4}d_free_tlb() changes in [1] and [2]. Do you prefer [1] and [2] be repun along the same lines as you propose above ? (b) IMHO p?d_free_tlb() under corresponding #ifndef *P?D_FOLDED is much clearer to read as being stubbed out. But this is minor point. Also would you care to shed light on my other question about not being able to fold away pmd_clear_bad() despite PMD_FOLDED given the pmd macros actually checking for pgd. Of all the people you are likely to have most insight on how the pmd folding actually evolved and works :-) Thx, -Vineet [1] http://lists.infradead.org/pipermail/linux-snps-arc/2019-October/006266.html [2] http://lists.infradead.org/pipermail/linux-snps-arc/2019-October/006265.html
On Mon, Oct 14, 2019 at 11:02 AM Vineet Gupta <vineetg76@gmail.com> wrote: > > I suppose we could but > > (a) It would be asymmetric with the __p{u,4}d_free_tlb() changes in [1] and [2]. Your patch is already assymmetric wrt those anyway - you had to add that +#else +#define pmd_free_tlb(tlb, pmdp, address) do { } while (0) +#endif that the other cases don't currently have, so then you point to another patch that makes the code uglier instead. > Do you prefer [1] and [2] be repun along the same lines as you propose above ? In general, I absolutely detest how we have random #ifndef ARCH_HAS_ONE_DEFINE #define another_define_entirely() ... which makes no sense and is ugly, and also wreaks havoc on simple things like "git grep another_define_entirely" I've long tried to convince people to just do #ifndef special_define #define special_define(xyz) .. #endif instead, which doesn't mix up two completely unrelated names, and when you grep for that function name, you _see_ all the context. > Also would you care to shed light on my other question about not being able to > fold away pmd_clear_bad() despite PMD_FOLDED given the pmd macros actually > checking for pgd. Of all the people you are likely to have most insight on how the > pmd folding actually evolved and works :-) I think some of it is just ugly and historical, and confused. In general, it should always be the "higher" level that folds away. So I think the best example of this is include/asm-generic/pgtable-nop4d.h where basically all the "pgd" functions become no-ops, and can never not exist or be bad, because they are always just containers for the lower level and don't have any data in them themselves: static inline int pgd_none(pgd_t pgd) { return 0; } static inline int pgd_bad(pgd_t pgd) { return 0; } static inline int pgd_present(pgd_t pgd) { return 1; } static inline void pgd_clear(pgd_t *pgd) { } and walking from pgd to p4d is that nice folded op: static inline p4d_t *p4d_offset(pgd_t *pgd, unsigned long address) { return (p4d_t *)pgd; } and this is how it should always work.See "nopud" and "nopmd"(which are 3rd/2nd level respectively) doing the same thing exactly. And yes, pmd_clear_bad() should just go away. We have static inline int pmd_none_or_clear_bad(pmd_t *pmd) { if (pmd_none(*pmd)) return 1; if (unlikely(pmd_bad(*pmd))) { pmd_clear_bad(pmd); return 1; } return 0; } and if the pmd doesn't exist, then both pmd_none() and pmd_bad() should just be zero (see above), and the pmd_none_or_clear_bad() should just become "return 0"; Exactly what part isn't working for you? I suspect part of the problem is exactly that we than have that stupid confusion with some code checking "#ifdef __PAGETABLE_PMD_FOLDED" and then making their own random decisions based on things like that instead. When you do that, the code ends up relying on other magic than just the natural folding. Linus
On 10/14/19 11:25 AM, Linus Torvalds wrote: > On Mon, Oct 14, 2019 at 11:02 AM Vineet Gupta <vineetg76@gmail.com> wrote: >> >> I suppose we could but >> >> (a) It would be asymmetric with the __p{u,4}d_free_tlb() changes in [1] and [2]. > > Your patch is already assymmetric wrt those anyway - you had to add that > > +#else > +#define pmd_free_tlb(tlb, pmdp, address) do { } while (0) > +#endif > > that the other cases don't currently have, so then you point to > another patch that makes the code uglier instead. > >> Do you prefer [1] and [2] be repun along the same lines as you propose above ? > > In general, I absolutely detest how we have random > > #ifndef ARCH_HAS_ONE_DEFINE > #define another_define_entirely() > ... > > which makes no sense and is ugly, and also wreaks havoc on simple > things like "git grep another_define_entirely" > > I've long tried to convince people to just do > > #ifndef special_define > #define special_define(xyz) .. > #endif > > instead, which doesn't mix up two completely unrelated names, and when > you grep for that function name, you _see_ all the context. Ok fair enough, I'd just add extra comments to non stubbed p?d_free_tlb that they are stubbed out for corresponding case. > >> Also would you care to shed light on my other question about not being able to >> fold away pmd_clear_bad() despite PMD_FOLDED given the pmd macros actually >> checking for pgd. Of all the people you are likely to have most insight on how the >> pmd folding actually evolved and works :-) > > I think some of it is just ugly and historical, and confused. > > In general, it should always be the "higher" level that folds away. So > I think the best example of this is > > include/asm-generic/pgtable-nop4d.h > > where basically all the "pgd" functions become no-ops, and can never > not exist or be bad, because they are always just containers for the > lower level and don't have any data in them themselves: > > static inline int pgd_none(pgd_t pgd) { return 0; } > static inline int pgd_bad(pgd_t pgd) { return 0; } > static inline int pgd_present(pgd_t pgd) { return 1; } > static inline void pgd_clear(pgd_t *pgd) { } > > and walking from pgd to p4d is that nice folded op: > > static inline p4d_t *p4d_offset(pgd_t *pgd, unsigned long address) > { return (p4d_t *)pgd; } > > and this is how it should always work.See "nopud" and "nopmd"(which > are 3rd/2nd level respectively) doing the same thing exactly. Right, my naive mental model was assuming nopmd would somehow stub out pmd_* macros (or call into upper level function somehow etc), wheres here (1) we stub out the prior level and (2) the function of stubbed level operate on the data type of higher level. > And yes, pmd_clear_bad() should just go away. We have > > static inline int pmd_none_or_clear_bad(pmd_t *pmd) > { > if (pmd_none(*pmd)) > return 1; > if (unlikely(pmd_bad(*pmd))) { > pmd_clear_bad(pmd); > return 1; > } > return 0; > } > > and if the pmd doesn't exist, then both pmd_none() and pmd_bad() > should just be zero (see above), and the pmd_none_or_clear_bad() > should just become "return 0"; > > Exactly what part isn't working for you? I haven't tested that patch but I suspect even if it was broken, it would not necessarily show right away with a trivial test. Anyhow my worry/confusions starts at free_pgd_range() where pgd_none_or_clear_bad(pgd) is no-op given pgd_none()/pgd_bad() are stubs for nopmd case. free_pgd_range pgd = pgd_offset(tlb->mm, addr); do { next = pgd_addr_end(addr, end); if (pgd_none_or_clear_bad(pgd)) continue; free_p4e_range(tlb, pgd, addr); } while (pgd++, addr = next, addr != end); ... And the validation of pgd entry actually happens in pmd_none_or_clear_bad(pmd) since there pmd actually ends up referencing pgd entry. Hence the ensuing pmd_clear_bad() doesn't seem like if it could be stubbed out. free_pmd_range pmd = pmd_offset(pud, addr); do { next = pmd_addr_end(addr, end); if (pmd_none_or_clear_bad(pmd)) <--- pmd_bad()/pmd_clear_bad() continue; free_pte_range(tlb, pmd, addr); } while (pmd++, addr = next, addr != end); I'm sure I'm missing something, but don't understand what !
On Mon, Oct 14, 2019 at 12:08 PM Vineet Gupta <vineetg76@gmail.com> wrote: > > > And yes, pmd_clear_bad() should just go away. We have > > > > static inline int pmd_none_or_clear_bad(pmd_t *pmd) > > { > > if (pmd_none(*pmd)) > > return 1; > > if (unlikely(pmd_bad(*pmd))) { > > pmd_clear_bad(pmd); > > return 1; > > } > > return 0; > > } That was a particularly bad example. The pmd always exists, even in a 2-level setup. It's the pgd/p4d/pud that end up containing a lower level, but pmd_none() is never one of the fixed "doesn't exist" cases. > > Exactly what part isn't working for you? > > I haven't tested that patch but I suspect even if it was broken, it would not > necessarily show right away with a trivial test. > > Anyhow my worry/confusions starts at free_pgd_range() where > pgd_none_or_clear_bad(pgd) is no-op given pgd_none()/pgd_bad() are stubs for nopmd > case. Right. If you have a two-level setup, then p[g4u]d_none_or_clear_bad() should end up being no-ops. Buit then: > And the validation of pgd entry actually happens in pmd_none_or_clear_bad(pmd) > since there pmd actually ends up referencing pgd entry. Hence the ensuing > pmd_clear_bad() doesn't seem like if it could be stubbed out. Yes, you're correct, I was just "off by one" in my levels. Yeah, the folding is damn confusing. And it doesn't help that I think some of the code talks about the lower level being folded into the higher level for historical reasons, so we have those PMD_FOLDED macros etc, which are really about pud() just going away because pmd is folded inside the pud. So when the pud level is compiled away, we talk about the pmd level being folded into it, and then we get confusion (like mine above) where you end up being off by one level, because depending on how it's being talked about, you talk about one or the other. And it shows in the header files too. We have "pgtable-nopmd.h", which then defines the page table accessors not for the pmd level, but for the pud level. Which is why I then spout nonsense like the above about pmd_none() - because I was thinking of the nopmd case, but that makes the p*u*d_none() be always 0, not p*m*d_none(). So we have this whole "off-by-one" error in our naming and thus our thinking, and it's really easy to just get really confused about it. We should probably get rid of the whole "PMD_FOLDED" logic, and instead talk about "no PUD level". It actually shows in our types too. We do this: typedef struct { pud_t pud; } pmd_t; #define PTRS_PER_PMD 1 because some of the code thinks of the pmd as containing the pud. But it would probably be better to do it the other way around, and just consistently think of it as "pud level doesn't exist, the pud level just contains a pmd" instead. So we have these really odd "somethimes we think of pmd as part of a pud entry" vs "sometimes we think of pud as just containing a single pmd". And I think that latter model is the better mental model, but then we should have typedef struct { pmd_t pud; } pud_t; #define PTRS_PER_PUD 1 instead, and we'd get static inline pmd_t * pmd_offset(pud_t * pud, unsigned long address) { return &pud->pmd; } and that would make more sense, wouldn't it? But trying to fix our odd "we seem to think about it wrong" model would likely be too painful to be realistic., It would involve renaming nop4d.h -> nopgd.h nopud.h -> nop4d.h nopmd.h -> nopud.h and turning those types around (so we'd have those typedef struct { p4d_t p4d; } pgd_t; typedef struct { pud_t pud; | p4d_t; typedef struct { pmd_t pmd; } pud_t; for no-pgd/no-p4d/no-pud respectively. So then a 2-level machine would only define the pmd and pte levels, and be done with it, because the upper levels would be defined in terms of those. But that's not what we do, and we mix up levels in odd and confusing ways. And now I've said pgd/pud/p4d/pmd so many times that I've confused myself and think I'm wrong again, and I think that historically - originally - we always had a pgd, and then the pmd didn't exist because it was folded into it. That makes sense from a x86 naming standpoint. Then x86 _did_ get a pmd, and then we added more levels in between, and other architectures did things differently. So I think the confusion is historical, and is because we've switched between thinking that the the lower level that doesn't exist, but is embedded in the upper level, and slowly converted to "it's the upper level that doesn't exist, and just contains the lower level" The point stands: it's confusing, and we should probably pick one model, and the model we pick should likely be "this level doesn't exist, and just wraps the lower level", so it *should* be "no pgd"/"no p4d"/"no pud". Linus
On Mon, Oct 14, 2019 at 01:38:34PM -0700, Linus Torvalds wrote: > And now I've said pgd/pud/p4d/pmd so many times that I've confused > myself and think I'm wrong again, and I think that historically - > originally - we always had a pgd, and then the pmd didn't exist > because it was folded into it. That makes sense from a x86 naming > standpoint. Then x86 _did_ get a pmd, and then we added more levels in > between, and other architectures did things differently. Oh my goodness. Thank you for writing all this out and finally getting to this point. I was reading the whole thing thinking "This is different from what I remember" and then you got here. This explains so much about how our MM does/doesn't work, and it's not just me that's confused ;-)
diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index f3dad87f4ecc..a1edad7d4170 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -574,6 +574,7 @@ static inline void tlb_end_vma(struct mmu_gather *tlb, struct vm_area_struct *vm } while (0) #endif +#ifndef __PAGETABLE_PMD_FOLDED #ifndef pmd_free_tlb #define pmd_free_tlb(tlb, pmdp, address) \ do { \ @@ -583,6 +584,9 @@ static inline void tlb_end_vma(struct mmu_gather *tlb, struct vm_area_struct *vm __pmd_free_tlb(tlb, pmdp, address); \ } while (0) #endif +#else +#define pmd_free_tlb(tlb, pmdp, address) do { } while (0) +#endif #ifndef __PAGETABLE_PUD_FOLDED #ifndef pud_free_tlb
This is inine with similar patches for nopud [1] and nop4d [2] cases. However I'm not really sure I understand clearly how the nopmd code is supposed to work (for a 2 tier paging system) - hence the RFC. Consider free_pmd_range() simplified/annotated below free_pmd_range ... pmd = pmd_offset(pud, addr); do { next = pmd_addr_end(addr, end); if (pmd_none_or_clear_bad(pmd)) => *pmd_bad()/pmd_clear_bad() [a]* continue; free_pte_range(tlb, pmd, addr); } while (pmd++, addr = next, addr != end); ... *pmd_free_tlb(tlb, pmd, start); => [b]* For ARC/nopmd case [a] is actually checking pgd and consequently pmd_clear_bad() can't be stubbed out for PMD_FOLDED case. However it seems case [b] can be stubbed out (hence this patch) along same lines as [1] and [2] | bloat-o-meter2 vmlinux-E-elide-p?d_clear_bad vmlinux-F-elide-pmd_free_tlb | add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-112 (-112) | function old new delta | free_pgd_range 422 310 -112 | Total: Before=4137002, After=4136890, chg -1.000000% [1] http://lists.infradead.org/pipermail/linux-snps-arc/2019-October/006266.html [2] http://lists.infradead.org/pipermail/linux-snps-arc/2019-October/006265.html Signed-off-by: Vineet Gupta <vgupta@synopsys.com> --- include/asm-generic/tlb.h | 4 ++++ 1 file changed, 4 insertions(+)