| Message ID | 20191013190014.32138-3-daniel.baluta@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Introduce for-dpcm DT property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Sun, Oct 13, 2019 at 10:00:14PM +0300, Daniel Baluta wrote: > This property can be global in which case all links created will be DPCM > or present in certian dai-link subnode in which case only that specific > link is forced to be DPCM. > +- force-dpcm : Indicates dai-link is always DPCM. DPCM is an implementation detail of Linux (and one that we want to phase out going forwards too), we shouldn't be putting it in the DT bindings where it becomes an ABI.
On Mon, Oct 14, 2019 at 2:57 PM Mark Brown <broonie@kernel.org> wrote: > > On Sun, Oct 13, 2019 at 10:00:14PM +0300, Daniel Baluta wrote: > > > This property can be global in which case all links created will be DPCM > > or present in certian dai-link subnode in which case only that specific > > link is forced to be DPCM. > > > +- force-dpcm : Indicates dai-link is always DPCM. > > DPCM is an implementation detail of Linux (and one that we want to phase > out going forwards too), we shouldn't be putting it in the DT bindings > where it becomes an ABI. Hi Mark, I see your point. This is way I marked the patch series as RFC. I need to find another way to reuse simple-card as machine driver for SOF. thanks, Daniel.
On Mon, Oct 14, 2019 at 04:17:31PM +0300, Daniel Baluta wrote: > On Mon, Oct 14, 2019 at 2:57 PM Mark Brown <broonie@kernel.org> wrote: > > DPCM is an implementation detail of Linux (and one that we want to phase > > out going forwards too), we shouldn't be putting it in the DT bindings > > where it becomes an ABI. > I see your point. This is way I marked the patch series as RFC. I need to find > another way to reuse simple-card as machine driver for SOF. Have a look at the way the Renesas systems are using this and the audio graph card - they have DPCM.
Hi > > > DPCM is an implementation detail of Linux (and one that we want to phase > > > out going forwards too), we shouldn't be putting it in the DT bindings > > > where it becomes an ABI. > > > I see your point. This is way I marked the patch series as RFC. I need to find > > another way to reuse simple-card as machine driver for SOF. > > Have a look at the way the Renesas systems are using this and the audio > graph card - they have DPCM. Indeed we (= Renesas) are using this as DPCM, but unfortunately it is not upstreamed. Using local patch. Thank you for your help !! Best regards --- Kuninori Morimoto
Hi > > > > DPCM is an implementation detail of Linux (and one that we want to phase > > > > out going forwards too), we shouldn't be putting it in the DT bindings > > > > where it becomes an ABI. > > > > > I see your point. This is way I marked the patch series as RFC. I need to find > > > another way to reuse simple-card as machine driver for SOF. > > > > Have a look at the way the Renesas systems are using this and the audio > > graph card - they have DPCM. > > Indeed we (= Renesas) are using this as DPCM, but unfortunately > it is not upstreamed. Using local patch. I mean DT part. Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt index 79954cd6e37b..15e6f5329857 100644 --- a/Documentation/devicetree/bindings/sound/simple-card.txt +++ b/Documentation/devicetree/bindings/sound/simple-card.txt @@ -63,6 +63,7 @@ Optional dai-link subnode properties: - mclk-fs : Multiplication factor between stream rate and codec mclk, applied only for the dai-link. +- force-dpcm : Indicates dai-link is always DPCM. For backward compatibility the frame-master and bitclock-master properties can be used as booleans in codec subnode to indicate if the
This property can be global in which case all links created will be DPCM or present in certian dai-link subnode in which case only that specific link is forced to be DPCM. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- Documentation/devicetree/bindings/sound/simple-card.txt | 1 + 1 file changed, 1 insertion(+)