| Message ID | 20191010144226.4115-1-alobakin@dlink.ru |
|---|---|
| Headers | show |
| Series | net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() | expand |
Hi Alexander, On Thu, Oct 10, 2019 at 05:42:24PM +0300, Alexander Lobakin wrote: > Hi Dave, > > This series was written as a continuation to commit 323ebb61e32b > ("net: use listified RX for handling GRO_NORMAL skbs"), and also takes > an advantage of listified Rx for GRO. This time, however, we're > targeting at a way more common and used function, napi_gro_receive(). > > There are about ~100 call sites of this function, including gro_cells > and mac80211, so even wireless systems will benefit from it. > The only driver that cares about the return value is > ethernet/socionext/netsec, and only for updating statistics. I don't > believe that this change can break its functionality, but anyway, > we have plenty of time till next merge window to pay this change > a proper attention. I don't think this will break anything on the netsec driver. Dropped packets will still be properly accounted for > > Besides having this functionality implemented for napi_gro_frags() > users, the main reason is the solid performance boost that has been > shown during tests on 1-core MIPS board (with not yet mainlined > driver): > > * no batching (5.4-rc2): ~450/450 Mbit/s > * with gro_normal_batch == 8: ~480/480 Mbit/s > * with gro_normal_batch == 16: ~500/500 Mbit/s > > Applies on top of net-next. > Thanks. > > Alexander Lobakin (2): > net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() > net: core: increase the default size of GRO_NORMAL skb lists to flush > > net/core/dev.c | 51 +++++++++++++++++++++++++------------------------- > 1 file changed, 26 insertions(+), 25 deletions(-) > > -- > 2.23.0 > Thanks /Ilias
Hi Ilias, Ilias Apalodimas wrote 11.10.2019 15:23: > Hi Alexander, > > On Thu, Oct 10, 2019 at 05:42:24PM +0300, Alexander Lobakin wrote: >> Hi Dave, >> >> This series was written as a continuation to commit 323ebb61e32b >> ("net: use listified RX for handling GRO_NORMAL skbs"), and also takes >> an advantage of listified Rx for GRO. This time, however, we're >> targeting at a way more common and used function, napi_gro_receive(). >> >> There are about ~100 call sites of this function, including gro_cells >> and mac80211, so even wireless systems will benefit from it. >> The only driver that cares about the return value is >> ethernet/socionext/netsec, and only for updating statistics. I don't >> believe that this change can break its functionality, but anyway, >> we have plenty of time till next merge window to pay this change >> a proper attention. > > I don't think this will break anything on the netsec driver. Dropped > packets > will still be properly accounted for > Thank you for clarification. Do I need to mention you under separate Acked-by in v2? >> >> Besides having this functionality implemented for napi_gro_frags() >> users, the main reason is the solid performance boost that has been >> shown during tests on 1-core MIPS board (with not yet mainlined >> driver): >> >> * no batching (5.4-rc2): ~450/450 Mbit/s >> * with gro_normal_batch == 8: ~480/480 Mbit/s >> * with gro_normal_batch == 16: ~500/500 Mbit/s >> >> Applies on top of net-next. >> Thanks. >> >> Alexander Lobakin (2): >> net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() >> net: core: increase the default size of GRO_NORMAL skb lists to >> flush >> >> net/core/dev.c | 51 >> +++++++++++++++++++++++++------------------------- >> 1 file changed, 26 insertions(+), 25 deletions(-) >> >> -- >> 2.23.0 >> > > Thanks > /Ilias Regards, ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
Hi Alexander, On Fri, Oct 11, 2019 at 03:27:50PM +0300, Alexander Lobakin wrote: > Hi Ilias, > > Ilias Apalodimas wrote 11.10.2019 15:23: > > Hi Alexander, > > > > On Thu, Oct 10, 2019 at 05:42:24PM +0300, Alexander Lobakin wrote: > > > Hi Dave, > > > > > > This series was written as a continuation to commit 323ebb61e32b > > > ("net: use listified RX for handling GRO_NORMAL skbs"), and also takes > > > an advantage of listified Rx for GRO. This time, however, we're > > > targeting at a way more common and used function, napi_gro_receive(). > > > > > > There are about ~100 call sites of this function, including gro_cells > > > and mac80211, so even wireless systems will benefit from it. > > > The only driver that cares about the return value is > > > ethernet/socionext/netsec, and only for updating statistics. I don't > > > believe that this change can break its functionality, but anyway, > > > we have plenty of time till next merge window to pay this change > > > a proper attention. > > > > I don't think this will break anything on the netsec driver. Dropped > > packets > > will still be properly accounted for > > > > Thank you for clarification. Do I need to mention you under separate > Acked-by in v2? > Well i only checked for the netsec part. I'll try having a look on the whole patch and send a proper Acked-by if i get some free time! > > > > > > Besides having this functionality implemented for napi_gro_frags() > > > users, the main reason is the solid performance boost that has been > > > shown during tests on 1-core MIPS board (with not yet mainlined > > > driver): > > > > > > * no batching (5.4-rc2): ~450/450 Mbit/s > > > * with gro_normal_batch == 8: ~480/480 Mbit/s > > > * with gro_normal_batch == 16: ~500/500 Mbit/s > > > > > > Applies on top of net-next. > > > Thanks. > > > > > > Alexander Lobakin (2): > > > net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() > > > net: core: increase the default size of GRO_NORMAL skb lists to > > > flush > > > > > > net/core/dev.c | 51 > > > +++++++++++++++++++++++++------------------------- > > > 1 file changed, 26 insertions(+), 25 deletions(-) > > > > > > -- > > > 2.23.0 > > > > > > > Thanks > > /Ilias > > Regards, > ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ Regards /Ilias
Hi Dave, This series was written as a continuation to commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs"), and also takes an advantage of listified Rx for GRO. This time, however, we're targeting at a way more common and used function, napi_gro_receive(). There are about ~100 call sites of this function, including gro_cells and mac80211, so even wireless systems will benefit from it. The only driver that cares about the return value is ethernet/socionext/netsec, and only for updating statistics. I don't believe that this change can break its functionality, but anyway, we have plenty of time till next merge window to pay this change a proper attention. Besides having this functionality implemented for napi_gro_frags() users, the main reason is the solid performance boost that has been shown during tests on 1-core MIPS board (with not yet mainlined driver): * no batching (5.4-rc2): ~450/450 Mbit/s * with gro_normal_batch == 8: ~480/480 Mbit/s * with gro_normal_batch == 16: ~500/500 Mbit/s Applies on top of net-next. Thanks. Alexander Lobakin (2): net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() net: core: increase the default size of GRO_NORMAL skb lists to flush net/core/dev.c | 51 +++++++++++++++++++++++++------------------------- 1 file changed, 26 insertions(+), 25 deletions(-)