| Message ID | 20191010020725.3990-2-andrew@aj.id.au |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: ast2600: Expose RMII RCLK for MACs 1-4 | expand |
On Thu, 10 Oct 2019 at 02:06, Andrew Jeffery <andrew@aj.id.au> wrote: > > The AST2600 has an explicit gate for the RMII RCLK for each of the four > MACs. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Reviewed-by: Joel Stanley <joel@jms.id.au>
On Thu, 10 Oct 2019 12:37:24 +1030, Andrew Jeffery wrote: > The AST2600 has an explicit gate for the RMII RCLK for each of the four > MACs. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > --- > include/dt-bindings/clock/ast2600-clock.h | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
Hi clock maintainers, On Thu, 10 Oct 2019 at 02:06, Andrew Jeffery <andrew@aj.id.au> wrote: > > The AST2600 has an explicit gate for the RMII RCLK for each of the four > MACs. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> I needed this patch and the aspeed-clock.h one for the aspeed dts tree, so I've put them in a branch called "aspeed-clk-for-v5.5" and merged that into the aspeed tree. Could you merge that into the clock tree when you get to merging these ones? https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git/log/?h=aspeed-clk-for-v5.5 Cheers, Joel > --- > include/dt-bindings/clock/ast2600-clock.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h > index 38074a5f7296..62b9520a00fd 100644 > --- a/include/dt-bindings/clock/ast2600-clock.h > +++ b/include/dt-bindings/clock/ast2600-clock.h > @@ -83,6 +83,10 @@ > #define ASPEED_CLK_MAC12 64 > #define ASPEED_CLK_MAC34 65 > #define ASPEED_CLK_USBPHY_40M 66 > +#define ASPEED_CLK_MAC1RCLK 67 > +#define ASPEED_CLK_MAC2RCLK 68 > +#define ASPEED_CLK_MAC3RCLK 69 > +#define ASPEED_CLK_MAC4RCLK 70 > > /* Only list resets here that are not part of a gate */ > #define ASPEED_RESET_ADC 55 > -- > 2.20.1 >
Quoting Joel Stanley (2019-10-31 21:50:42) > Hi clock maintainers, > > On Thu, 10 Oct 2019 at 02:06, Andrew Jeffery <andrew@aj.id.au> wrote: > > > > The AST2600 has an explicit gate for the RMII RCLK for each of the four > > MACs. > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > I needed this patch and the aspeed-clock.h one for the aspeed dts > tree, so I've put them in a branch called "aspeed-clk-for-v5.5" and > merged that into the aspeed tree. Could you merge that into the clock > tree when you get to merging these ones? > > https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git/log/?h=aspeed-clk-for-v5.5 > Can you send a pull request please?
On Thu, 7 Nov 2019 at 23:00, Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Joel Stanley (2019-10-31 21:50:42) > > Hi clock maintainers, > > > > On Thu, 10 Oct 2019 at 02:06, Andrew Jeffery <andrew@aj.id.au> wrote: > > > > > > The AST2600 has an explicit gate for the RMII RCLK for each of the four > > > MACs. > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > I needed this patch and the aspeed-clock.h one for the aspeed dts > > tree, so I've put them in a branch called "aspeed-clk-for-v5.5" and > > merged that into the aspeed tree. Could you merge that into the clock > > tree when you get to merging these ones? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git/log/?h=aspeed-clk-for-v5.5 > > > > Can you send a pull request please? Sure. Here you go. Let me know if you need it in a separate email. The following changes since commit d8d9ad83a497f78edd4016df0919a49628dcafbc: dt-bindings: clock: Add AST2600 RMII RCLK gate definitions (2019-11-01 15:01:18 +1030) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git tags/aspeed-5.5-clk for you to fetch changes up to d8d9ad83a497f78edd4016df0919a49628dcafbc: dt-bindings: clock: Add AST2600 RMII RCLK gate definitions (2019-11-01 15:01:18 +1030) ---------------------------------------------------------------- ASPEED clock device tree bindings for 5.5 ---------------------------------------------------------------- >
Quoting Joel Stanley (2019-11-08 03:29:41) > On Thu, 7 Nov 2019 at 23:00, Stephen Boyd <sboyd@kernel.org> wrote: > > > > Quoting Joel Stanley (2019-10-31 21:50:42) > > > Hi clock maintainers, > > > > > > On Thu, 10 Oct 2019 at 02:06, Andrew Jeffery <andrew@aj.id.au> wrote: > > > > > > > > The AST2600 has an explicit gate for the RMII RCLK for each of the four > > > > MACs. > > > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > > > I needed this patch and the aspeed-clock.h one for the aspeed dts > > > tree, so I've put them in a branch called "aspeed-clk-for-v5.5" and > > > merged that into the aspeed tree. Could you merge that into the clock > > > tree when you get to merging these ones? > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git/log/?h=aspeed-clk-for-v5.5 > > > > > > > Can you send a pull request please? > > Sure. Here you go. Let me know if you need it in a separate email. > > The following changes since commit d8d9ad83a497f78edd4016df0919a49628dcafbc: > > dt-bindings: clock: Add AST2600 RMII RCLK gate definitions > (2019-11-01 15:01:18 +1030) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git > tags/aspeed-5.5-clk > > for you to fetch changes up to d8d9ad83a497f78edd4016df0919a49628dcafbc: > > dt-bindings: clock: Add AST2600 RMII RCLK gate definitions > (2019-11-01 15:01:18 +1030) > > ---------------------------------------------------------------- > ASPEED clock device tree bindings for 5.5 > > ---------------------------------------------------------------- The diffstat got lost? Anyway, thanks! I pulled it into clk-next.
diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h index 38074a5f7296..62b9520a00fd 100644 --- a/include/dt-bindings/clock/ast2600-clock.h +++ b/include/dt-bindings/clock/ast2600-clock.h @@ -83,6 +83,10 @@ #define ASPEED_CLK_MAC12 64 #define ASPEED_CLK_MAC34 65 #define ASPEED_CLK_USBPHY_40M 66 +#define ASPEED_CLK_MAC1RCLK 67 +#define ASPEED_CLK_MAC2RCLK 68 +#define ASPEED_CLK_MAC3RCLK 69 +#define ASPEED_CLK_MAC4RCLK 70 /* Only list resets here that are not part of a gate */ #define ASPEED_RESET_ADC 55
The AST2600 has an explicit gate for the RMII RCLK for each of the four MACs. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- include/dt-bindings/clock/ast2600-clock.h | 4 ++++ 1 file changed, 4 insertions(+)