| Message ID | 20191002014153.29831-1-pgwipeout@gmail.com |
|---|---|
| Headers | show |
| Series | enable tegra-udc host mode | expand |
On 19-10-01 21:41:48, Peter Geis wrote: > This patch set enables the tegra-udc driver to take the place of > tegra-ehci as the usb host driver. > It fixes up some checks in the tegra-udc driver. > It pulls the tegra specific bits from the tegra-ehci driver. > > It would be better to have generic helpers in the dma core that can > handle alignment, instead of using tegra specific helpers, but that is > well above my skillset. > > I haven't checked OTG functionality, mostly because I don't have any > devices with working OTG yet. I am not sure what the OTG mean here, the OTG Compliance (OTG FSM in code) are almost dead, so you don't need to consider support it. Usually, people considers dual-role switch as OTG. Peter > > Please review and submit feedback. > > Peter Geis (5): > usb: chipidea: tegra: add tegra specific flags for host mode > usb: chipidea: tegra: clean up tegra_udc flag code > usb: chipidea: tegra: add dr_mode checking to tegra-udc > usb: chipidea: tegra: add the tegra specific bits > usb: chipidea: tegra: enable tegra-udc host mode > > drivers/usb/chipidea/ci_hdrc_tegra.c | 53 ++++++--- > drivers/usb/chipidea/host.c | 13 +++ > drivers/usb/chipidea/tegra.h | 159 +++++++++++++++++++++++++++ > include/linux/usb/chipidea.h | 2 + > 4 files changed, 209 insertions(+), 18 deletions(-) > create mode 100644 drivers/usb/chipidea/tegra.h > > -- > 2.17.1 >
08.10.2019 09:25, Peter Chen пишет: > On 19-10-01 21:41:48, Peter Geis wrote: >> This patch set enables the tegra-udc driver to take the place of >> tegra-ehci as the usb host driver. >> It fixes up some checks in the tegra-udc driver. >> It pulls the tegra specific bits from the tegra-ehci driver. >> >> It would be better to have generic helpers in the dma core that can >> handle alignment, instead of using tegra specific helpers, but that is >> well above my skillset. >> >> I haven't checked OTG functionality, mostly because I don't have any >> devices with working OTG yet. > > I am not sure what the OTG mean here, the OTG Compliance (OTG FSM in > code) are almost dead, so you don't need to consider support it. > Usually, people considers dual-role switch as OTG. Yes, I assume we're talking about the dual-role switch.
On Wed, Oct 9, 2019 at 5:16 AM Dmitry Osipenko <digetx@gmail.com> wrote: > > 08.10.2019 09:25, Peter Chen пишет: > > On 19-10-01 21:41:48, Peter Geis wrote: > >> This patch set enables the tegra-udc driver to take the place of > >> tegra-ehci as the usb host driver. > >> It fixes up some checks in the tegra-udc driver. > >> It pulls the tegra specific bits from the tegra-ehci driver. > >> > >> It would be better to have generic helpers in the dma core that can > >> handle alignment, instead of using tegra specific helpers, but that is > >> well above my skillset. > >> > >> I haven't checked OTG functionality, mostly because I don't have any > >> devices with working OTG yet. > > > > I am not sure what the OTG mean here, the OTG Compliance (OTG FSM in > > code) are almost dead, so you don't need to consider support it. > > Usually, people considers dual-role switch as OTG. > > Yes, I assume we're talking about the dual-role switch. Correct, unfortunately the devicetree bindings do not differentiate between the two. You have given me a few ideas to work around this though.