| Message ID | 20191004133207.6663-7-linux@rasmusvillemoes.dk |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: mxs: add support for setting polarity via DT | expand |
On Fri, Oct 04, 2019 at 03:32:07PM +0200, Rasmus Villemoes wrote: > Commit 71523d1812ac (pwm: Ensure pwm_apply_state() doesn't modify the > state argument) updated the kernel-doc for pwm_apply_state(), but not > for the ->apply callback in the pwm_ops struct. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > include/linux/pwm.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/include/linux/pwm.h b/include/linux/pwm.h > index b2c9c460947d..0ef808d925bb 100644 > --- a/include/linux/pwm.h > +++ b/include/linux/pwm.h > @@ -243,10 +243,7 @@ pwm_set_relative_duty_cycle(struct pwm_state *state, unsigned int duty_cycle, > * @request: optional hook for requesting a PWM > * @free: optional hook for freeing a PWM > * @capture: capture and report PWM signal > - * @apply: atomically apply a new PWM config. The state argument > - * should be adjusted with the real hardware config (if the > - * approximate the period or duty_cycle value, state should > - * reflect it) > + * @apply: atomically apply a new PWM config Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On Fri, Oct 4, 2019 at 6:33 AM Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > > Commit 71523d1812ac (pwm: Ensure pwm_apply_state() doesn't modify the > state argument) updated the kernel-doc for pwm_apply_state(), but not > for the ->apply callback in the pwm_ops struct. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > include/linux/pwm.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/include/linux/pwm.h b/include/linux/pwm.h > index b2c9c460947d..0ef808d925bb 100644 > --- a/include/linux/pwm.h > +++ b/include/linux/pwm.h > @@ -243,10 +243,7 @@ pwm_set_relative_duty_cycle(struct pwm_state *state, unsigned int duty_cycle, > * @request: optional hook for requesting a PWM > * @free: optional hook for freeing a PWM > * @capture: capture and report PWM signal > - * @apply: atomically apply a new PWM config. The state argument > - * should be adjusted with the real hardware config (if the > - * approximate the period or duty_cycle value, state should > - * reflect it) > + * @apply: atomically apply a new PWM config > * @get_state: get the current PWM state. This function is only > * called once per PWM device when the PWM chip is > * registered. > -- > 2.20.1 >
diff --git a/include/linux/pwm.h b/include/linux/pwm.h index b2c9c460947d..0ef808d925bb 100644 --- a/include/linux/pwm.h +++ b/include/linux/pwm.h @@ -243,10 +243,7 @@ pwm_set_relative_duty_cycle(struct pwm_state *state, unsigned int duty_cycle, * @request: optional hook for requesting a PWM * @free: optional hook for freeing a PWM * @capture: capture and report PWM signal - * @apply: atomically apply a new PWM config. The state argument - * should be adjusted with the real hardware config (if the - * approximate the period or duty_cycle value, state should - * reflect it) + * @apply: atomically apply a new PWM config * @get_state: get the current PWM state. This function is only * called once per PWM device when the PWM chip is * registered.
Commit 71523d1812ac (pwm: Ensure pwm_apply_state() doesn't modify the state argument) updated the kernel-doc for pwm_apply_state(), but not for the ->apply callback in the pwm_ops struct. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- include/linux/pwm.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)