diff mbox series

[v2,4/4] package/x11r7/xlib_libXvMC: remove xlib_libXv dependency

Message ID 20191005094818.1956334-4-romain.naour@gmail.com
State Accepted
Headers show
Series [v2,1/4] package/llvm: add llvm RTTI option | expand

Commit Message

Romain Naour Oct. 5, 2019, 9:48 a.m. UTC
Since libXvMC 1.0.12, xv was removed from xvmc.pc [1].

[1] https://lists.x.org/archives/xorg-announce/2019-September/003023.html

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
---
This may introduce some build issue like for mesa3d :
https://cgit.freedesktop.org/mesa/mesa/commit/?id=e456a053c3d6ec4f3d4581edcad05c72dfdaa407
---
 package/x11r7/xlib_libXvMC/Config.in       | 1 -
 package/x11r7/xlib_libXvMC/xlib_libXvMC.mk | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Bernd Kuhls Oct. 5, 2019, 2:19 p.m. UTC | #1
Am Sat, 05 Oct 2019 11:48:18 +0200 schrieb Romain Naour:

> Signed-off-by: Romain Naour
> <romain.naour@gmail.com>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>

Tested-by: Bernd Kuhls <bernd.kuhls@t-online.de>
[build-tested using this defconfig:
BR2_KERNEL_HEADERS_4_4=y
BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
BR2_BINUTILS_VERSION_2_30_X=y
BR2_GCC_VERSION_5_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_INIT_NONE=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_LLVM=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU=y
BR2_PACKAGE_MESA3D_XVMC=y
BR2_PACKAGE_MESA3D_OPENGL_GLX=y
BR2_PACKAGE_MESA3D_OPENGL_EGL=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_XORG7=y]
Thomas Petazzoni Oct. 26, 2019, 8:55 p.m. UTC | #2
On Sat,  5 Oct 2019 11:48:18 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> Since libXvMC 1.0.12, xv was removed from xvmc.pc [1].
> 
> [1] https://lists.x.org/archives/xorg-announce/2019-September/003023.html

Seems like it disagrees:

  http://autobuild.buildroot.net/results/305/3051f4fbc1ab725de542a550e4f9eeb3cae385b8/build-end.log

checking for XVMC... no
configure: error: Package requirements (x11 >= 1.6 xext xv xextproto videoproto) were not met:

Thomas
Romain Naour Oct. 26, 2019, 9:10 p.m. UTC | #3
Hi Thomas, All,

Le 26/10/2019 à 22:55, Thomas Petazzoni a écrit :
> On Sat,  5 Oct 2019 11:48:18 +0200
> Romain Naour <romain.naour@gmail.com> wrote:
> 
>> Since libXvMC 1.0.12, xv was removed from xvmc.pc [1].
>>
>> [1] https://lists.x.org/archives/xorg-announce/2019-September/003023.html
> 
> Seems like it disagrees:
> 
>   http://autobuild.buildroot.net/results/305/3051f4fbc1ab725de542a550e4f9eeb3cae385b8/build-end.log
> 
> checking for XVMC... no
> configure: error: Package requirements (x11 >= 1.6 xext xv xextproto videoproto) were not met:

It seems configure.ac still list xv in PKG_CHECK_MODULES:

https://gitlab.freedesktop.org/xorg/lib/libxvmc/blob/master/configure.ac#L43

From the commit message removing xv from .pc
"This library does not itself require libXv for anything."

I'll check.

Best regards,
Romain

> 
> Thomas
>
diff mbox series

Patch

diff --git a/package/x11r7/xlib_libXvMC/Config.in b/package/x11r7/xlib_libXvMC/Config.in
index 5cc6ec766a..4be6e01774 100644
--- a/package/x11r7/xlib_libXvMC/Config.in
+++ b/package/x11r7/xlib_libXvMC/Config.in
@@ -2,7 +2,6 @@  config BR2_PACKAGE_XLIB_LIBXVMC
 	bool "libXvMC"
 	select BR2_PACKAGE_XLIB_LIBX11
 	select BR2_PACKAGE_XLIB_LIBXEXT
-	select BR2_PACKAGE_XLIB_LIBXV
 	select BR2_PACKAGE_XORGPROTO
 	help
 	  X.Org XvMC library
diff --git a/package/x11r7/xlib_libXvMC/xlib_libXvMC.mk b/package/x11r7/xlib_libXvMC/xlib_libXvMC.mk
index 02959c2305..442c410b57 100644
--- a/package/x11r7/xlib_libXvMC/xlib_libXvMC.mk
+++ b/package/x11r7/xlib_libXvMC/xlib_libXvMC.mk
@@ -10,7 +10,7 @@  XLIB_LIBXVMC_SITE = http://xorg.freedesktop.org/releases/individual/lib
 XLIB_LIBXVMC_LICENSE = MIT
 XLIB_LIBXVMC_LICENSE_FILES = COPYING
 XLIB_LIBXVMC_INSTALL_STAGING = YES
-XLIB_LIBXVMC_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXv xorgproto
+XLIB_LIBXVMC_DEPENDENCIES = xlib_libX11 xlib_libXext xorgproto
 XLIB_LIBXVMC_CONF_OPTS = --disable-malloc0returnsnull
 
 $(eval $(autotools-package))