| Message ID | 20191001143023.698-4-heiko.thiery@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/9] package/libev: use host-autotools-package macro | expand |
Hello Heiko, On Tue, 1 Oct 2019 16:30:17 +0200 heiko.thiery@gmail.com wrote: > diff --git a/package/Config.in b/package/Config.in > index abea9e2428..04cd466eba 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1640,6 +1640,7 @@ menu "Networking" > source "package/libvncserver/Config.in" > source "package/libwebsock/Config.in" > source "package/libwebsockets/Config.in" > + source "package/libyang/Config.in" > source "package/lksctp-tools/Config.in" > source "package/mongoose/Config.in" > source "package/nanomsg/Config.in" > diff --git a/package/libyang/Config.in b/package/libyang/Config.in > new file mode 100644 > index 0000000000..cfd2862c15 > --- /dev/null > +++ b/package/libyang/Config.in > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_LIBYANG > + bool "libyang - YANG data modeling language parser and toolkit" Should be just: bool "libyang" > + depends on !BR2_STATIC_LIBS > + select BR2_PACKAGE_PCRE The home page at https://github.com/CESNET/libyang says: note, that PCRE is supposed to be compiled with unicode support (configure's options --enable-utf and --enable-unicode-properties) So I think you need: select BR2_PACKAGE_PCRE_UTF Could you make sure it is indeed needed? > + help > + Libyang is YANG data modeling language parser and toolkit > + written (and providing API) in C. Upstream URL of the project. Also, you need a Config.in comment like this: comment "libyang needs a toolchain w/ dynamic library" depends on BR2_STATIC_LIBS > diff --git a/package/libyang/libyang.mk b/package/libyang/libyang.mk > new file mode 100644 > index 0000000000..9005683053 > --- /dev/null > +++ b/package/libyang/libyang.mk > @@ -0,0 +1,21 @@ > +################################################################################ > +# > +# libyang > +# > +################################################################################ > + > +LIBYANG_VERSION = v1.0-r3 > +LIBYANG_SITE = $(call github,CESNET,libyang,$(LIBYANG_VERSION)) > +LIBYANG_LICENSE = BSD-3-Clause > +LIBYANG_LICENSE_FILES = LICENSE > +LIBYANG_INSTALL_STAGING = YES > +LIBYANG_SUPPORTS_IN_SOURCE_BUILD = NO > +LIBYANG_DEPENDENCIES += pcre Just = > +HOST_LIBYANG_DEPENDENCIES += host-pcre Just = > + > +LIBYANG_CONF_OPTS += \ Just = > + -DENABLE_VALGRIND_TESTS=OFF \ > + -DGEN_PYTHON_BINDINGS=OFF What about passing the same options to the host variant ? Thanks! Thomas
Hi Thomas, > Should be just: > > bool "libyang" > > > + depends on !BR2_STATIC_LIBS > > + select BR2_PACKAGE_PCRE > > The home page at https://github.com/CESNET/libyang says: > > note, that PCRE is supposed to be compiled with unicode support > (configure's options --enable-utf and --enable-unicode-properties) > > So I think you need: > > select BR2_PACKAGE_PCRE_UTF > > Could you make sure it is indeed needed? Your are right .. I added this. -- Heiko
diff --git a/DEVELOPERS b/DEVELOPERS index a25fbb7a0d..a378ff2a61 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -1038,6 +1038,7 @@ F: package/python-sip/ N: Heiko Thiery <heiko.thiery@gmail.com> F: package/libredblack/ +F: package/libyang/ N: Henrique Camargo <henrique@henriquecamargo.com> F: package/json-glib/ diff --git a/package/Config.in b/package/Config.in index abea9e2428..04cd466eba 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1640,6 +1640,7 @@ menu "Networking" source "package/libvncserver/Config.in" source "package/libwebsock/Config.in" source "package/libwebsockets/Config.in" + source "package/libyang/Config.in" source "package/lksctp-tools/Config.in" source "package/mongoose/Config.in" source "package/nanomsg/Config.in" diff --git a/package/libyang/Config.in b/package/libyang/Config.in new file mode 100644 index 0000000000..cfd2862c15 --- /dev/null +++ b/package/libyang/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_LIBYANG + bool "libyang - YANG data modeling language parser and toolkit" + depends on !BR2_STATIC_LIBS + select BR2_PACKAGE_PCRE + help + Libyang is YANG data modeling language parser and toolkit + written (and providing API) in C. diff --git a/package/libyang/libyang.hash b/package/libyang/libyang.hash new file mode 100644 index 0000000000..4989873c8c --- /dev/null +++ b/package/libyang/libyang.hash @@ -0,0 +1,2 @@ +sha256 351f712433d50494aad153bfd4aa92ff50299058428620eabddb7a41d781e756 libyang-v1.0-r3.tar.gz +sha256 f942fe693e03e4e3ff67a351c00dc8f468a042e0d7273b0aa6bc53060b568112 LICENSE diff --git a/package/libyang/libyang.mk b/package/libyang/libyang.mk new file mode 100644 index 0000000000..9005683053 --- /dev/null +++ b/package/libyang/libyang.mk @@ -0,0 +1,21 @@ +################################################################################ +# +# libyang +# +################################################################################ + +LIBYANG_VERSION = v1.0-r3 +LIBYANG_SITE = $(call github,CESNET,libyang,$(LIBYANG_VERSION)) +LIBYANG_LICENSE = BSD-3-Clause +LIBYANG_LICENSE_FILES = LICENSE +LIBYANG_INSTALL_STAGING = YES +LIBYANG_SUPPORTS_IN_SOURCE_BUILD = NO +LIBYANG_DEPENDENCIES += pcre +HOST_LIBYANG_DEPENDENCIES += host-pcre + +LIBYANG_CONF_OPTS += \ + -DENABLE_VALGRIND_TESTS=OFF \ + -DGEN_PYTHON_BINDINGS=OFF + +$(eval $(cmake-package)) +$(eval $(host-cmake-package))