| Message ID | 20190927110911.23045-1-jarkko.nikula@linux.intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | i2c: i801: Bring back Block Process Call support for certain platforms | expand |
Thanks, Jarkko! On 27/09/2019 13:09, Jarkko Nikula wrote: > Commit b84398d6d7f9 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH > and beyond") looks like to drop by accident Block Write-Block Read Process > Call support for Intel Sunrisepoint, Lewisburg, Denverton and Kaby Lake. > > That support was added for above and newer platforms by the commit > 315cd67c9453 ("i2c: i801: Add Block Write-Block Read Process Call > support") so bring it back for above platforms. > > Fixes: b84398d6d7f9 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH and beyond") Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > --- > drivers/i2c/busses/i2c-i801.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index a4608a047468..1fed7bf00a6d 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1736,6 +1736,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) > case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS: > case PCI_DEVICE_ID_INTEL_DNV_SMBUS: > case PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS: > + priv->features |= FEATURE_BLOCK_PROC; > priv->features |= FEATURE_I2C_BLOCK_READ; > priv->features |= FEATURE_IRQ; > priv->features |= FEATURE_SMBUS_PEC;
On Fri, Sep 27, 2019 at 02:09:11PM +0300, Jarkko Nikula wrote: > Commit b84398d6d7f9 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH > and beyond") looks like to drop by accident Block Write-Block Read Process > Call support for Intel Sunrisepoint, Lewisburg, Denverton and Kaby Lake. > > That support was added for above and newer platforms by the commit > 315cd67c9453 ("i2c: i801: Add Block Write-Block Read Process Call > support") so bring it back for above platforms. > > Fixes: b84398d6d7f9 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH and beyond") > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Applied to for-current, thanks!
On Fri, 27 Sep 2019 14:09:11 +0300, Jarkko Nikula wrote: > Commit b84398d6d7f9 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH > and beyond") looks like to drop by accident Block Write-Block Read Process > Call support for Intel Sunrisepoint, Lewisburg, Denverton and Kaby Lake. And I reviewed that one :( Sorry for letting it slip through, and thanks for catching it. > That support was added for above and newer platforms by the commit > 315cd67c9453 ("i2c: i801: Add Block Write-Block Read Process Call > support") so bring it back for above platforms. > > Fixes: b84398d6d7f9 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH and beyond") > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > --- > drivers/i2c/busses/i2c-i801.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index a4608a047468..1fed7bf00a6d 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1736,6 +1736,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) > case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS: > case PCI_DEVICE_ID_INTEL_DNV_SMBUS: > case PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS: > + priv->features |= FEATURE_BLOCK_PROC; > priv->features |= FEATURE_I2C_BLOCK_READ; > priv->features |= FEATURE_IRQ; > priv->features |= FEATURE_SMBUS_PEC; Too late but still Reviewed-by: Jean Delvare <jdelvare@suse.de>
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index a4608a047468..1fed7bf00a6d 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -1736,6 +1736,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS: case PCI_DEVICE_ID_INTEL_DNV_SMBUS: case PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS: + priv->features |= FEATURE_BLOCK_PROC; priv->features |= FEATURE_I2C_BLOCK_READ; priv->features |= FEATURE_IRQ; priv->features |= FEATURE_SMBUS_PEC;
Commit b84398d6d7f9 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH and beyond") looks like to drop by accident Block Write-Block Read Process Call support for Intel Sunrisepoint, Lewisburg, Denverton and Kaby Lake. That support was added for above and newer platforms by the commit 315cd67c9453 ("i2c: i801: Add Block Write-Block Read Process Call support") so bring it back for above platforms. Fixes: b84398d6d7f9 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH and beyond") Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> --- drivers/i2c/busses/i2c-i801.c | 1 + 1 file changed, 1 insertion(+)