| Message ID | 20190912201055.13964-4-jacopo@jmondi.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v3,01/11] dt-bindings: video-interfaces: Document 'location' property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On 9/12/19 10:10 PM, Jacopo Mondi wrote: > Expand the 'rotation' property description to define the direction and > orientation of the axis around which the device mounting rotation is > expressed. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > .../devicetree/bindings/media/video-interfaces.txt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt > index e71b90a29d7a..8ab51e0bb63e 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > @@ -85,9 +85,11 @@ Optional properties > > - lens-focus: A phandle to the node of the focus lens controller. > > -- rotation: The device, typically an image sensor, is not mounted upright, > - but a number of degrees counter clockwise. Typical values are 0 and 180 > - (upside down). > +- rotation: The device, typically an image sensor, mounting rotation expressed > + as counterclockwise rotation degrees along the axis perpendicular to > + the device mounting surface directed away from it. Typical values are > + 0 degrees for upright mounted devices and 180 degrees for devices mounted > + upside down. Same as with patch 1/11: "The mount rotation of the device (typically an image sensor) expressed..." Regards, Hans > > - location: The device, typically an image sensor or a flash LED, mounting > location expressed as a position relative to the usage orientation of the > -- > 2.23.0 >
diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index e71b90a29d7a..8ab51e0bb63e 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt @@ -85,9 +85,11 @@ Optional properties - lens-focus: A phandle to the node of the focus lens controller. -- rotation: The device, typically an image sensor, is not mounted upright, - but a number of degrees counter clockwise. Typical values are 0 and 180 - (upside down). +- rotation: The device, typically an image sensor, mounting rotation expressed + as counterclockwise rotation degrees along the axis perpendicular to + the device mounting surface directed away from it. Typical values are + 0 degrees for upright mounted devices and 180 degrees for devices mounted + upside down. - location: The device, typically an image sensor or a flash LED, mounting location expressed as a position relative to the usage orientation of the
Expand the 'rotation' property description to define the direction and orientation of the axis around which the device mounting rotation is expressed. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- .../devicetree/bindings/media/video-interfaces.txt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.23.0