| Message ID | 20190909204451.7929-1-msuchanek@suse.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net/ibmvnic: Fix missing { in __ibmvnic_reset | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | warning | Failed to apply on branch next (c317052c95bef1f977b023158e5aa929215f443d) |
| snowpatch_ozlabs/apply_patch | fail | Failed to apply to any branch |
On 9/9/19 1:44 PM, Michal Suchanek wrote: > Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") > adds a } without corresponding { causing build break. > > Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com> > --- > drivers/net/ethernet/ibm/ibmvnic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c > index 6644cabc8e75..5cb55ea671e3 100644 > --- a/drivers/net/ethernet/ibm/ibmvnic.c > +++ b/drivers/net/ethernet/ibm/ibmvnic.c > @@ -1984,7 +1984,7 @@ static void __ibmvnic_reset(struct work_struct *work) > rwi = get_next_rwi(adapter); > while (rwi) { > if (adapter->state == VNIC_REMOVING || > - adapter->state == VNIC_REMOVED) > + adapter->state == VNIC_REMOVED) { > kfree(rwi); > rc = EBUSY; > break; >
On 9/9/19 3:44 PM, Michal Suchanek wrote: > Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") > adds a } without corresponding { causing build break. > > Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Reviewed-by: Juliet Kim <julietk@linux.vnet.ibm.com> > --- > drivers/net/ethernet/ibm/ibmvnic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c > index 6644cabc8e75..5cb55ea671e3 100644 > --- a/drivers/net/ethernet/ibm/ibmvnic.c > +++ b/drivers/net/ethernet/ibm/ibmvnic.c > @@ -1984,7 +1984,7 @@ static void __ibmvnic_reset(struct work_struct *work) > rwi = get_next_rwi(adapter); > while (rwi) { > if (adapter->state == VNIC_REMOVING || > - adapter->state == VNIC_REMOVED) > + adapter->state == VNIC_REMOVED) { > kfree(rwi); > rc = EBUSY; > break;
From: Michal Suchanek <msuchanek@suse.de> Date: Mon, 9 Sep 2019 22:44:51 +0200 > Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") > adds a } without corresponding { causing build break. > > Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Applied.
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 6644cabc8e75..5cb55ea671e3 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1984,7 +1984,7 @@ static void __ibmvnic_reset(struct work_struct *work) rwi = get_next_rwi(adapter); while (rwi) { if (adapter->state == VNIC_REMOVING || - adapter->state == VNIC_REMOVED) + adapter->state == VNIC_REMOVED) { kfree(rwi); rc = EBUSY; break;
Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") adds a } without corresponding { causing build break. Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)