| Message ID | 20190905072142.14606-2-dongchun.zhu@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | media: i2c: add support for DW9768 VCM driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Sep 05, 2019 at 03:21:41PM +0800, dongchun.zhu@mediatek.com wrote: > From: Dongchun Zhu <dongchun.zhu@mediatek.com> > > This patch is to add the Devicetree binding documentation and > MAINTAINERS entry for dw9768 actuator. > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com> > --- > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt | 9 +++++++++ > MAINTAINERS | 7 +++++++ This should be: 1) two separate patches 2) binding in YAML
On Thu, Sep 05, 2019 at 01:14:06PM +0300, Andy Shevchenko wrote: > On Thu, Sep 05, 2019 at 03:21:41PM +0800, dongchun.zhu@mediatek.com wrote: > > From: Dongchun Zhu <dongchun.zhu@mediatek.com> > > > > This patch is to add the Devicetree binding documentation and > > MAINTAINERS entry for dw9768 actuator. > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com> > > --- > > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt | 9 +++++++++ > > MAINTAINERS | 7 +++++++ > > This should be: > 1) two separate patches Why? The MAINTAINERS entry is usually added in the first patch needing it, isn't it?
On Thu, Sep 05, 2019 at 01:48:30PM +0300, Sakari Ailus wrote: > On Thu, Sep 05, 2019 at 01:14:06PM +0300, Andy Shevchenko wrote: > > On Thu, Sep 05, 2019 at 03:21:41PM +0800, dongchun.zhu@mediatek.com wrote: > > > From: Dongchun Zhu <dongchun.zhu@mediatek.com> > > > > > > This patch is to add the Devicetree binding documentation and > > > MAINTAINERS entry for dw9768 actuator. > > > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com> > > > --- > > > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt | 9 +++++++++ > > > MAINTAINERS | 7 +++++++ > > > > This should be: > > 1) two separate patches > > Why? The MAINTAINERS entry is usually added in the first patch needing it, > isn't it? Bindings are required to be a separate patch. Rob, is it still the case or am I mistaken?
On Thu, Sep 5, 2019 at 1:35 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Sep 05, 2019 at 01:48:30PM +0300, Sakari Ailus wrote: > > On Thu, Sep 05, 2019 at 01:14:06PM +0300, Andy Shevchenko wrote: > > > On Thu, Sep 05, 2019 at 03:21:41PM +0800, dongchun.zhu@mediatek.com wrote: > > > > From: Dongchun Zhu <dongchun.zhu@mediatek.com> > > > > > > > > This patch is to add the Devicetree binding documentation and > > > > MAINTAINERS entry for dw9768 actuator. > > > > > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com> > > > > --- > > > > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt | 9 +++++++++ > > > > MAINTAINERS | 7 +++++++ > > > > > > This should be: > > > 1) two separate patches > > > > Why? The MAINTAINERS entry is usually added in the first patch needing it, > > isn't it? > > Bindings are required to be a separate patch. > Rob, is it still the case or am I mistaken? > According to the rule 0 in [1] it should be a separate patch indeed and also use as subject "dt-bindings: <binding dir>: ..." which this patch also doesn't follow. So if I'm reading that document correctly, then I think the maintainers entry should be added in patch 2/2 along with the driver. [1]: https://www.kernel.org/doc/Documentation/devicetree/bindings/submitting-patches.txt Best regards, Javier
On Thu, Sep 05, 2019 at 01:49:28PM +0200, Javier Martinez Canillas wrote: > On Thu, Sep 5, 2019 at 1:35 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Thu, Sep 05, 2019 at 01:48:30PM +0300, Sakari Ailus wrote: > > > On Thu, Sep 05, 2019 at 01:14:06PM +0300, Andy Shevchenko wrote: > > > > On Thu, Sep 05, 2019 at 03:21:41PM +0800, dongchun.zhu@mediatek.com wrote: > > > > > From: Dongchun Zhu <dongchun.zhu@mediatek.com> > > > > > > > > > > This patch is to add the Devicetree binding documentation and > > > > > MAINTAINERS entry for dw9768 actuator. > > > > > > > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com> > > > > > --- > > > > > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt | 9 +++++++++ > > > > > MAINTAINERS | 7 +++++++ > > > > > > > > This should be: > > > > 1) two separate patches > > > > > > Why? The MAINTAINERS entry is usually added in the first patch needing it, > > > isn't it? > > > > Bindings are required to be a separate patch. > > Rob, is it still the case or am I mistaken? > > > > According to the rule 0 in [1] it should be a separate patch indeed > and also use as subject "dt-bindings: <binding dir>: ..." which this > patch also doesn't follow. > So if I'm reading that document correctly, then I think the > maintainers entry should be added in patch 2/2 along with the driver. I understand [1] discussing the need for the bindings to be a "separate patch" means a separate patch from the _driver_ for the device, not the MAINTAINERS change. Bindings come before the driver, and MAINTAINERS entry needs to be there no later than the files. And I see no reason to add a separate patch just for MAINTAINERS change. > > [1]: https://www.kernel.org/doc/Documentation/devicetree/bindings/submitting-patches.txt
On Thu, Sep 05, 2019 at 03:00:12PM +0300, Sakari Ailus wrote: > And I see no reason to add a separate patch just for > MAINTAINERS change. It's up to maintainers of the subsystem.
On Thu, Sep 05, 2019 at 03:24:49PM +0300, Andy Shevchenko wrote: > On Thu, Sep 05, 2019 at 03:00:12PM +0300, Sakari Ailus wrote: > > > And I see no reason to add a separate patch just for > > MAINTAINERS change. > > It's up to maintainers of the subsystem. Just update MAINTAINERS with the driver. It doesn't need to be so complicated or per subsystem. There's enough of what each maintainer wants already. Rob
diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt new file mode 100644 index 0000000..94b8ec3 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt @@ -0,0 +1,9 @@ +Dongwoon Anatech DW9768 camera voice coil lens driver + +DW9768 is a 10-bit DAC with current sink capability. It is intended +for driving voice coil lenses in camera modules. + +Mandatory properties: + +- compatible: "dongwoon,dw9768" +- reg: I²C slave address diff --git a/MAINTAINERS b/MAINTAINERS index 783569e..192a671 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4971,6 +4971,13 @@ S: Maintained F: drivers/media/i2c/dw9714.c F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt +DONGWOON DW9768 LENS VOICE COIL DRIVER +M: Dongchun Zhu <dongchun.zhu@mediatek.com> +L: linux-media@vger.kernel.org +T: git git://linuxtv.org/media_tree.git +S: Maintained +F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt + DONGWOON DW9807 LENS VOICE COIL DRIVER M: Sakari Ailus <sakari.ailus@linux.intel.com> L: linux-media@vger.kernel.org