Message ID | 20190904061245.30770-4-rashmica.g@gmail.com |
---|---|
State | New |
Headers | show |
Series | [1/4] gpio/aspeed: Fix incorrect number of banks | expand |
śr., 4 wrz 2019 o 08:13 Rashmica Gupta <rashmica.g@gmail.com> napisał(a): > Again, this needs a proper commit description and the subject should start with "dt-bindings: ...". You also need to Cc the device-tree maintainers. Use scripts/get_maintainer.pl to list all people that should get this patch. Bart > Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com> > --- > Documentation/devicetree/bindings/gpio/gpio-aspeed.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt > index 7e9b586770b0..cd388797e07c 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt > @@ -2,7 +2,8 @@ Aspeed GPIO controller Device Tree Bindings > ------------------------------------------- > > Required properties: > -- compatible : Either "aspeed,ast2400-gpio" or "aspeed,ast2500-gpio" > +- compatible : Either "aspeed,ast2400-gpio", "aspeed,ast2500-gpio", > + "aspeed,ast2600-gpio", or "aspeed,ast2600-1-8v-gpio" > > - #gpio-cells : Should be two > - First cell is the GPIO line number > -- > 2.20.1 >
On Wed, 2019-09-04 at 09:02 +0200, Bartosz Golaszewski wrote: > śr., 4 wrz 2019 o 08:13 Rashmica Gupta <rashmica.g@gmail.com> > napisał(a): > > Again, this needs a proper commit description I figured as similar patches have gone through with just the one line and there isn't anything more to say that the one line message that this would be ok. >and the subject should > start with "dt-bindings: ...". > True. > You also need to Cc the device-tree maintainers. Use > scripts/get_maintainer.pl to list all people that should get this > patch. Must have missed that one somehow. > > Bart > > > Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com> > > --- > > Documentation/devicetree/bindings/gpio/gpio-aspeed.txt | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/gpio/gpio- aspeed.txt > > b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt > > index 7e9b586770b0..cd388797e07c 100644 > > --- a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt > > +++ b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt > > @@ -2,7 +2,8 @@ Aspeed GPIO controller Device Tree Bindings > > ------------------------------------------- > > > > Required properties: > > -- compatible : Either "aspeed,ast2400-gpio" or > > "aspeed,ast2500-gpio" > > +- compatible : Either "aspeed,ast2400-gpio", > > "aspeed,ast2500-gpio", > > + "aspeed,ast2600-gpio", or > > "aspeed,ast2600-1-8v-gpio" > > > > - #gpio-cells : Should be two > > - First cell is the GPIO line number > > -- > > 2.20.1 > >
diff --git a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt index 7e9b586770b0..cd388797e07c 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt +++ b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt @@ -2,7 +2,8 @@ Aspeed GPIO controller Device Tree Bindings ------------------------------------------- Required properties: -- compatible : Either "aspeed,ast2400-gpio" or "aspeed,ast2500-gpio" +- compatible : Either "aspeed,ast2400-gpio", "aspeed,ast2500-gpio", + "aspeed,ast2600-gpio", or "aspeed,ast2600-1-8v-gpio" - #gpio-cells : Should be two - First cell is the GPIO line number
Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com> --- Documentation/devicetree/bindings/gpio/gpio-aspeed.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)