| Message ID | 20190904135918.25352-26-yuehaibing@huawei.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | use devm_platform_ioremap_resource() to simplify code | expand |
On Wed, 4 Sep 2019 at 16:00, YueHaibing <yuehaibing@huawei.com> wrote: > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@huawei.com> This tag does not look real... First of all where is the report? Second, it was reported by coccinelle. Reported-by should be use to give real credits. Best regards, Krzysztof > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/spi/spi-s3c24xx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c > index aea8fd9..2d6e37f 100644 > --- a/drivers/spi/spi-s3c24xx.c > +++ b/drivers/spi/spi-s3c24xx.c > @@ -487,7 +487,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) > struct s3c2410_spi_info *pdata; > struct s3c24xx_spi *hw; > struct spi_master *master; > - struct resource *res; > int err = 0; > > master = spi_alloc_master(&pdev->dev, sizeof(struct s3c24xx_spi)); > @@ -536,8 +535,7 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) > dev_dbg(hw->dev, "bitbang at %p\n", &hw->bitbang); > > /* find and map our resources */ > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - hw->regs = devm_ioremap_resource(&pdev->dev, res); > + hw->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(hw->regs)) { > err = PTR_ERR(hw->regs); > goto err_no_pdata; > -- > 2.7.4 > >
On Wed, Sep 04, 2019 at 04:28:29PM +0200, Krzysztof Kozlowski wrote: > On Wed, 4 Sep 2019 at 16:00, YueHaibing <yuehaibing@huawei.com> wrote: > > Reported-by: Hulk Robot <hulkci@huawei.com> > This tag does not look real... First of all where is the report? > Second, it was reported by coccinelle. > Reported-by should be use to give real credits. I think it's reasonable, it's giving credit to the automated system they've got running coccinelle (which they do mention in their commit logs). It doesn't really hurt anyone and lets people see their system is finding stuff.
On 2019/9/4 22:28, Krzysztof Kozlowski wrote: > On Wed, 4 Sep 2019 at 16:00, YueHaibing <yuehaibing@huawei.com> wrote: >> >> Use devm_platform_ioremap_resource() to simplify the code a bit. >> This is detected by coccinelle. >> >> Reported-by: Hulk Robot <hulkci@huawei.com> > > This tag does not look real... First of all where is the report? It is our internal CI robot, which is unavailable to external temporarily. > Second, it was reported by coccinelle. > Reported-by should be use to give real credits. > > Best regards, > Krzysztof > >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/spi/spi-s3c24xx.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c >> index aea8fd9..2d6e37f 100644 >> --- a/drivers/spi/spi-s3c24xx.c >> +++ b/drivers/spi/spi-s3c24xx.c >> @@ -487,7 +487,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) >> struct s3c2410_spi_info *pdata; >> struct s3c24xx_spi *hw; >> struct spi_master *master; >> - struct resource *res; >> int err = 0; >> >> master = spi_alloc_master(&pdev->dev, sizeof(struct s3c24xx_spi)); >> @@ -536,8 +535,7 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) >> dev_dbg(hw->dev, "bitbang at %p\n", &hw->bitbang); >> >> /* find and map our resources */ >> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - hw->regs = devm_ioremap_resource(&pdev->dev, res); >> + hw->regs = devm_platform_ioremap_resource(pdev, 0); >> if (IS_ERR(hw->regs)) { >> err = PTR_ERR(hw->regs); >> goto err_no_pdata; >> -- >> 2.7.4 >> >> > > . >
On Wed, 4 Sep 2019 at 16:39, Mark Brown <broonie@kernel.org> wrote: > > On Wed, Sep 04, 2019 at 04:28:29PM +0200, Krzysztof Kozlowski wrote: > > On Wed, 4 Sep 2019 at 16:00, YueHaibing <yuehaibing@huawei.com> wrote: > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > > This tag does not look real... First of all where is the report? > > Second, it was reported by coccinelle. > > Reported-by should be use to give real credits. > > I think it's reasonable, it's giving credit to the automated system > they've got running coccinelle (which they do mention in their commit > logs). It doesn't really hurt anyone and lets people see their system > is finding stuff. Running internally coccinelle is already credited with commit author. The credits are coming with "From:" field. Otherwise for commits I send I could use: From: krzk ... Reported-by: www.krzk.eu Signed-off-by: krzk To me it is ridiculous. Different thing is that Reported-by is for fixing bugs or issues. There is no bug here. There is no problem solved except making the code smaller. That's not what is Reported-by for. Best regards, Krzysztof
On Wed, Sep 04, 2019 at 05:09:45PM +0200, Krzysztof Kozlowski wrote: > On Wed, 4 Sep 2019 at 16:39, Mark Brown <broonie@kernel.org> wrote: > > I think it's reasonable, it's giving credit to the automated system > > they've got running coccinelle (which they do mention in their commit > > logs). It doesn't really hurt anyone and lets people see their system > > is finding stuff. > Running internally coccinelle is already credited with commit author. > The credits are coming with "From:" field. I guess if other people look at the same CI and send patches as well then there's some use tying them all together. > Otherwise for commits I send I could use: > From: krzk > ... > Reported-by: www.krzk.eu > Signed-off-by: krzk > To me it is ridiculous. Sure, on the other hand it doesn't really cost anyone anything if you do that. > Different thing is that Reported-by is for fixing bugs or issues. > There is no bug here. There is no problem solved except making the > code smaller. That's not what is Reported-by for. That is true, this one isn't fixing any bug but then the line does get a bit fuzzy all round with things like warnings and coccinelle output - even just having the warning pop up is noise for people looking at the output even if there's no concrete problem. Again I don't see it as something that's worth getting worked up over.
On 9/4/19 15:59, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Hi Yuehaibing, > >> Use devm_platform_ioremap_resource() to simplify the code a bit. > >> This is detected by coccinelle. > >> > >> Reported-by: Hulk Robot <hulkci@huawei.com> > > > > This tag does not look real... First of all where is the report? > > It is our internal CI robot, which is unavailable to external temporarily. Hulk Robot is not a person and not accountable for his report. If it is your internal CI, please write a sentence stating that the fix has been made using Huawei internal tools. Credit must be given to tools as well, but not accounts that will never answer an e-mail. Otherwise, the patch would look fine. Andi
diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c index aea8fd9..2d6e37f 100644 --- a/drivers/spi/spi-s3c24xx.c +++ b/drivers/spi/spi-s3c24xx.c @@ -487,7 +487,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) struct s3c2410_spi_info *pdata; struct s3c24xx_spi *hw; struct spi_master *master; - struct resource *res; int err = 0; master = spi_alloc_master(&pdev->dev, sizeof(struct s3c24xx_spi)); @@ -536,8 +535,7 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) dev_dbg(hw->dev, "bitbang at %p\n", &hw->bitbang); /* find and map our resources */ - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - hw->regs = devm_ioremap_resource(&pdev->dev, res); + hw->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(hw->regs)) { err = PTR_ERR(hw->regs); goto err_no_pdata;
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/spi/spi-s3c24xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)