| Message ID | 20190816163042.6604-1-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [GIT,PULL,1/3] soc: samsung: Exynos for v5.4 | expand |
On Fri, 16 Aug 2019 at 18:30, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: > > Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-5.4 > > for you to fetch changes up to 40d8aff614f71ab3cab20785b4f213e3802d4e87: > > soc: samsung: chipid: Convert exynos-chipid driver to use the regmap API (2019-08-15 20:25:25 +0200) > > ---------------------------------------------------------------- > Samsung soc drivers changes for v5.4 > > Add Exynos Chipid driver for identification of product IDs and SoC > revisions. The driver also exposes chipid regmap, later to be used by > Exynos Adaptive Supply Voltage driver (adjusting voltages to different > revisions of same SoC). It turns out that it brings troubles (code is executed on every platform polluting logs because it is an initcall, not a driver) so Sylwester (submitter) asked to skip the submission. Please ignore the pull request. Best regards, Krzysztof
On Wed, Aug 21, 2019 at 09:51:09AM +0200, Krzysztof Kozlowski wrote: > On Fri, 16 Aug 2019 at 18:30, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: > > > > Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) > > > > are available in the Git repository at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-5.4 > > > > for you to fetch changes up to 40d8aff614f71ab3cab20785b4f213e3802d4e87: > > > > soc: samsung: chipid: Convert exynos-chipid driver to use the regmap API (2019-08-15 20:25:25 +0200) > > > > ---------------------------------------------------------------- > > Samsung soc drivers changes for v5.4 > > > > Add Exynos Chipid driver for identification of product IDs and SoC > > revisions. The driver also exposes chipid regmap, later to be used by > > Exynos Adaptive Supply Voltage driver (adjusting voltages to different > > revisions of same SoC). > > It turns out that it brings troubles (code is executed on every > platform polluting logs because it is an initcall, not a driver) so > Sylwester (submitter) asked to skip the submission. > > Please ignore the pull request. I talked with Sylwester and Bartlomiej who contributed the chipid driver and they provided small incremental fixes. The driver is still useful and in the future it will be expanded towards AVS. Therefore please pull it or optionally wait a week and I will send incremental pull request with fixes. Best regards, Krzysztof
On Thu, Aug 22, 2019 at 8:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Wed, Aug 21, 2019 at 09:51:09AM +0200, Krzysztof Kozlowski wrote: > > On Fri, 16 Aug 2019 at 18:30, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: > > > > > > Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) > > > > > > are available in the Git repository at: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-5.4 > > > > > > for you to fetch changes up to 40d8aff614f71ab3cab20785b4f213e3802d4e87: > > > > > > soc: samsung: chipid: Convert exynos-chipid driver to use the regmap API (2019-08-15 20:25:25 +0200) > > > > > > ---------------------------------------------------------------- > > > Samsung soc drivers changes for v5.4 > > > > > > Add Exynos Chipid driver for identification of product IDs and SoC > > > revisions. The driver also exposes chipid regmap, later to be used by > > > Exynos Adaptive Supply Voltage driver (adjusting voltages to different > > > revisions of same SoC). > > > > It turns out that it brings troubles (code is executed on every > > platform polluting logs because it is an initcall, not a driver) so > > Sylwester (submitter) asked to skip the submission. > > > > Please ignore the pull request. > > I talked with Sylwester and Bartlomiej who contributed the chipid driver > and they provided small incremental fixes. The driver is still useful > and in the future it will be expanded towards AVS. Therefore please pull > it or optionally wait a week and I will send incremental pull request > with fixes. Pulled into arm/drivers for now. I have drafted a related patch recently, regarding the related arch/arm/plat-samsung/cpu.c file. This is part of a longer series I'm working on, see https://pastebin.com/ZqeU3Mth for the current version of this patch. The observation is that mach-exynos is almost completely independent of plat-samsung these days, and my patch removes the last obstacle from separating the two. I have another set of patches to do the same for mach-s5pv210 (which shares half of its pm.c with plat-samsung, but nothing else). Arnd
On Tue, 3 Sep 2019 at 19:21, Arnd Bergmann <arnd@arndb.de> wrote: > > On Thu, Aug 22, 2019 at 8:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Wed, Aug 21, 2019 at 09:51:09AM +0200, Krzysztof Kozlowski wrote: > > > On Fri, 16 Aug 2019 at 18:30, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > > > The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: > > > > > > > > Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) > > > > > > > > are available in the Git repository at: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-5.4 > > > > > > > > for you to fetch changes up to 40d8aff614f71ab3cab20785b4f213e3802d4e87: > > > > > > > > soc: samsung: chipid: Convert exynos-chipid driver to use the regmap API (2019-08-15 20:25:25 +0200) > > > > > > > > ---------------------------------------------------------------- > > > > Samsung soc drivers changes for v5.4 > > > > > > > > Add Exynos Chipid driver for identification of product IDs and SoC > > > > revisions. The driver also exposes chipid regmap, later to be used by > > > > Exynos Adaptive Supply Voltage driver (adjusting voltages to different > > > > revisions of same SoC). > > > > > > It turns out that it brings troubles (code is executed on every > > > platform polluting logs because it is an initcall, not a driver) so > > > Sylwester (submitter) asked to skip the submission. > > > > > > Please ignore the pull request. > > > > I talked with Sylwester and Bartlomiej who contributed the chipid driver > > and they provided small incremental fixes. The driver is still useful > > and in the future it will be expanded towards AVS. Therefore please pull > > it or optionally wait a week and I will send incremental pull request > > with fixes. > > Pulled into arm/drivers for now. > > I have drafted a related patch recently, regarding the related > arch/arm/plat-samsung/cpu.c file. This is part of a longer series > I'm working on, see https://pastebin.com/ZqeU3Mth for the > current version of this patch. You can then also adjust the include path in arch/arm/mach-exynos/Makefile. > The observation is that mach-exynos > is almost completely independent of plat-samsung these days, and my > patch removes the last obstacle from separating the two. I have > another set of patches to do the same for mach-s5pv210 (which shares > half of its pm.c with plat-samsung, but nothing else). Great! Best regards, Krzysztof
On Wed, Sep 4, 2019 at 10:37 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Tue, 3 Sep 2019 at 19:21, Arnd Bergmann <arnd@arndb.de> wrote: > > On Thu, Aug 22, 2019 at 8:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > I have drafted a related patch recently, regarding the related > > arch/arm/plat-samsung/cpu.c file. This is part of a longer series > > I'm working on, see https://pastebin.com/ZqeU3Mth for the > > current version of this patch. > > You can then also adjust the include path in arch/arm/mach-exynos/Makefile. Yes, that is part of the following patch, along with replacing all the 'depends on PLAT_SAMSUNG' in Kconfig with 'depends on PLAT_SAMSUNG || ARCH_EXYNOS'. > > The observation is that mach-exynos > > is almost completely independent of plat-samsung these days, and my > > patch removes the last obstacle from separating the two. I have > > another set of patches to do the same for mach-s5pv210 (which shares > > half of its pm.c with plat-samsung, but nothing else). > > Great! FYI, the other parts of the series include: - Changing all s3c24xx drivers to no longer use mach/*.h or plat/*.h header files, as preparation for multiplatform support. This is work in progress, but mostly done, with cpufreq and ASoC as the notable exceptions. - Merging mach-s3c24xx, mach-s3c64xx and plat-samsung into a common mach-s3c directory. This seems to work fine and looks nicer than having three tightly connected directories, but the downside is that all path names change and the directory becomes fairly large. I think we can actually do the same thing for all remaining plat-* directories. - eventually making all ARMv5 platforms link into a single kernel, like we do with ARMv6 and ARMv7 (more to be done there, but s3c24xx and pxa are the harder bits here). Arnd
The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-5.4 for you to fetch changes up to 40d8aff614f71ab3cab20785b4f213e3802d4e87: soc: samsung: chipid: Convert exynos-chipid driver to use the regmap API (2019-08-15 20:25:25 +0200) ---------------------------------------------------------------- Samsung soc drivers changes for v5.4 Add Exynos Chipid driver for identification of product IDs and SoC revisions. The driver also exposes chipid regmap, later to be used by Exynos Adaptive Supply Voltage driver (adjusting voltages to different revisions of same SoC). ---------------------------------------------------------------- Pankaj Dubey (1): soc: samsung: Add exynos chipid driver support Sylwester Nawrocki (1): soc: samsung: chipid: Convert exynos-chipid driver to use the regmap API drivers/soc/samsung/Kconfig | 5 ++ drivers/soc/samsung/Makefile | 2 + drivers/soc/samsung/exynos-chipid.c | 101 ++++++++++++++++++++++++++++++ include/linux/soc/samsung/exynos-chipid.h | 52 +++++++++++++++ 4 files changed, 160 insertions(+) create mode 100644 drivers/soc/samsung/exynos-chipid.c create mode 100644 include/linux/soc/samsung/exynos-chipid.h