Message ID | 20190830090244.13566-2-andrew@aj.id.au |
---|---|
State | Superseded, archived |
Headers | show |
Series | mmc: sdhci-of-aspeed: Fixes for AST2600 eMMC | expand |
On Fri, 30 Aug 2019 at 09:02, Andrew Jeffery <andrew@aj.id.au> wrote: > > From: Wei Yongjun <weiyongjun1@huawei.com> > > In case of error, the function of_platform_device_create() returns > NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > Reviewed-by: Andrew Jeffery <andrew@aj.id.au> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > (cherry picked from commit 7b7de08a14b59d45cc4720bfb21732063ccfc8f6) > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Reviewed-by: Joel Stanley <joel@jms.id.au>
diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c index 8bb095ca2fa9..d5acb5afc50f 100644 --- a/drivers/mmc/host/sdhci-of-aspeed.c +++ b/drivers/mmc/host/sdhci-of-aspeed.c @@ -261,9 +261,9 @@ static int aspeed_sdc_probe(struct platform_device *pdev) struct platform_device *cpdev; cpdev = of_platform_device_create(child, NULL, &pdev->dev); - if (IS_ERR(cpdev)) { + if (!cpdev) { of_node_put(child); - ret = PTR_ERR(cpdev); + ret = -ENODEV; goto err_clk; } }