| Message ID | e99c0d7a55869a4425250c601b80a3331c9d0976.1566542696.git.chunfeng.yun@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, Aug 23, 2019 at 03:00:08PM +0800, Chunfeng Yun wrote: > Add two optional properties, one for J-K test, another for disconnect > threshold, both of them can be used to debug disconnection issues. Testing and debug properties aren't really things that belong in DT. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > index a5f7a4f0dbc1..d5b327f85fa2 100644 > --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > @@ -52,6 +52,8 @@ Optional properties (PHY_TYPE_USB2 port (child) node): > - mediatek,eye-vrt : u32, the selection of VRT reference voltage > - mediatek,eye-term : u32, the selection of HS_TX TERM reference voltage > - mediatek,bc12 : bool, enable BC12 of u2phy if support it > +- mediatek,discth : u32, the voltage of disconnect threshold > +- mediatek,intr : u32, the value of internal R (resistance) These need units as defined in property-units.txt. > > Example: > > -- > 2.23.0 >
On Thu, 2019-08-29 at 14:23 -0500, Rob Herring wrote: > On Fri, Aug 23, 2019 at 03:00:08PM +0800, Chunfeng Yun wrote: > > Add two optional properties, one for J-K test, another for disconnect > > threshold, both of them can be used to debug disconnection issues. > > Testing and debug properties aren't really things that belong in DT. They are not only for test and debug, but also used to tune default value for some platforms, I'll modify the description > > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > > index a5f7a4f0dbc1..d5b327f85fa2 100644 > > --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > > +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > > @@ -52,6 +52,8 @@ Optional properties (PHY_TYPE_USB2 port (child) node): > > - mediatek,eye-vrt : u32, the selection of VRT reference voltage > > - mediatek,eye-term : u32, the selection of HS_TX TERM reference voltage > > - mediatek,bc12 : bool, enable BC12 of u2phy if support it > > +- mediatek,discth : u32, the voltage of disconnect threshold > > +- mediatek,intr : u32, the value of internal R (resistance) > > These need units as defined in property-units.txt. They are in fact the choice index of different level, will modify it Thank you > > > > > Example: > > > > -- > > 2.23.0 > >
diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt index a5f7a4f0dbc1..d5b327f85fa2 100644 --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt @@ -52,6 +52,8 @@ Optional properties (PHY_TYPE_USB2 port (child) node): - mediatek,eye-vrt : u32, the selection of VRT reference voltage - mediatek,eye-term : u32, the selection of HS_TX TERM reference voltage - mediatek,bc12 : bool, enable BC12 of u2phy if support it +- mediatek,discth : u32, the voltage of disconnect threshold +- mediatek,intr : u32, the value of internal R (resistance) Example:
Add two optional properties, one for J-K test, another for disconnect threshold, both of them can be used to debug disconnection issues. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 2 ++ 1 file changed, 2 insertions(+)