Message ID | 1305558417-24354-2-git-send-email-mgorman@suse.de |
---|---|
State | Not Applicable, archived |
Headers | show |
On Mon, May 16, 2011 at 04:06:56PM +0100, Mel Gorman wrote: > From: Johannes Weiner <hannes@cmpxchg.org> > > Johannes Weiner poined out that the logic in commit [1741c877: mm: > kswapd: keep kswapd awake for high-order allocations until a percentage > of the node is balanced] is backwards. Instead of allowing kswapd to go > to sleep when balancing for high order allocations, it keeps it kswapd > running uselessly. > > Signed-off-by: Mel Gorman <mgorman@suse.de> > Reviewed-by: Rik van Riel <riel@redhat.com> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 17, 2011 at 12:06 AM, Mel Gorman <mgorman@suse.de> wrote: > From: Johannes Weiner <hannes@cmpxchg.org> > > Johannes Weiner poined out that the logic in commit [1741c877: mm: > kswapd: keep kswapd awake for high-order allocations until a percentage > of the node is balanced] is backwards. Instead of allowing kswapd to go > to sleep when balancing for high order allocations, it keeps it kswapd > running uselessly. > > Signed-off-by: Mel Gorman <mgorman@suse.de> > Reviewed-by: Rik van Riel <riel@redhat.com> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
On Mon, May 16, 2011 at 05:26:08PM +0200, Johannes Weiner wrote: > On Mon, May 16, 2011 at 04:06:56PM +0100, Mel Gorman wrote: > > From: Johannes Weiner <hannes@cmpxchg.org> > > > > Johannes Weiner poined out that the logic in commit [1741c877: mm: > > kswapd: keep kswapd awake for high-order allocations until a percentage > > of the node is balanced] is backwards. Instead of allowing kswapd to go > > to sleep when balancing for high order allocations, it keeps it kswapd > > running uselessly. > > > > Signed-off-by: Mel Gorman <mgorman@suse.de> > > Reviewed-by: Rik van Riel <riel@redhat.com> > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Reviewed-by: Wu Fengguang <fengguang.wu@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/mm/vmscan.c b/mm/vmscan.c index f6b435c..af24d1e 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2286,7 +2286,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining, * must be balanced */ if (order) - return pgdat_balanced(pgdat, balanced, classzone_idx); + return !pgdat_balanced(pgdat, balanced, classzone_idx); else return !all_zones_ok; }