| Message ID | 20190825135154.11488-3-jacopo+renesas@jmondi.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Sun, Aug 25, 2019 at 03:51:42PM +0200, Jacopo Mondi wrote: > Document the newly added 'cmms' property which accepts a list of phandle > and channel index pairs that point to the CMM units available for each > Display Unit output video channel. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > index c97dfacad281..c2265e2a1af2 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > @@ -45,6 +45,10 @@ Required Properties: > instance that serves the DU channel, and the channel index identifies the > LIF instance in that VSP. > > + - cmms: A list of phandles to the CMM instances present in the SoC, one > + for each available DU channel. The property shall not be specified for > + SoCs that do not provide any CMM (such as V3M and V3H). renesas,cmms Perhaps define what CMM is. > + > Required nodes: > > The connections to the DU output video ports are modeled using the OF graph > @@ -91,6 +95,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU > <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.2", "du.3"; > vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; > + cmms = <&cmm0 &cmm1 &cmm2 &cmm3>; > > ports { > #address-cells = <1>; > -- > 2.22.0 >
On Tue, Aug 27, 2019 at 10:29 PM Rob Herring <robh@kernel.org> wrote: > On Sun, Aug 25, 2019 at 03:51:42PM +0200, Jacopo Mondi wrote: > > Document the newly added 'cmms' property which accepts a list of phandle > > and channel index pairs that point to the CMM units available for each > > Display Unit output video channel. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > > index c97dfacad281..c2265e2a1af2 100644 > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > @@ -45,6 +45,10 @@ Required Properties: > > instance that serves the DU channel, and the channel index identifies the > > LIF instance in that VSP. > > > > + - cmms: A list of phandles to the CMM instances present in the SoC, one > > + for each available DU channel. The property shall not be specified for > > + SoCs that do not provide any CMM (such as V3M and V3H). > > renesas,cmms So I guess we really wanted to have the prefix for the vsps property, too? Gr{oetje,eeting}s, Geert
On Wed, Aug 28, 2019 at 09:32:23AM +0200, Geert Uytterhoeven wrote: > On Tue, Aug 27, 2019 at 10:29 PM Rob Herring <robh@kernel.org> wrote: > > On Sun, Aug 25, 2019 at 03:51:42PM +0200, Jacopo Mondi wrote: > > > Document the newly added 'cmms' property which accepts a list of phandle > > > and channel index pairs that point to the CMM units available for each > > > Display Unit output video channel. > > > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > > Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > > > index c97dfacad281..c2265e2a1af2 100644 > > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > > @@ -45,6 +45,10 @@ Required Properties: > > > instance that serves the DU channel, and the channel index identifies the > > > LIF instance in that VSP. > > > > > > + - cmms: A list of phandles to the CMM instances present in the SoC, one > > > + for each available DU channel. The property shall not be specified for > > > + SoCs that do not provide any CMM (such as V3M and V3H). > > > > renesas,cmms > > So I guess we really wanted to have the prefix for the vsps property, too? Yes, we should have :-( My bad.
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt index c97dfacad281..c2265e2a1af2 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.txt +++ b/Documentation/devicetree/bindings/display/renesas,du.txt @@ -45,6 +45,10 @@ Required Properties: instance that serves the DU channel, and the channel index identifies the LIF instance in that VSP. + - cmms: A list of phandles to the CMM instances present in the SoC, one + for each available DU channel. The property shall not be specified for + SoCs that do not provide any CMM (such as V3M and V3H). + Required nodes: The connections to the DU output video ports are modeled using the OF graph @@ -91,6 +95,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU <&cpg CPG_MOD 721>; clock-names = "du.0", "du.1", "du.2", "du.3"; vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; + cmms = <&cmm0 &cmm1 &cmm2 &cmm3>; ports { #address-cells = <1>;