| Message ID | 20190822085553.62697-1-mika.westerberg@linux.intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [1/2] PCI: Make pcie_downstream_port() available outside of access.c | expand |
On Thu, Aug 22, 2019 at 11:55:52AM +0300, Mika Westerberg wrote: > This helper function is useful in other places where code needs to > determine whether the PCIe port is downstream so make it available > outside of access.c. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/pci/access.c | 9 --------- > drivers/pci/pci.h | 9 +++++++++ > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/pci/access.c b/drivers/pci/access.c > index 544922f097c0..2fccb5762c76 100644 > --- a/drivers/pci/access.c > +++ b/drivers/pci/access.c > @@ -336,15 +336,6 @@ static inline int pcie_cap_version(const struct pci_dev *dev) > return pcie_caps_reg(dev) & PCI_EXP_FLAGS_VERS; > } > > -static bool pcie_downstream_port(const struct pci_dev *dev) > -{ > - int type = pci_pcie_type(dev); > - > - return type == PCI_EXP_TYPE_ROOT_PORT || > - type == PCI_EXP_TYPE_DOWNSTREAM || > - type == PCI_EXP_TYPE_PCIE_BRIDGE; > -} > - > bool pcie_cap_has_lnkctl(const struct pci_dev *dev) > { > int type = pci_pcie_type(dev); > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h > index 9a83fcf612ca..ae8d839dca4f 100644 > --- a/drivers/pci/pci.h > +++ b/drivers/pci/pci.h > @@ -118,6 +118,15 @@ static inline bool pci_power_manageable(struct pci_dev *pci_dev) > return !pci_has_subordinate(pci_dev) || pci_dev->bridge_d3; > } > > +static inline bool pcie_downstream_port(const struct pci_dev *dev) > +{ > + int type = pci_pcie_type(dev); > + > + return type == PCI_EXP_TYPE_ROOT_PORT || > + type == PCI_EXP_TYPE_DOWNSTREAM || > + type == PCI_EXP_TYPE_PCIE_BRIDGE; > +} > + > int pci_vpd_init(struct pci_dev *dev); > void pci_vpd_release(struct pci_dev *dev); > void pcie_vpd_create_sysfs_dev_files(struct pci_dev *dev); > -- > 2.23.0.rc1 >
diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 544922f097c0..2fccb5762c76 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -336,15 +336,6 @@ static inline int pcie_cap_version(const struct pci_dev *dev) return pcie_caps_reg(dev) & PCI_EXP_FLAGS_VERS; } -static bool pcie_downstream_port(const struct pci_dev *dev) -{ - int type = pci_pcie_type(dev); - - return type == PCI_EXP_TYPE_ROOT_PORT || - type == PCI_EXP_TYPE_DOWNSTREAM || - type == PCI_EXP_TYPE_PCIE_BRIDGE; -} - bool pcie_cap_has_lnkctl(const struct pci_dev *dev) { int type = pci_pcie_type(dev); diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 9a83fcf612ca..ae8d839dca4f 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -118,6 +118,15 @@ static inline bool pci_power_manageable(struct pci_dev *pci_dev) return !pci_has_subordinate(pci_dev) || pci_dev->bridge_d3; } +static inline bool pcie_downstream_port(const struct pci_dev *dev) +{ + int type = pci_pcie_type(dev); + + return type == PCI_EXP_TYPE_ROOT_PORT || + type == PCI_EXP_TYPE_DOWNSTREAM || + type == PCI_EXP_TYPE_PCIE_BRIDGE; +} + int pci_vpd_init(struct pci_dev *dev); void pci_vpd_release(struct pci_dev *dev); void pcie_vpd_create_sysfs_dev_files(struct pci_dev *dev);
This helper function is useful in other places where code needs to determine whether the PCIe port is downstream so make it available outside of access.c. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/pci/access.c | 9 --------- drivers/pci/pci.h | 9 +++++++++ 2 files changed, 9 insertions(+), 9 deletions(-)