| Message ID | 20190813150827.31972-8-s.nawrocki@samsung.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Exynos Adaptive Supply Voltage support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, 13 Aug 2019 at 17:09, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > > This patch adds documentation of a new optional "samsung,asv-bin" > property in the chipid device node and documents requirement of > "syscon" compatible string. These additions are needed to support > Exynos ASV (Adaptive Supply Voltage) feature. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v2: > - none > > Changes since v1 (RFC): > - new patch > --- > .../devicetree/bindings/arm/samsung/exynos-chipid.txt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt > index 85c5dfd4a720..be3657e6c00c 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt > @@ -1,12 +1,18 @@ > -SAMSUNG Exynos SoCs Chipid driver. > +SAMSUNG Exynos SoC series CHIPID subsystem > > Required properties: > -- compatible : Should at least contain "samsung,exynos4210-chipid". > +- compatible : Should at least contain "samsung,exynos4210-chipid", "syscon". > > - reg: offset and length of the register set > > +Optional properties: > + - samsung,asv-bin : Adaptive Supply Voltage bin selection. This can be used > + to determine the ASV bin of an SoC if respective information is missing > + in the CHIPID registers or in the OTP memory. Possible values: 0...3. > + > Example: > chipid@10000000 { > compatible = "samsung,exynos4210-chipid"; Please update the example with new required compatible. Best regards, Krzysztof > reg = <0x10000000 0x100>; > + samsung,asv-bin = <2>; > }; > -- > 2.17.1 >
On Tue, Aug 13, 2019 at 05:08:25PM +0200, Sylwester Nawrocki wrote: > This patch adds documentation of a new optional "samsung,asv-bin" > property in the chipid device node and documents requirement of > "syscon" compatible string. These additions are needed to support > Exynos ASV (Adaptive Supply Voltage) feature. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v2: > - none > > Changes since v1 (RFC): Title should match bindings, so: dt-bindings: samsung: Also please put it before the driver change using these bindings. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt index 85c5dfd4a720..be3657e6c00c 100644 --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt @@ -1,12 +1,18 @@ -SAMSUNG Exynos SoCs Chipid driver. +SAMSUNG Exynos SoC series CHIPID subsystem Required properties: -- compatible : Should at least contain "samsung,exynos4210-chipid". +- compatible : Should at least contain "samsung,exynos4210-chipid", "syscon". - reg: offset and length of the register set +Optional properties: + - samsung,asv-bin : Adaptive Supply Voltage bin selection. This can be used + to determine the ASV bin of an SoC if respective information is missing + in the CHIPID registers or in the OTP memory. Possible values: 0...3. + Example: chipid@10000000 { compatible = "samsung,exynos4210-chipid"; reg = <0x10000000 0x100>; + samsung,asv-bin = <2>; };
This patch adds documentation of a new optional "samsung,asv-bin" property in the chipid device node and documents requirement of "syscon" compatible string. These additions are needed to support Exynos ASV (Adaptive Supply Voltage) feature. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v2: - none Changes since v1 (RFC): - new patch --- .../devicetree/bindings/arm/samsung/exynos-chipid.txt | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)