| Message ID | 20190724081313.12934-4-andrew@aj.id.au |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | ARM: dts: aspeed: Deprecate g[45]-style compatibles | expand |
On Wed, Jul 24, 2019 at 2:13 AM Andrew Jeffery <andrew@aj.id.au> wrote: > > Guide readers away from using the aspeed,g[45].* compatible patterns. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > --- > Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 2 -- > Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt | 2 -- > .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 5 +---- > .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 4 +--- > 4 files changed, 2 insertions(+), 11 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Jul 24, 2019 at 10:13 AM Andrew Jeffery <andrew@aj.id.au> wrote: > Guide readers away from using the aspeed,g[45].* compatible patterns. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Patch applied to the pinctrl tree. Yours, Linus Walleij
On Mon, 05 Aug 2019, Linus Walleij wrote: > On Wed, Jul 24, 2019 at 10:13 AM Andrew Jeffery <andrew@aj.id.au> wrote: > > > Guide readers away from using the aspeed,g[45].* compatible patterns. > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > Patch applied to the pinctrl tree. With my Ack?
On Mon, Aug 12, 2019 at 12:15 PM Lee Jones <lee.jones@linaro.org> wrote: > On Mon, 05 Aug 2019, Linus Walleij wrote: > > > On Wed, Jul 24, 2019 at 10:13 AM Andrew Jeffery <andrew@aj.id.au> wrote: > > > > > Guide readers away from using the aspeed,g[45].* compatible patterns. > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > Patch applied to the pinctrl tree. > > With my Ack? Sorry no. :( Was I too trigger-happy? Usually I take Rob's ACK as authoritative for anything under Documentation/devicetree but if you have concerns about the patch from an MFD point of view I will revert it pending further discussion. Yours, Linus Walleij
On Wed, 14 Aug 2019, Linus Walleij wrote: > On Mon, Aug 12, 2019 at 12:15 PM Lee Jones <lee.jones@linaro.org> wrote: > > On Mon, 05 Aug 2019, Linus Walleij wrote: > > > > > On Wed, Jul 24, 2019 at 10:13 AM Andrew Jeffery <andrew@aj.id.au> wrote: > > > > > > > Guide readers away from using the aspeed,g[45].* compatible patterns. > > > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > > > Patch applied to the pinctrl tree. > > > > With my Ack? > > Sorry no. :( Was I too trigger-happy? > > Usually I take Rob's ACK as authoritative for anything under > Documentation/devicetree but if you have concerns about the > patch from an MFD point of view I will revert it pending further > discussion. No need. I would have Acked it.
diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt index ce8cf0ec6279..4d92c0bb6687 100644 --- a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt @@ -4,9 +4,7 @@ configuring elements such as clocks, pinmux, and reset. Required properties: - compatible: One of: "aspeed,ast2400-scu", "syscon", "simple-mfd" - "aspeed,g4-scu", "syscon", "simple-mfd" "aspeed,ast2500-scu", "syscon", "simple-mfd" - "aspeed,g5-scu", "syscon", "simple-mfd" - reg: contains the offset and length of the SCU memory region - #clock-cells: should be set to <1> - the system controller is also a diff --git a/Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt b/Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt index 854bd67ffec6..0e1fa5bc6a30 100644 --- a/Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt +++ b/Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt @@ -26,9 +26,7 @@ property: - compatible : Should be one of the following: "aspeed,ast2400-scu", "syscon", "simple-mfd" - "aspeed,g4-scu", "syscon", "simple-mfd" "aspeed,ast2500-scu", "syscon", "simple-mfd" - "aspeed,g5-scu", "syscon", "simple-mfd" Example =================== diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml index 125599a2dc5e..9368e4b6d4d0 100644 --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml @@ -15,16 +15,13 @@ description: |+ - compatible: Should be one of the following: "aspeed,ast2400-scu", "syscon", "simple-mfd" - "aspeed,g4-scu", "syscon", "simple-mfd" Refer to the the bindings described in Documentation/devicetree/bindings/mfd/syscon.txt properties: compatible: - enum: - - aspeed,ast2400-pinctrl - - aspeed,g4-pinctrl + const: aspeed,ast2400-pinctrl patternProperties: '^.*$': diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml index 3e6d85318577..939fb755a6db 100644 --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml @@ -22,9 +22,7 @@ description: |+ properties: compatible: - enum: - - aspeed,ast2500-pinctrl - - aspeed,g5-pinctrl + const: aspeed,ast2500-pinctrl aspeed,external-nodes: minItems: 2 maxItems: 2
Guide readers away from using the aspeed,g[45].* compatible patterns. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 2 -- Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt | 2 -- .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 5 +---- .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 4 +--- 4 files changed, 2 insertions(+), 11 deletions(-)