diff mbox

genrtc: disable genrtc on Blackfin systems

Message ID 1226991615-30268-1-git-send-email-cooloney@kernel.org
State Accepted, archived
Headers show

Commit Message

Bryan Wu Nov. 18, 2008, 7 a.m. UTC 
From: Mike Frysinger <vapier.adi@gmail.com>

Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
 drivers/char/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Alessandro Zummo Nov. 18, 2008, 10:33 a.m. UTC | #1 
On Tue, 18 Nov 2008 15:00:15 +0800
Bryan Wu <cooloney@kernel.org> wrote:

> From: Mike Frysinger <vapier.adi@gmail.com>
> 
> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>

 Another kill, great! :)
 
 Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
Andrew Morton Nov. 19, 2008, 6:26 a.m. UTC | #2 
On Tue, 18 Nov 2008 15:00:15 +0800 Bryan Wu <cooloney@kernel.org> wrote:

> From: Mike Frysinger <vapier.adi@gmail.com>
> 
> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>

What is the reason for this change?

> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 43d6ba8..a92a60a 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -814,7 +814,7 @@ config JS_RTC
>  
>  config GEN_RTC
>  	tristate "Generic /dev/rtc emulation"
> -	depends on RTC!=y && !IA64 && !ARM && !M32R && !MIPS && !SPARC && !FRV && !S390 && !SUPERH && !AVR32
> +	depends on RTC!=y && !IA64 && !ARM && !M32R && !MIPS && !SPARC && !FRV && !S390 && !SUPERH && !AVR32 && !BLACKFIN

Gawd that's stupid.  It'd be much better to add a new
CONFIG_ARCH_SUPPORTS_GENRTC in arch/*/Kconfig.

Oh well.  I suppose we can run with this patch for now.  Once we know
what it's for.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
Mike Frysinger Nov. 19, 2008, 1:38 p.m. UTC | #3 
On Wed, Nov 19, 2008 at 01:26, Andrew Morton wrote:
> On Tue, 18 Nov 2008 15:00:15 +0800 Bryan Wu wrote:
>
>> From: Mike Frysinger <vapier.adi@gmail.com>
>>
>> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>
> What is the reason for this change?

if it doesnt work on a platform, then it shouldnt be available.  the
arch list kind of implies that this is like x86 specific anyways ...
-mike

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
diff mbox

Patch

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 43d6ba8..a92a60a 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -814,7 +814,7 @@  config JS_RTC
 
 config GEN_RTC
 	tristate "Generic /dev/rtc emulation"
-	depends on RTC!=y && !IA64 && !ARM && !M32R && !MIPS && !SPARC && !FRV && !S390 && !SUPERH && !AVR32
+	depends on RTC!=y && !IA64 && !ARM && !M32R && !MIPS && !SPARC && !FRV && !S390 && !SUPERH && !AVR32 && !BLACKFIN
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you