| Message ID | 20190809123031.24219-4-paul@crapouillou.net |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | pwm: jz4740: Driver update | expand |
On Fri, Aug 09, 2019 at 02:30:27PM +0200, Paul Cercueil wrote: > Depending on MACH_INGENIC prevent us from creating a generic kernel that > works on more than one MIPS board. Instead, we just depend on MIPS being > set. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/pwm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index d2557c6fcf65..82a75e0b72e5 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -224,7 +224,7 @@ config PWM_IMX_TPM > > config PWM_JZ4740 > tristate "Ingenic JZ47xx PWM support" > - depends on MACH_INGENIC > + depends on MIPS If this isn't actually useful on MIPS without MACH_INGENIC this is better expressed using: depends on MIPS depends on MACH_INGENIC || COMPILE_TEST This way some configuring a mips kernel without INGENIC isn't bothered by this question. Best regards Uwe
Le ven. 9 août 2019 à 18:41, Uwe =?iso-8859-1?q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de> a écrit : > On Fri, Aug 09, 2019 at 02:30:27PM +0200, Paul Cercueil wrote: >> Depending on MACH_INGENIC prevent us from creating a generic kernel >> that >> works on more than one MIPS board. Instead, we just depend on MIPS >> being >> set. >> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net> >> --- >> drivers/pwm/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig >> index d2557c6fcf65..82a75e0b72e5 100644 >> --- a/drivers/pwm/Kconfig >> +++ b/drivers/pwm/Kconfig >> @@ -224,7 +224,7 @@ config PWM_IMX_TPM >> >> config PWM_JZ4740 >> tristate "Ingenic JZ47xx PWM support" >> - depends on MACH_INGENIC >> + depends on MIPS > > If this isn't actually useful on MIPS without MACH_INGENIC this is > better expressed using: > > depends on MIPS > depends on MACH_INGENIC || COMPILE_TEST > > This way some configuring a mips kernel without INGENIC isn't bothered > by this question. As said in the commit message, it is useful on MIPS without MACH_INGENIC, if you want to create a generic kernel that works on more than one MIPS board. > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König > | > Industrial Linux Solutions | > http://www.pengutronix.de/ |
On Fri, Aug 09, 2019 at 11:40:59PM +0200, Paul Cercueil wrote: > > > Le ven. 9 août 2019 à 18:41, Uwe =?iso-8859-1?q?Kleine-K=F6nig?= > <u.kleine-koenig@pengutronix.de> a écrit : > > On Fri, Aug 09, 2019 at 02:30:27PM +0200, Paul Cercueil wrote: > > > Depending on MACH_INGENIC prevent us from creating a generic kernel > > > that > > > works on more than one MIPS board. Instead, we just depend on MIPS > > > being > > > set. > > > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > > --- > > > drivers/pwm/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > > > index d2557c6fcf65..82a75e0b72e5 100644 > > > --- a/drivers/pwm/Kconfig > > > +++ b/drivers/pwm/Kconfig > > > @@ -224,7 +224,7 @@ config PWM_IMX_TPM > > > > > > config PWM_JZ4740 > > > tristate "Ingenic JZ47xx PWM support" > > > - depends on MACH_INGENIC > > > + depends on MIPS > > > > If this isn't actually useful on MIPS without MACH_INGENIC this is > > better expressed using: > > > > depends on MIPS > > depends on MACH_INGENIC || COMPILE_TEST > > > > This way some configuring a mips kernel without INGENIC isn't bothered > > by this question. > > As said in the commit message, it is useful on MIPS without MACH_INGENIC, > if you want to create a generic kernel that works on more than one MIPS > board. Ah, mips is different than arm here. If you configure a generic kernel that supports arm/imx and some others the Kconfig settings for imx are still available. Would it make more sense to do: depends on MACH_INGENIC || MIPS_GENERIC || COMPILE_TEST then? Or switch mips to the (IMHO) more intuitive approach that is taken by arm, too? (i.e. ensure that MACH_INGENIC is =y for both a generic kernel that supports this machine type among others and a tailored kernel that only supports Ingenic.) Best regards Uwe
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index d2557c6fcf65..82a75e0b72e5 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -224,7 +224,7 @@ config PWM_IMX_TPM config PWM_JZ4740 tristate "Ingenic JZ47xx PWM support" - depends on MACH_INGENIC + depends on MIPS depends on COMMON_CLK select MFD_SYSCON help
Depending on MACH_INGENIC prevent us from creating a generic kernel that works on more than one MIPS board. Instead, we just depend on MIPS being set. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/pwm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)