| Message ID | 20190808141818.22724-1-anders.roxell@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | of/platform: fix compilation warning of of_link_property() | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 8 lines checked" |
On 8/8/19 7:18 AM, Anders Roxell wrote: > GCC warns that a negative integer can be returned but the > of_link_property() function should return a boolean. > > ../drivers/of/platform.c: In function ‘of_link_property’: > ../drivers/of/platform.c:650:18: warning: ?: using integer constants in boolean context [-Wint-in-bool-context] > return done ? 0 : -ENODEV; > > Rework so function of_link_property() return an integer instead of a boolean. > > Fixes: 690ff7881b26 ("of/platform: Add functional dependency link from DT bindings") > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > drivers/of/platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index 21838226d68a..86fb8ab8c012 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -625,7 +625,7 @@ static const struct supplier_bindings bindings[] = { > { }, > }; > > -static bool of_link_property(struct device *dev, struct device_node *con_np, > +static int of_link_property(struct device *dev, struct device_node *con_np, > const char *prop) > { > struct device_node *phandle; > Hi Anders, Thanks for catching this. Another patch was submitted to fix this just before your patch. -Frank
diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 21838226d68a..86fb8ab8c012 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -625,7 +625,7 @@ static const struct supplier_bindings bindings[] = { { }, }; -static bool of_link_property(struct device *dev, struct device_node *con_np, +static int of_link_property(struct device *dev, struct device_node *con_np, const char *prop) { struct device_node *phandle;
GCC warns that a negative integer can be returned but the of_link_property() function should return a boolean. ../drivers/of/platform.c: In function ‘of_link_property’: ../drivers/of/platform.c:650:18: warning: ?: using integer constants in boolean context [-Wint-in-bool-context] return done ? 0 : -ENODEV; Rework so function of_link_property() return an integer instead of a boolean. Fixes: 690ff7881b26 ("of/platform: Add functional dependency link from DT bindings") Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- drivers/of/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)