| Message ID | 20190805103518.8233-1-alexandre.payen@smile.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/lapack: avoid selecting lapack and clapack | expand |
Hi Alexandre, Le 05/08/2019 à 12:35, Aalx a écrit : > From: Alexandre PAYEN <alexandre.payen@smile.fr> > > lapack and clapack generate the same libraries liblapack.so and > libblas.so. So those two packages can't be selected at the same time. > > This is a temporary fix waiting for a solution[2]. > > So: > - add !BR2_PACKAGE_CLAPACK to lapack/Config.in. > > [1]: http://autobuild.buildroot.org/results/375/375078ed8f965ecf92eb9674bd071a518c3ef894// > [2]: http://lists.busybox.net/pipermail/buildroot/2019-August/255894.html > > Signed-off-by: Alexandre PAYEN <alexandre.payen@smile.fr> > Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Romain Naour <romain.naour@smile.fr> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > --- > package/lapack/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/lapack/Config.in b/package/lapack/Config.in > index 9687ace82d..6cd0810cb1 100644 > --- a/package/lapack/Config.in > +++ b/package/lapack/Config.in > @@ -5,6 +5,7 @@ comment "lapack/blas needs a toolchain w/ fortran" > config BR2_PACKAGE_LAPACK > bool "lapack/blas" > depends on BR2_TOOLCHAIN_HAS_FORTRAN > + depends on !BR2_PACKAGE_CLAPACK Introducing a virtual packages requires some work in Buildroot especially since openblas can be a lapack provider. Since we are going to tag -rc1, maybe this short term solution is good enough. Reviewed-by: Romain Naour <romain.naour@smile.fr> Best regards, Romain > # _fpu_control is used on PowerPC, but not available with uClibc > depends on !(BR2_powerpc && BR2_TOOLCHAIN_USES_UCLIBC) > help >
On 05/08/2019 12:35, Aalx wrote: > From: Alexandre PAYEN <alexandre.payen@smile.fr> > > lapack and clapack generate the same libraries liblapack.so and > libblas.so. So those two packages can't be selected at the same time. > > This is a temporary fix waiting for a solution[2]. > > So: > - add !BR2_PACKAGE_CLAPACK to lapack/Config.in. > > [1]: http://autobuild.buildroot.org/results/375/375078ed8f965ecf92eb9674bd071a518c3ef894// > [2]: http://lists.busybox.net/pipermail/buildroot/2019-August/255894.html > > Signed-off-by: Alexandre PAYEN <alexandre.payen@smile.fr> > Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Romain Naour <romain.naour@smile.fr> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> Applied to master, thanks. Regards, Arnout > --- > package/lapack/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/lapack/Config.in b/package/lapack/Config.in > index 9687ace82d..6cd0810cb1 100644 > --- a/package/lapack/Config.in > +++ b/package/lapack/Config.in > @@ -5,6 +5,7 @@ comment "lapack/blas needs a toolchain w/ fortran" > config BR2_PACKAGE_LAPACK > bool "lapack/blas" > depends on BR2_TOOLCHAIN_HAS_FORTRAN > + depends on !BR2_PACKAGE_CLAPACK > # _fpu_control is used on PowerPC, but not available with uClibc > depends on !(BR2_powerpc && BR2_TOOLCHAIN_USES_UCLIBC) > help >
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: > On 05/08/2019 12:35, Aalx wrote: >> From: Alexandre PAYEN <alexandre.payen@smile.fr> >> >> lapack and clapack generate the same libraries liblapack.so and >> libblas.so. So those two packages can't be selected at the same time. >> >> This is a temporary fix waiting for a solution[2]. >> >> So: >> - add !BR2_PACKAGE_CLAPACK to lapack/Config.in. >> >> [1]: http://autobuild.buildroot.org/results/375/375078ed8f965ecf92eb9674bd071a518c3ef894// >> [2]: http://lists.busybox.net/pipermail/buildroot/2019-August/255894.html >> >> Signed-off-by: Alexandre PAYEN <alexandre.payen@smile.fr> >> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> >> Cc: Romain Naour <romain.naour@smile.fr> >> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> Committed to 2019.02.x and 2019.11.x, thanks.
diff --git a/package/lapack/Config.in b/package/lapack/Config.in index 9687ace82d..6cd0810cb1 100644 --- a/package/lapack/Config.in +++ b/package/lapack/Config.in @@ -5,6 +5,7 @@ comment "lapack/blas needs a toolchain w/ fortran" config BR2_PACKAGE_LAPACK bool "lapack/blas" depends on BR2_TOOLCHAIN_HAS_FORTRAN + depends on !BR2_PACKAGE_CLAPACK # _fpu_control is used on PowerPC, but not available with uClibc depends on !(BR2_powerpc && BR2_TOOLCHAIN_USES_UCLIBC) help