| Message ID | 20190717191215.61153-1-alex_y_xu@yahoo.ca |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] package/python-idna: select PYTHON3_UNICODEDATA | expand |
Hello Alex, Thanks for the new iteration of the patch. There was still an issue, but see below. On Wed, 17 Jul 2019 15:12:15 -0400 "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote: > diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in > index 1fd56ceaf6..ddc2cd7d17 100644 > --- a/package/python-idna/Config.in > +++ b/package/python-idna/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_PYTHON_IDNA > bool "python-idna" > + select BR2_PACKAGE_PYTHON3_UNICODEDATA This only takes care of the case where python3 is used, by python-idna can also be used when python (2.x) is selected. So I changed this to: + select BR2_PACKAGE_PYTHON_UNICODEDATA if BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON3_UNICODEDATA if BR2_PACKAGE_PYTHON3 and applied. Thanks! Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes: > Hello Alex, > Thanks for the new iteration of the patch. There was still an issue, > but see below. > On Wed, 17 Jul 2019 15:12:15 -0400 > "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote: >> diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in >> index 1fd56ceaf6..ddc2cd7d17 100644 >> --- a/package/python-idna/Config.in >> +++ b/package/python-idna/Config.in >> @@ -1,5 +1,6 @@ >> config BR2_PACKAGE_PYTHON_IDNA >> bool "python-idna" >> + select BR2_PACKAGE_PYTHON3_UNICODEDATA > This only takes care of the case where python3 is used, by python-idna > can also be used when python (2.x) is selected. > So I changed this to: > + select BR2_PACKAGE_PYTHON_UNICODEDATA if BR2_PACKAGE_PYTHON > + select BR2_PACKAGE_PYTHON3_UNICODEDATA if BR2_PACKAGE_PYTHON3 > and applied. Committed to 2019.02.x and 2019.05.x with the same fixes, thanks.
diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in index 1fd56ceaf6..ddc2cd7d17 100644 --- a/package/python-idna/Config.in +++ b/package/python-idna/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_PYTHON_IDNA bool "python-idna" + select BR2_PACKAGE_PYTHON3_UNICODEDATA help A library to support the Internationalised Domain Names in Applications (IDNA) protocol as specified in RFC 5891. This
idna requires unicodedata: Traceback (most recent call last): File "<stdin>", line 1, in <module> File "usr/lib/python3.7/site-packages/idna/__init__.py", line 2, in <module> File "usr/lib/python3.7/site-packages/idna/core.py", line 3, in <module> ModuleNotFoundError: No module named 'unicodedata' Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> --- package/python-idna/Config.in | 1 + 1 file changed, 1 insertion(+)