| Message ID | 20190730181557.90391-37-swboyd@chromium.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | None | expand |
On Tue, Jul 30, 2019 at 11:15:36AM -0700, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. Looking at v5.3-rc2 it's not obvious to me that all error paths of platform_get_irq issue an error message. Do I miss something? Best regards Uwe
On Wed, Jul 31, 2019 at 08:58:53AM +0200, Uwe Kleine-König wrote: > On Tue, Jul 30, 2019 at 11:15:36AM -0700, Stephen Boyd wrote: > > We don't need dev_err() messages when platform_get_irq() fails now that > > platform_get_irq() prints an error message itself when something goes > > wrong. Let's remove these prints with a simple semantic patch. > > Looking at v5.3-rc2 it's not obvious to me that all error paths of > platform_get_irq issue an error message. Do I miss something? The commit is in my driver-core tree at the moment, so this should wait until 5.4-rc1. I woudn't recommend merging it in 5.3-rc as it's not a bugfix. thanks, greg k-h
On Wed, Jul 31, 2019 at 09:13:01AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 31, 2019 at 08:58:53AM +0200, Uwe Kleine-König wrote: > > On Tue, Jul 30, 2019 at 11:15:36AM -0700, Stephen Boyd wrote: > > > We don't need dev_err() messages when platform_get_irq() fails now that > > > platform_get_irq() prints an error message itself when something goes > > > wrong. Let's remove these prints with a simple semantic patch. > > > > Looking at v5.3-rc2 it's not obvious to me that all error paths of > > platform_get_irq issue an error message. Do I miss something? > > The commit is in my driver-core tree at the moment, so this should wait > until 5.4-rc1. I woudn't recommend merging it in 5.3-rc as it's not a > bugfix. As this is a new change pointing out its id in the commit log of the follow up changes might be beneficial. Best regards Uwe
diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c index 20450e34ad57..1508616d794c 100644 --- a/drivers/pwm/pwm-sti.c +++ b/drivers/pwm/pwm-sti.c @@ -564,10 +564,8 @@ static int sti_pwm_probe(struct platform_device *pdev) return PTR_ERR(pc->regmap); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "Failed to obtain IRQ\n"); + if (irq < 0) return irq; - } ret = devm_request_irq(&pdev->dev, irq, sti_pwm_interrupt, 0, pdev->name, pc);
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Thierry Reding <thierry.reding@gmail.com> Cc: linux-pwm@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- Please apply directly to subsystem trees drivers/pwm/pwm-sti.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)