| Message ID | 1304943065-12023-1-git-send-email-kraxel@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 9 May 2011 14:11, Gerd Hoffmann <kraxel@redhat.com> wrote: > Here are the fixes. > > pleae pull, > Stefan Weil (1): > usb-linux: Add missing break statement The commit comment for this change looks like it still includes the remark: # Please check whether adding a break statement is the correct # solution for this warning. ...I think that should be removed since we have actually done the check during review, right? thanks -- PMM
On 05/09/11 14:50, Peter Maydell wrote: > On 9 May 2011 14:11, Gerd Hoffmann<kraxel@redhat.com> wrote: >> Here are the fixes. >> >> pleae pull, > >> Stefan Weil (1): >> usb-linux: Add missing break statement > > The commit comment for this change looks like it still > includes the remark: > > # Please check whether adding a break statement is the correct > # solution for this warning. Zapped, pushed usb.9.pull branch with the rewritten comment. cheers, Gerd
On 05/09/2011 09:25 AM, Gerd Hoffmann wrote: > On 05/09/11 14:50, Peter Maydell wrote: >> On 9 May 2011 14:11, Gerd Hoffmann<kraxel@redhat.com> wrote: >>> Here are the fixes. >>> >>> pleae pull, >> >>> Stefan Weil (1): >>> usb-linux: Add missing break statement >> >> The commit comment for this change looks like it still >> includes the remark: >> >> # Please check whether adding a break statement is the correct >> # solution for this warning. > > Zapped, pushed usb.9.pull branch with the rewritten comment.\ Pulled. Thanks. Regards, Anthony Liguori > > cheers, > Gerd > >
Hi, Two build issues slipped through with the last usb patch queue pull. Looks like I should do test builds with a more recent gcc ... Here are the fixes. pleae pull, Gerd The following changes since commit 85097db6956bc86e2377b63a8309cb8b24d54139: irq: Privatize CPU_INTERRUPT_NMI. (2011-05-08 16:55:24 +0000) are available in the git repository at: git://git.kraxel.org/qemu usb.8.pull Gerd Hoffmann (1): usb-musb: uninline functions Stefan Weil (1): usb-linux: Add missing break statement hw/usb-musb.c | 8 ++++---- usb-linux.c | 1 + 2 files changed, 5 insertions(+), 4 deletions(-)