Message ID | 20190709080015.43442-1-Anson.Huang@nxp.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [V2,1/4] dt-bindings: opp: Support multiple opp-suspend properties | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success |
On 09-07-19, 16:00, Anson.Huang@nxp.com wrote: > From: Anson Huang <Anson.Huang@nxp.com> > > Update opp-suspend property's description to support multiple > opp-suspend properties defined in DT, the OPP with highest opp-hz > and with opp-suspend property present will be used as suspend opp. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > New patch. > --- > Documentation/devicetree/bindings/opp/opp.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > index 76b6c79..6859227 100644 > --- a/Documentation/devicetree/bindings/opp/opp.txt > +++ b/Documentation/devicetree/bindings/opp/opp.txt > @@ -140,8 +140,8 @@ Optional properties: > frequency for a short duration of time limited by the device's power, current > and thermal limits. > > -- opp-suspend: Marks the OPP to be used during device suspend. Only one OPP in > - the table should have this. > +- opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs > + in the table have this, the OPP with highest opp-hz will be used. > > - opp-supported-hw: This enables us to select only a subset of OPPs from the > larger OPP table, based on what version of the hardware we are running on. We LGTM. Once Rob Acks it, I will apply the first two patches to the OPP tree.
On Tue, 9 Jul 2019 16:00:12 +0800, Anson.Huang@nxp.com wrote: > From: Anson Huang <Anson.Huang@nxp.com> > > Update opp-suspend property's description to support multiple > opp-suspend properties defined in DT, the OPP with highest opp-hz > and with opp-suspend property present will be used as suspend opp. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > New patch. > --- > Documentation/devicetree/bindings/opp/opp.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 09-07-19, 16:00, Anson.Huang@nxp.com wrote: > From: Anson Huang <Anson.Huang@nxp.com> > > Update opp-suspend property's description to support multiple > opp-suspend properties defined in DT, the OPP with highest opp-hz > and with opp-suspend property present will be used as suspend opp. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > New patch. > --- > Documentation/devicetree/bindings/opp/opp.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied. Thanks.
On 09-07-19, 16:00, Anson.Huang@nxp.com wrote: > From: Anson Huang <Anson.Huang@nxp.com> > > With property "opp-supported-hw" introduced, the OPP table > in DT could be a large OPP table and ONLY a subset of OPPs > are available, based on the version of the hardware running > on. That introduces restriction of using "opp-suspend" > property to define the suspend OPP, as we are NOT sure if the > OPP containing "opp-suspend" property is available for the > hardware running on, and the of opp core does NOT allow multiple > suspend OPPs defined in DT OPP table. > > To eliminate this restrition, make of opp core allow multiple > suspend OPPs defined in DT, and pick the OPP with highest rate > and with "opp-suspend" property present to be suspend OPP, it > can speed up the suspend/resume process. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > No changes. > --- > drivers/opp/of.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Applied. Thanks.
Hi, Shawn > On 09-07-19, 16:00, Anson.Huang@nxp.com wrote: > > From: Anson Huang <Anson.Huang@nxp.com> > > > > Update opp-suspend property's description to support multiple > > opp-suspend properties defined in DT, the OPP with highest opp-hz and > > with opp-suspend property present will be used as suspend opp. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > New patch. > > --- > > Documentation/devicetree/bindings/opp/opp.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Applied. Thanks. Would you pick up the DT patches in this series? Thanks. Anson
On Tue, Jul 09, 2019 at 04:00:14PM +0800, Anson.Huang@nxp.com wrote: > From: Anson Huang <Anson.Huang@nxp.com> > > Add opp-suspend property to each OPP, the of opp core will > select the OPP HW supported and with highest rate to be > suspend opp, it will speed up the suspend/resume process. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Applied, thanks.
On Tue, Jul 09, 2019 at 04:00:15PM +0800, Anson.Huang@nxp.com wrote: > From: Anson Huang <Anson.Huang@nxp.com> > > Add opp-suspend property to each OPP, the of opp core will > select the OPP HW supported and with highest rate to be > suspend opp, it will speed up the suspend/resume process. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Applied, thanks.
diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt index 76b6c79..6859227 100644 --- a/Documentation/devicetree/bindings/opp/opp.txt +++ b/Documentation/devicetree/bindings/opp/opp.txt @@ -140,8 +140,8 @@ Optional properties: frequency for a short duration of time limited by the device's power, current and thermal limits. -- opp-suspend: Marks the OPP to be used during device suspend. Only one OPP in - the table should have this. +- opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs + in the table have this, the OPP with highest opp-hz will be used. - opp-supported-hw: This enables us to select only a subset of OPPs from the larger OPP table, based on what version of the hardware we are running on. We