Message ID | CAPnjgZ2aHEbf+ZSRzd_PhO5FkTSvWT170Zu7AzVGdV4zuWLaeA@mail.gmail.com |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | [U-Boot] Please pull u-boot-dm (take 2) | expand |
On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > Hi Tom, > > This includes the gitlab fix and also I updated ifwitool.c to drop the > unused inline functions. > > > The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: > > Merge tag 'u-boot-stm32-20190723' of > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > 14:16:21 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > > for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > > dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > We're still not there yet, sorry. Taking a look at https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running things but ifwitool is failing. Can you please take a look? You will need the patch I posted that brings us up to a newer image that has lzma-alone. Thanks!
Hi Tom, On Wed, 24 Jul 2019 at 10:13, Tom Rini <trini@konsulko.com> wrote: > > On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > This includes the gitlab fix and also I updated ifwitool.c to drop the > > unused inline functions. > > > > > > The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: > > > > Merge tag 'u-boot-stm32-20190723' of > > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > > 14:16:21 -0400) > > > > are available in the Git repository at: > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > > > > for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > > > > dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > > > > We're still not there yet, sorry. Taking a look at > https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running > things but ifwitool is failing. Can you please take a look? You will > need the patch I posted that brings us up to a newer image that has > lzma-alone. Thanks! OK, this is another update that is needed to the gitlab config, this time the --toolpath argument. Will send an update. I was rather hoping that pushing to gitlab u-boot-dm would start a build but it does not, for me. I probably need to do some more reading. BTW Is there an intent to shut down travis? Regards, Simon
Am 24.07.2019 um 22:03 schrieb Simon Glass: > Hi Tom, > > On Wed, 24 Jul 2019 at 10:13, Tom Rini <trini@konsulko.com> wrote: >> >> On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: >> >>> Hi Tom, >>> >>> This includes the gitlab fix and also I updated ifwitool.c to drop the >>> unused inline functions. >>> >>> >>> The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: >>> >>> Merge tag 'u-boot-stm32-20190723' of >>> https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 >>> 14:16:21 -0400) >>> >>> are available in the Git repository at: >>> >>> git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 >>> >>> for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: >>> >>> dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) >>> >> >> We're still not there yet, sorry. Taking a look at >> https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running >> things but ifwitool is failing. Can you please take a look? You will >> need the patch I posted that brings us up to a newer image that has >> lzma-alone. Thanks! > > OK, this is another update that is needed to the gitlab config, this > time the --toolpath argument. Will send an update. > > I was rather hoping that pushing to gitlab u-boot-dm would start a > build but it does not, for me. I probably need to do some more > reading. > > BTW Is there an intent to shut down travis? Even if everyone seems to be switching to gitlab, can we keep the travis config in the repository? That makes it easy for people (like me) creating a github clone to ensure the world keeps building after a patch. Or is there a similar free and easy to use gitlab service comparable to travis? Regards, Simon
On Wed, Jul 24, 2019 at 01:03:20PM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 24 Jul 2019 at 10:13, Tom Rini <trini@konsulko.com> wrote: > > > > On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > > > > > Hi Tom, > > > > > > This includes the gitlab fix and also I updated ifwitool.c to drop the > > > unused inline functions. > > > > > > > > > The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: > > > > > > Merge tag 'u-boot-stm32-20190723' of > > > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > > > 14:16:21 -0400) > > > > > > are available in the Git repository at: > > > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > > > > > > for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > > > > > > dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > > > > > > > We're still not there yet, sorry. Taking a look at > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running > > things but ifwitool is failing. Can you please take a look? You will > > need the patch I posted that brings us up to a newer image that has > > lzma-alone. Thanks! > > OK, this is another update that is needed to the gitlab config, this > time the --toolpath argument. Will send an update. > > I was rather hoping that pushing to gitlab u-boot-dm would start a > build but it does not, for me. I probably need to do some more > reading. Take a look at the email I sent to the custodians list :) You'll need to flip a switch or two on the -dm tree for it to happen, and you can provide more build power for just your tree in addition to the shared runner we have currently. > BTW Is there an intent to shut down travis? As in remove the file? Not immediately, no, there's still the question of what to do about non-custodians being able to run CI before submitting.
On Wed, Jul 24, 2019 at 10:09:29PM +0200, Simon Goldschmidt wrote: > Am 24.07.2019 um 22:03 schrieb Simon Glass: > >Hi Tom, > > > >On Wed, 24 Jul 2019 at 10:13, Tom Rini <trini@konsulko.com> wrote: > >> > >>On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > >> > >>>Hi Tom, > >>> > >>>This includes the gitlab fix and also I updated ifwitool.c to drop the > >>>unused inline functions. > >>> > >>> > >>>The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: > >>> > >>> Merge tag 'u-boot-stm32-20190723' of > >>>https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > >>>14:16:21 -0400) > >>> > >>>are available in the Git repository at: > >>> > >>> git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > >>> > >>>for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > >>> > >>> dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > >>> > >> > >>We're still not there yet, sorry. Taking a look at > >>https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running > >>things but ifwitool is failing. Can you please take a look? You will > >>need the patch I posted that brings us up to a newer image that has > >>lzma-alone. Thanks! > > > >OK, this is another update that is needed to the gitlab config, this > >time the --toolpath argument. Will send an update. > > > >I was rather hoping that pushing to gitlab u-boot-dm would start a > >build but it does not, for me. I probably need to do some more > >reading. > > > >BTW Is there an intent to shut down travis? > > Even if everyone seems to be switching to gitlab, can we keep the travis > config in the repository? That makes it easy for people (like me) creating a > github clone to ensure the world keeps building after a patch. > > Or is there a similar free and easy to use gitlab service comparable to > travis? So that's the rub. There are free "runners" in GitLab terms for projects but they are limited in time to I think an hour per job, so we get back to the unmaintainable mess of splitting the build like we have on Travis. Anyone can use their own machine as the runner, but that may or may not be faster or even slower than Travis is.
On Wed, Jul 24, 2019 at 10:22 PM Tom Rini <trini@konsulko.com> wrote: > > On Wed, Jul 24, 2019 at 10:09:29PM +0200, Simon Goldschmidt wrote: > > Am 24.07.2019 um 22:03 schrieb Simon Glass: > > >Hi Tom, > > > > > >On Wed, 24 Jul 2019 at 10:13, Tom Rini <trini@konsulko.com> wrote: > > >> > > >>On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > > >> > > >>>Hi Tom, > > >>> > > >>>This includes the gitlab fix and also I updated ifwitool.c to drop the > > >>>unused inline functions. > > >>> > > >>> > > >>>The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: > > >>> > > >>> Merge tag 'u-boot-stm32-20190723' of > > >>>https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > > >>>14:16:21 -0400) > > >>> > > >>>are available in the Git repository at: > > >>> > > >>> git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > > >>> > > >>>for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > > >>> > > >>> dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > > >>> > > >> > > >>We're still not there yet, sorry. Taking a look at > > >>https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running > > >>things but ifwitool is failing. Can you please take a look? You will > > >>need the patch I posted that brings us up to a newer image that has > > >>lzma-alone. Thanks! > > > > > >OK, this is another update that is needed to the gitlab config, this > > >time the --toolpath argument. Will send an update. > > > > > >I was rather hoping that pushing to gitlab u-boot-dm would start a > > >build but it does not, for me. I probably need to do some more > > >reading. > > > > > >BTW Is there an intent to shut down travis? > > > > Even if everyone seems to be switching to gitlab, can we keep the travis > > config in the repository? That makes it easy for people (like me) creating a > > github clone to ensure the world keeps building after a patch. > > > > Or is there a similar free and easy to use gitlab service comparable to > > travis? > > So that's the rub. There are free "runners" in GitLab terms for > projects but they are limited in time to I think an hour per job, so we > get back to the unmaintainable mess of splitting the build like we have > on Travis. Anyone can use their own machine as the runner, but that may > or may not be faster or even slower than Travis is. I can assure you using my own PC is not an option for me compared to Travis. I don't know how many non-custodians there are using this (and I can probably arrange with Marek to use socfpga custodian access), but having a free-to-use CI seems worth much to me. I don't know how much effort it is to keep and maintain the Travis config files though... Regards, Simon > > -- > Tom