| Message ID | 1563504791-43398-1-git-send-email-xiaofeis@codeaurora.org |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | qca8k: enable port flow control | expand |
On 19-07-19, 10:53, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. How about: to Pause for enabling MAC flow control > > Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae Please remove this > Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org> > --- > drivers/net/dsa/qca8k.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > index d93be14..95ac081 100644 > --- a/drivers/net/dsa/qca8k.c > +++ b/drivers/net/dsa/qca8k.c > @@ -1,7 +1,7 @@ > /* > * Copyright (C) 2009 Felix Fietkau <nbd@nbd.name> > * Copyright (C) 2011-2012 Gabor Juhos <juhosg@openwrt.org> > - * Copyright (c) 2015, The Linux Foundation. All rights reserved. > + * Copyright (c) 2015, 2019, The Linux Foundation. All rights reserved. > * Copyright (c) 2016 John Crispin <john@phrozen.org> > * > * This program is free software; you can redistribute it and/or modify > @@ -800,6 +800,8 @@ > qca8k_port_set_status(priv, port, 1); > priv->port_sts[port].enabled = 1; > > + phy->advertising |= (ADVERTISED_Pause | ADVERTISED_Asym_Pause); > + > return 0; > } > > -- > 1.9.1
On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. > > Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae > Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org> > --- > drivers/net/dsa/qca8k.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > index d93be14..95ac081 100644 > --- a/drivers/net/dsa/qca8k.c > +++ b/drivers/net/dsa/qca8k.c > @@ -1,7 +1,7 @@ > /* > * Copyright (C) 2009 Felix Fietkau <nbd@nbd.name> > * Copyright (C) 2011-2012 Gabor Juhos <juhosg@openwrt.org> > - * Copyright (c) 2015, The Linux Foundation. All rights reserved. > + * Copyright (c) 2015, 2019, The Linux Foundation. All rights reserved. > * Copyright (c) 2016 John Crispin <john@phrozen.org> > * > * This program is free software; you can redistribute it and/or modify > @@ -800,6 +800,8 @@ > qca8k_port_set_status(priv, port, 1); > priv->port_sts[port].enabled = 1; > > + phy->advertising |= (ADVERTISED_Pause | ADVERTISED_Asym_Pause); Drop the unnecessary parentheses. Question for DSA maintainers: shouldn't this be implemented in the dsa_switch_ops phylink_validate callback, like it's done for other dsa drivers? Kind regards, Niklas > + > return 0; > } > > -- > 1.9.1 >
On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. > > Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae > Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org> Hi Xiaofei What tree is this patch against? I don't think it is net-next. It actually looks to be an old tree. Please rebase to David Millers net-next. Patches to that tree are closed at the moment, due to the merge window. You can post an RFC, or wait until it opens again. Thanks Andrew
> Question for DSA maintainers: shouldn't this be implemented in the > dsa_switch_ops phylink_validate callback, like it's done for other > dsa drivers? Hi Niklas qca8K is still using phylib, not phylink. So the validate callback cannot be used. Andrew
Hi Andrew Thanks for your comments. I have sent a new patch based on net-next tree. Thanks Xiaofeis On 2019-07-19 21:13, Andrew Lunn wrote: > On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: >> Set phy device advertising to enable MAC flow control. >> >> Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae >> Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org> > > Hi Xiaofei > > What tree is this patch against? I don't think it is net-next. It > actually looks to be an old tree. Please rebase to David Millers > net-next. Patches to that tree are closed at the moment, due to the > merge window. You can post an RFC, or wait until it opens again. > > Thanks > Andrew
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index d93be14..95ac081 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -1,7 +1,7 @@ /* * Copyright (C) 2009 Felix Fietkau <nbd@nbd.name> * Copyright (C) 2011-2012 Gabor Juhos <juhosg@openwrt.org> - * Copyright (c) 2015, The Linux Foundation. All rights reserved. + * Copyright (c) 2015, 2019, The Linux Foundation. All rights reserved. * Copyright (c) 2016 John Crispin <john@phrozen.org> * * This program is free software; you can redistribute it and/or modify @@ -800,6 +800,8 @@ qca8k_port_set_status(priv, port, 1); priv->port_sts[port].enabled = 1; + phy->advertising |= (ADVERTISED_Pause | ADVERTISED_Asym_Pause); + return 0; }
Set phy device advertising to enable MAC flow control. Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org> --- drivers/net/dsa/qca8k.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)