| Message ID | 20190707223303.6755-23-digetx@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | More improvements for Tegra30 devfreq driver | expand |
On 19. 7. 8. 오전 7:33, Dmitry Osipenko wrote: > It's not very correct to include mod_devicetable.h for the OF device > drivers and of_device.h should be included instead. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra30-devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 8a674fad26be..19e872a64148 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -13,7 +13,7 @@ > #include <linux/io.h> > #include <linux/irq.h> > #include <linux/module.h> > -#include <linux/mod_devicetable.h> > +#include <linux/of_device.h> > #include <linux/platform_device.h> > #include <linux/pm_opp.h> > #include <linux/reset.h> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Is not there other unused header file anymore?
В Thu, 18 Jul 2019 18:58:50 +0900 Chanwoo Choi <cw00.choi@samsung.com> пишет: > On 19. 7. 8. 오전 7:33, Dmitry Osipenko wrote: > > It's not very correct to include mod_devicetable.h for the OF device > > drivers and of_device.h should be included instead. > > > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > --- > > drivers/devfreq/tegra30-devfreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/tegra30-devfreq.c > > b/drivers/devfreq/tegra30-devfreq.c index > > 8a674fad26be..19e872a64148 100644 --- > > a/drivers/devfreq/tegra30-devfreq.c +++ > > b/drivers/devfreq/tegra30-devfreq.c @@ -13,7 +13,7 @@ > > #include <linux/io.h> > > #include <linux/irq.h> > > #include <linux/module.h> > > -#include <linux/mod_devicetable.h> > > +#include <linux/of_device.h> > > #include <linux/platform_device.h> > > #include <linux/pm_opp.h> > > #include <linux/reset.h> > > > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > Is not there other unused header file anymore? > The rest looks good to me.
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 8a674fad26be..19e872a64148 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -13,7 +13,7 @@ #include <linux/io.h> #include <linux/irq.h> #include <linux/module.h> -#include <linux/mod_devicetable.h> +#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_opp.h> #include <linux/reset.h>
It's not very correct to include mod_devicetable.h for the OF device drivers and of_device.h should be included instead. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra30-devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)