| Message ID | 20190713044554.28719-2-bauerman@linux.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Remove x86-specific code from generic headers | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | warning | Failed to apply on branch next (f5c20693d8edcd665f1159dc941b9e7f87c17647) |
| snowpatch_ozlabs/apply_patch | fail | Failed to apply to any branch |
On Sat, Jul 13, 2019 at 01:45:52AM -0300, Thiago Jung Bauermann wrote: > powerpc is also going to use this feature, so put it in a generic location. Looks good, even without a third arch using it we should never habe symbols defined under arch/$(ARCH) that are used in common code to start with. Reviewed-by: Christoph Hellwig <hch@lst.de>
On 2019-07-12 23:45, Thiago Jung Bauermann wrote: > powerpc is also going to use this feature, so put it in a generic > location. > > Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com> > Reviewed-by: Thomas Gleixner <tglx@linutronix.de> > --- > arch/Kconfig | 3 +++ > arch/s390/Kconfig | 3 --- > arch/x86/Kconfig | 4 +--- > 3 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index c47b328eada0..4ef3499d4480 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -927,6 +927,9 @@ config LOCK_EVENT_COUNTS > the chance of application behavior change because of timing > differences. The counts are reported via debugfs. > > +config ARCH_HAS_MEM_ENCRYPT > + bool > + > source "kernel/gcov/Kconfig" > > source "scripts/gcc-plugins/Kconfig" > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index 5d8570ed6cab..f820e631bf89 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -1,7 +1,4 @@ > # SPDX-License-Identifier: GPL-2.0 > -config ARCH_HAS_MEM_ENCRYPT > - def_bool y > - Since you are removing the "def_bool y" when ARCH_HAS_MEM_ENCRYPT is moved to arch/Kconfig, does the s390/Kconfig need "select ARCH_HAS_MEM_ENCRYPT" added like you do for x86/Kconfig? - Janani > config MMU > def_bool y > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index c9f331bb538b..5d3295f2df94 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -68,6 +68,7 @@ config X86 > select ARCH_HAS_FORTIFY_SOURCE > select ARCH_HAS_GCOV_PROFILE_ALL > select ARCH_HAS_KCOV if X86_64 > + select ARCH_HAS_MEM_ENCRYPT > select ARCH_HAS_MEMBARRIER_SYNC_CORE > select ARCH_HAS_PMEM_API if X86_64 > select ARCH_HAS_PTE_SPECIAL > @@ -1520,9 +1521,6 @@ config X86_CPA_STATISTICS > helps to determine the effectiveness of preserving large and huge > page mappings when mapping protections are changed. > > -config ARCH_HAS_MEM_ENCRYPT > - def_bool y > - > config AMD_MEM_ENCRYPT > bool "AMD Secure Memory Encryption (SME) support" > depends on X86_64 && CPU_SUP_AMD
Hello Janani, Thanks for reviewing the patch. janani <janani@linux.ibm.com> writes: > On 2019-07-12 23:45, Thiago Jung Bauermann wrote: >> powerpc is also going to use this feature, so put it in a generic location. >> >> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com> >> Reviewed-by: Thomas Gleixner <tglx@linutronix.de> >> --- >> arch/Kconfig | 3 +++ >> arch/s390/Kconfig | 3 --- >> arch/x86/Kconfig | 4 +--- >> 3 files changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/arch/Kconfig b/arch/Kconfig >> index c47b328eada0..4ef3499d4480 100644 >> --- a/arch/Kconfig >> +++ b/arch/Kconfig >> @@ -927,6 +927,9 @@ config LOCK_EVENT_COUNTS >> the chance of application behavior change because of timing >> differences. The counts are reported via debugfs. >> >> +config ARCH_HAS_MEM_ENCRYPT >> + bool >> + >> source "kernel/gcov/Kconfig" >> >> source "scripts/gcc-plugins/Kconfig" >> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig >> index 5d8570ed6cab..f820e631bf89 100644 >> --- a/arch/s390/Kconfig >> +++ b/arch/s390/Kconfig >> @@ -1,7 +1,4 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -config ARCH_HAS_MEM_ENCRYPT >> - def_bool y >> - > > Since you are removing the "def_bool y" when ARCH_HAS_MEM_ENCRYPT is moved to > arch/Kconfig, does the s390/Kconfig need "select ARCH_HAS_MEM_ENCRYPT" added > like you do for x86/Kconfig? Indeed, I missed that. Thanks for spotting it! > > - Janani > >> config MMU >> def_bool y >> >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index c9f331bb538b..5d3295f2df94 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -68,6 +68,7 @@ config X86 >> select ARCH_HAS_FORTIFY_SOURCE >> select ARCH_HAS_GCOV_PROFILE_ALL >> select ARCH_HAS_KCOV if X86_64 >> + select ARCH_HAS_MEM_ENCRYPT >> select ARCH_HAS_MEMBARRIER_SYNC_CORE >> select ARCH_HAS_PMEM_API if X86_64 >> select ARCH_HAS_PTE_SPECIAL >> @@ -1520,9 +1521,6 @@ config X86_CPA_STATISTICS >> helps to determine the effectiveness of preserving large and huge >> page mappings when mapping protections are changed. >> >> -config ARCH_HAS_MEM_ENCRYPT >> - def_bool y >> - >> config AMD_MEM_ENCRYPT >> bool "AMD Secure Memory Encryption (SME) support" >> depends on X86_64 && CPU_SUP_AMD
diff --git a/arch/Kconfig b/arch/Kconfig index c47b328eada0..4ef3499d4480 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -927,6 +927,9 @@ config LOCK_EVENT_COUNTS the chance of application behavior change because of timing differences. The counts are reported via debugfs. +config ARCH_HAS_MEM_ENCRYPT + bool + source "kernel/gcov/Kconfig" source "scripts/gcc-plugins/Kconfig" diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index 5d8570ed6cab..f820e631bf89 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -1,7 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -config ARCH_HAS_MEM_ENCRYPT - def_bool y - config MMU def_bool y diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index c9f331bb538b..5d3295f2df94 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -68,6 +68,7 @@ config X86 select ARCH_HAS_FORTIFY_SOURCE select ARCH_HAS_GCOV_PROFILE_ALL select ARCH_HAS_KCOV if X86_64 + select ARCH_HAS_MEM_ENCRYPT select ARCH_HAS_MEMBARRIER_SYNC_CORE select ARCH_HAS_PMEM_API if X86_64 select ARCH_HAS_PTE_SPECIAL @@ -1520,9 +1521,6 @@ config X86_CPA_STATISTICS helps to determine the effectiveness of preserving large and huge page mappings when mapping protections are changed. -config ARCH_HAS_MEM_ENCRYPT - def_bool y - config AMD_MEM_ENCRYPT bool "AMD Secure Memory Encryption (SME) support" depends on X86_64 && CPU_SUP_AMD