| Message ID | d6a9d49c9837d38816b71d783f5aed7235e8ca94.1562734889.git.joe@perches.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | treewide: Fix GENMASK misuses | expand |
Hi, I noticed that this is totaly wrong, so I will fix here. If you wan I will put a separate patch. On Wed, Jul 10, 2019 at 8:04 AM Joe Perches <joe@perches.com> wrote: > > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/clocksource/timer-npcm7xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/timer-npcm7xx.c b/drivers/clocksource/timer-npcm7xx.c > index 7a9bb5532d99..8a30da7f083b 100644 > --- a/drivers/clocksource/timer-npcm7xx.c > +++ b/drivers/clocksource/timer-npcm7xx.c > @@ -32,7 +32,7 @@ > #define NPCM7XX_Tx_INTEN BIT(29) > #define NPCM7XX_Tx_COUNTEN BIT(30) > #define NPCM7XX_Tx_ONESHOT 0x0 > -#define NPCM7XX_Tx_OPER GENMASK(3, 27) > +#define NPCM7XX_Tx_OPER GENMASK(27, 3) It should be: +#define NPCM7XX_Tx_OPER GENMASK(28, 27) but I need to do another change. > #define NPCM7XX_Tx_MIN_PRESCALE 0x1 > #define NPCM7XX_Tx_TDR_MASK_BITS 24 > #define NPCM7XX_Tx_MAX_CNT 0xFFFFFF > -- > 2.15.0 >
diff --git a/drivers/clocksource/timer-npcm7xx.c b/drivers/clocksource/timer-npcm7xx.c index 7a9bb5532d99..8a30da7f083b 100644 --- a/drivers/clocksource/timer-npcm7xx.c +++ b/drivers/clocksource/timer-npcm7xx.c @@ -32,7 +32,7 @@ #define NPCM7XX_Tx_INTEN BIT(29) #define NPCM7XX_Tx_COUNTEN BIT(30) #define NPCM7XX_Tx_ONESHOT 0x0 -#define NPCM7XX_Tx_OPER GENMASK(3, 27) +#define NPCM7XX_Tx_OPER GENMASK(27, 3) #define NPCM7XX_Tx_MIN_PRESCALE 0x1 #define NPCM7XX_Tx_TDR_MASK_BITS 24 #define NPCM7XX_Tx_MAX_CNT 0xFFFFFF
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/clocksource/timer-npcm7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)