| Message ID | 20190709062637.27589-1-adrian.freihofer@siemens.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-swupdate,<thud>] depend on efibootguard in legacy.inc | expand |
Hi Adrian, On 09/07/19 08:26, Adrian Freihofer wrote: > --- > recipes-support/swupdate/swupdate-legacy.inc | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/recipes-support/swupdate/swupdate-legacy.inc b/recipes-support/swupdate/swupdate-legacy.inc > index 81dd2c8..3be261c 100644 > --- a/recipes-support/swupdate/swupdate-legacy.inc > +++ b/recipes-support/swupdate/swupdate-legacy.inc > @@ -95,6 +95,10 @@ python () { > > if 'CONFIG_MONGOOSE_WEB_API_V2=y\n' in features: > d.setVar('SWUPDATE_WWW', 'webapp') > + > + if 'CONFIG_BOOTLOADER_EBG=y\n' in features: > + depends = d.getVar('DEPENDS', False) > + d.setVar('DEPENDS', depends + ' efibootguard') > } > > do_configure () { > Ok, so commit c506a2d7529a35335a12450eb7b75772f1c8f8cd (this patch was already merged should be set to -thud, too. I apply it. Thanks, Stefano
On 09/07/19 21:48, Stefano Babic wrote: > Hi Adrian, > > On 09/07/19 08:26, Adrian Freihofer wrote: >> --- >> recipes-support/swupdate/swupdate-legacy.inc | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/recipes-support/swupdate/swupdate-legacy.inc b/recipes-support/swupdate/swupdate-legacy.inc >> index 81dd2c8..3be261c 100644 >> --- a/recipes-support/swupdate/swupdate-legacy.inc >> +++ b/recipes-support/swupdate/swupdate-legacy.inc >> @@ -95,6 +95,10 @@ python () { >> >> if 'CONFIG_MONGOOSE_WEB_API_V2=y\n' in features: >> d.setVar('SWUPDATE_WWW', 'webapp') >> + >> + if 'CONFIG_BOOTLOADER_EBG=y\n' in features: >> + depends = d.getVar('DEPENDS', False) >> + d.setVar('DEPENDS', depends + ' efibootguard') >> } >> >> do_configure () { >> > > Ok, so commit c506a2d7529a35335a12450eb7b75772f1c8f8cd (this patch was > already merged should be set to -thud, too. I apply it. > Mmmhh...it is already on -thud - which is the issue ? Best regards, Stefano Babic
Am Dienstag, 9. Juli 2019 21:51:20 UTC+2 schrieb Stefano Babic: > On 09/07/19 21:48, Stefano Babic wrote: > > Hi Adrian, > > > > On 09/07/19 08:26, Adrian Freihofer wrote: > >> --- > >> recipes-support/swupdate/swupdate-legacy.inc | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/recipes-support/swupdate/swupdate-legacy.inc b/recipes-support/swupdate/swupdate-legacy.inc > >> index 81dd2c8..3be261c 100644 > >> --- a/recipes-support/swupdate/swupdate-legacy.inc > >> +++ b/recipes-support/swupdate/swupdate-legacy.inc > >> @@ -95,6 +95,10 @@ python () { > >> > >> if 'CONFIG_MONGOOSE_WEB_API_V2=y\n' in features: > >> d.setVar('SWUPDATE_WWW', 'webapp') > >> + > >> + if 'CONFIG_BOOTLOADER_EBG=y\n' in features: > >> + depends = d.getVar('DEPENDS', False) > >> + d.setVar('DEPENDS', depends + ' efibootguard') > >> } > >> > >> do_configure () { > >> > > > > Ok, so commit c506a2d7529a35335a12450eb7b75772f1c8f8cd (this patch was > > already merged should be set to -thud, too. I apply it. > > > > Mmmhh...it is already on -thud - which is the issue ? > > Best regards, > Stefano Babic > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de > ===================================================================== Hi Stefano The issue is that there is a copy of the .inc file on the thud branch. The previous patch was applied to the swupdate.inc file. This patch applies to the swupdate-legacy.inc file. Thank you and regards, Adrian
On 09/07/19 22:49, adrian.freihofer@gmail.com wrote: > Am Dienstag, 9. Juli 2019 21:51:20 UTC+2 schrieb Stefano Babic: >> On 09/07/19 21:48, Stefano Babic wrote: >>> Hi Adrian, >>> >>> On 09/07/19 08:26, Adrian Freihofer wrote: >>>> --- >>>> recipes-support/swupdate/swupdate-legacy.inc | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/recipes-support/swupdate/swupdate-legacy.inc b/recipes-support/swupdate/swupdate-legacy.inc >>>> index 81dd2c8..3be261c 100644 >>>> --- a/recipes-support/swupdate/swupdate-legacy.inc >>>> +++ b/recipes-support/swupdate/swupdate-legacy.inc >>>> @@ -95,6 +95,10 @@ python () { >>>> >>>> if 'CONFIG_MONGOOSE_WEB_API_V2=y\n' in features: >>>> d.setVar('SWUPDATE_WWW', 'webapp') >>>> + >>>> + if 'CONFIG_BOOTLOADER_EBG=y\n' in features: >>>> + depends = d.getVar('DEPENDS', False) >>>> + d.setVar('DEPENDS', depends + ' efibootguard') >>>> } >>>> >>>> do_configure () { >>>> >>> >>> Ok, so commit c506a2d7529a35335a12450eb7b75772f1c8f8cd (this patch was >>> already merged should be set to -thud, too. I apply it. >>> >> >> Mmmhh...it is already on -thud - which is the issue ? >> >> Best regards, >> Stefano Babic >> >> -- >> ===================================================================== >> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de >> ===================================================================== > > Hi Stefano > > The issue is that there is a copy of the .inc file on the thud branch. The previous patch was applied to the swupdate.inc file. This patch applies to the swupdate-legacy.inc file. > Ok, got it. Your Signed-off-by was missing, I have added it myself. Best regards, Stefano Babic
diff --git a/recipes-support/swupdate/swupdate-legacy.inc b/recipes-support/swupdate/swupdate-legacy.inc index 81dd2c8..3be261c 100644 --- a/recipes-support/swupdate/swupdate-legacy.inc +++ b/recipes-support/swupdate/swupdate-legacy.inc @@ -95,6 +95,10 @@ python () { if 'CONFIG_MONGOOSE_WEB_API_V2=y\n' in features: d.setVar('SWUPDATE_WWW', 'webapp') + + if 'CONFIG_BOOTLOADER_EBG=y\n' in features: + depends = d.getVar('DEPENDS', False) + d.setVar('DEPENDS', depends + ' efibootguard') } do_configure () {