| Message ID | 20190708211404.56961-1-freifunk@adrianschmutzler.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [OpenWrt-Devel] rb532: Fix missing DEVICE_TITLE | expand |
Merged into my staging tree. Thank you!
> -----Original Message----- > From: Darbyshire-Bryant, Kevin [mailto:kevin@darbyshire-bryant.me.uk] On > Behalf Of Kevin Darbyshire-Bryant > Sent: Dienstag, 9. Juli 2019 21:09 > To: openwrt-devel@lists.openwrt.org > Cc: Adrian Schmutzler <freifunk@adrianschmutzler.de>; Kevin Darbyshire- > Bryant <ldir@darbyshire-bryant.me.uk> > Subject: Merged: rb532: Fix missing DEVICE_TITLE > > Merged into my staging tree. > Thank you! Does this require backporting to 19.07? The warnings do not occur there (seems to be interference with some other changes in master), but DEVICE_TITLE is not set on 19.07 either. Best Adrian
> On 9 Jul 2019, at 21:23, mail@adrianschmutzler.de wrote: > >> -----Original Message----- >> From: Darbyshire-Bryant, Kevin [mailto:kevin@darbyshire-bryant.me.uk] On >> Behalf Of Kevin Darbyshire-Bryant >> Sent: Dienstag, 9. Juli 2019 21:09 >> To: openwrt-devel@lists.openwrt.org >> Cc: Adrian Schmutzler <freifunk@adrianschmutzler.de>; Kevin Darbyshire- >> Bryant <ldir@darbyshire-bryant.me.uk> >> Subject: Merged: rb532: Fix missing DEVICE_TITLE >> >> Merged into my staging tree. >> Thank you! > > Does this require backporting to 19.07? The warnings do not occur there (seems to be interference with some other changes in master), but DEVICE_TITLE is not set on 19.07 either. I don’t think so, or it doesn’t generate the warnings at least. I suspect related to one or more of 0096a1cf00 scripts/config: fix *c_shipped build depency tracking 75dcaf3d23 config: fix relational operators for bool and tristate symbols 972123f1e0 config: regenerate *_shipped sources Kevin
diff --git a/target/linux/rb532/image/Makefile b/target/linux/rb532/image/Makefile index 615c9bd265..1558bf56d8 100644 --- a/target/linux/rb532/image/Makefile +++ b/target/linux/rb532/image/Makefile @@ -38,6 +38,7 @@ endef define Device/nand CMDLINE := ubi.mtd=1 ubi.block=0,rootfs root=/dev/ubiblock0_1 BOARD_NAME := rb532 + DEVICE_TITLE := rb532 NAND SUPPORTED_DEVICES := rb532 KERNEL_INITRAMFS := append-kernel | patch-cmdline | lzma | lzma-loader-elf KERNEL := $$(KERNEL_INITRAMFS) | kernel2minor -s 2048 -i 0 -c
This fixes the collection of target info during build, where the device title for rb532/nand is just empty: tmp/.config-target.in:44925:warning: leading whitespace ignored tmp/.config-target.in:123738:warning: leading whitespace ignored tmp/.config-target.in:123786:warning: leading whitespace ignored Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- target/linux/rb532/image/Makefile | 1 + 1 file changed, 1 insertion(+)