| Message ID | CALLt3ThSs20qKztpTePS+Xk7gB_m8YOnq2ROTLuVt6-kGTHL7g@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [committed] Add myself to MAINTAINERS | expand |
Kito Cheng <kito.cheng@sifive.com> writes: > ChangeLog: > > 2019-07-08 Kito Cheng <kito.cheng@sifive.com> > > * MAINTAINERS (Write After Approval): Add myself. > > --- MAINTAINERS (revision 273194) > +++ MAINTAINERS (revision 273195) > @@ -651,6 +651,7 @@ > Jon Ziegler <jonz@apple.com> > Roman Zippel <zippel@linux-m68k.org> > Josef Zlomek <josef.zlomek@email.cz> > +Kito Cheng <kito.cheng@sifive.com> Please keep the list sorted by surname. Thanks. Rainer
Hi Rainer: Thanks your reminder, I've fix it now. On Mon, Jul 8, 2019 at 4:14 PM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote: > > Kito Cheng <kito.cheng@sifive.com> writes: > > > ChangeLog: > > > > 2019-07-08 Kito Cheng <kito.cheng@sifive.com> > > > > * MAINTAINERS (Write After Approval): Add myself. > > > > --- MAINTAINERS (revision 273194) > > +++ MAINTAINERS (revision 273195) > > @@ -651,6 +651,7 @@ > > Jon Ziegler <jonz@apple.com> > > Roman Zippel <zippel@linux-m68k.org> > > Josef Zlomek <josef.zlomek@email.cz> > > +Kito Cheng <kito.cheng@sifive.com> > > Please keep the list sorted by surname. > > Thanks. > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University
On Mon, Jul 08, 2019 at 05:16:26PM +0800, Kito Cheng wrote: > Hi Rainer: > > Thanks your reminder, I've fix it now. Still not correct, there is FAIL maintainers-verify.sh. You are already since r246280 listed as riscv CPU port maintainer (one of 4) and maintainers should not be listed in the write after approval section, they are already listed in the maintainers (or reviewers) section(s). Please remove yourself from Write After Approval. Jakub
Hi Jakub:
Thanks, fixed and checked with maintainers-verify.sh now.
2019-07-08 Kito Cheng <kito.cheng@sifive.com>
* MAINTAINERS (Write After Approval): Remove myself, already listed in
RISC-V port maitainer.
Index: MAINTAINERS
===================================================================
--- MAINTAINERS (revision 273234)
+++ MAINTAINERS (revision 273235)
@@ -345,7 +345,6 @@
Chandra Chavva <cchavva@redhat.com>
Dehao Chen <dehao@google.com>
Fabien Chêne <fabien@gcc.gnu.org>
-Kito Cheng <kito.cheng@sifive.com>
Harshit Chopra <harshit@google.com>
Tamar Christina
<tamar.christina@arm.com>
Eric Christopher <echristo@gmail.com>
On Mon, Jul 8, 2019 at 8:48 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Mon, Jul 08, 2019 at 05:16:26PM +0800, Kito Cheng wrote:
> > Hi Rainer:
> >
> > Thanks your reminder, I've fix it now.
>
> Still not correct, there is FAIL maintainers-verify.sh.
> You are already since r246280 listed as riscv CPU port maintainer (one of 4)
> and maintainers should not be listed in the write after approval section,
> they are already listed in the maintainers (or reviewers) section(s).
> Please remove yourself from Write After Approval.
>
> Jakub
--- MAINTAINERS (revision 273194) +++ MAINTAINERS (revision 273195) @@ -651,6 +651,7 @@ Jon Ziegler <jonz@apple.com> Roman Zippel <zippel@linux-m68k.org> Josef Zlomek <josef.zlomek@email.cz> +Kito Cheng <kito.cheng@sifive.com> Bug database only accounts
ChangeLog: 2019-07-08 Kito Cheng <kito.cheng@sifive.com> * MAINTAINERS (Write After Approval): Add myself.