| Message ID | 20190630205307.27360-1-marex@denx.de |
|---|---|
| State | Rejected |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: imx: Allow iMX PCIe driver on iMX6SX | expand |
Hi Marek, Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut: > The driver supports iMX6SX, align the Kconfig file with the driver. The patch "PCI: Kconfig: Simplify PCI_IMX6 depends on", which will hopefully hit mainline pretty soon now after it got lost in the cracks of my inbox for far too long, is a more complete solution to the same problem. Regards, Lucas > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: Sasha Levin <sashal@kernel.org> > Cc: Sven Van Asbroeck <TheSven73@googlemail.com> > Cc: Trent Piepho <tpiepho@impinj.com> > --- > drivers/pci/controller/dwc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index a6ce1ee51b4c..3051387bf4f3 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -90,7 +90,7 @@ config PCI_EXYNOS > > config PCI_IMX6 > bool "Freescale i.MX6/7/8 PCIe controller" > - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST > + depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST > depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW_HOST >
On 7/2/19 3:18 PM, Lucas Stach wrote: > Hi Marek, > > Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut: >> The driver supports iMX6SX, align the Kconfig file with the driver. > > The patch "PCI: Kconfig: Simplify PCI_IMX6 depends on", which will > hopefully hit mainline pretty soon now after it got lost in the cracks > of my inbox for far too long, is a more complete solution to the same > problem. Is it ? Some of the SoCs where that other patch enables the driver do not even have a PCIe IP in it, it feels like a heavy-handed approach to me. >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Bjorn Helgaas <bhelgaas@google.com> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >> Cc: Lucas Stach <l.stach@pengutronix.de> >> Cc: Richard Zhu <hongxing.zhu@nxp.com> >> Cc: Sasha Levin <sashal@kernel.org> >> Cc: Sven Van Asbroeck <TheSven73@googlemail.com> >> Cc: Trent Piepho <tpiepho@impinj.com> >> --- >> drivers/pci/controller/dwc/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig >> index a6ce1ee51b4c..3051387bf4f3 100644 >> --- a/drivers/pci/controller/dwc/Kconfig >> +++ b/drivers/pci/controller/dwc/Kconfig >> @@ -90,7 +90,7 @@ config PCI_EXYNOS >> >> config PCI_IMX6 >> bool "Freescale i.MX6/7/8 PCIe controller" >> - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST >> + depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST >> depends on PCI_MSI_IRQ_DOMAIN >> select PCIE_DW_HOST >>
On Tue, Jul 02, 2019 at 03:18:25PM +0200, Lucas Stach wrote: > Hi Marek, > > Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut: > > The driver supports iMX6SX, align the Kconfig file with the driver. > > The patch "PCI: Kconfig: Simplify PCI_IMX6 depends on", which will > hopefully hit mainline pretty soon now after it got lost in the cracks > of my inbox for far too long, is a more complete solution to the same > problem. If so can you ACK it https://patchwork.ozlabs.org/patch/1054789/ please ? At the same time, I will drop this patch from the PCI queue. Thanks, Lorenzo > Regards, > Lucas > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Richard Zhu <hongxing.zhu@nxp.com> > > Cc: Sasha Levin <sashal@kernel.org> > > Cc: Sven Van Asbroeck <TheSven73@googlemail.com> > > Cc: Trent Piepho <tpiepho@impinj.com> > > --- > > drivers/pci/controller/dwc/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > index a6ce1ee51b4c..3051387bf4f3 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -90,7 +90,7 @@ config PCI_EXYNOS > > > > config PCI_IMX6 > > bool "Freescale i.MX6/7/8 PCIe controller" > > - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST > > + depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST > > depends on PCI_MSI_IRQ_DOMAIN > > select PCIE_DW_HOST > >
Hi Lorenzo, On Fri, Jul 5, 2019 at 12:34 PM Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > If so can you ACK it > > https://patchwork.ozlabs.org/patch/1054789/ > > please ? At the same time, I will drop this patch from the PCI queue. Lucas has already acked the patch from the patchwork link you shared.
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index a6ce1ee51b4c..3051387bf4f3 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -90,7 +90,7 @@ config PCI_EXYNOS config PCI_IMX6 bool "Freescale i.MX6/7/8 PCIe controller" - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST + depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST
The driver supports iMX6SX, align the Kconfig file with the driver. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: Richard Zhu <hongxing.zhu@nxp.com> Cc: Sasha Levin <sashal@kernel.org> Cc: Sven Van Asbroeck <TheSven73@googlemail.com> Cc: Trent Piepho <tpiepho@impinj.com> --- drivers/pci/controller/dwc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)