| Message ID | 1304023875-25040-3-git-send-email-rth@twiddle.net |
|---|---|
| State | New |
| Headers | show |
On Thu, Apr 28, 2011 at 11:50 PM, Richard Henderson <rth@twiddle.net> wrote: > This would affect Sparc as well. > > Signed-off-by: Richard Henderson <rth@twiddle.net> > Cc: Blue Swirl <blauwirbel@gmail.com> > --- > cpu-exec.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/cpu-exec.c b/cpu-exec.c > index 395cd8c..e1b85d6 100644 > --- a/cpu-exec.c > +++ b/cpu-exec.c > @@ -361,6 +361,7 @@ int cpu_exec(CPUState *env1) > if (unlikely(env->singlestep_enabled & SSTEP_NOIRQ)) { > /* Mask out external interrupts for this step. */ > interrupt_request &= ~(CPU_INTERRUPT_HARD | > + CPU_INTERRUPT_TIMER | Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set, only cleared or checked. How about removing the flag instead?
On 04/29/2011 01:53 PM, Blue Swirl wrote: >> + CPU_INTERRUPT_TIMER | > > Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set, > only cleared or checked. How > about removing the flag instead? Certainly Sparc and MIPS shouldn't check it if they don't set it. For Alpha, I do want to easily discriminate between device, timer, and inter-processor interrupts. I'm currently (ab)using the i386 CPU_INTERRUPT_SMI name for the IPI; I could abuse, say, FIQ for my timer bit, but it seems nicer to simply keep the TIMER name. r~
On Sat, Apr 30, 2011 at 1:39 AM, Richard Henderson <rth@twiddle.net> wrote: > On 04/29/2011 01:53 PM, Blue Swirl wrote: >>> + CPU_INTERRUPT_TIMER | >> >> Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set, >> only cleared or checked. How >> about removing the flag instead? > > Certainly Sparc and MIPS shouldn't check it if they don't set it. It's not used by any architecture now. > For Alpha, I do want to easily discriminate between device, timer, > and inter-processor interrupts. I'm currently (ab)using the i386 > CPU_INTERRUPT_SMI name for the IPI; I could abuse, say, FIQ for > my timer bit, but it seems nicer to simply keep the TIMER name. Since Alpha would be the first user, you can even rename it if you like.
diff --git a/cpu-exec.c b/cpu-exec.c index 395cd8c..e1b85d6 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -361,6 +361,7 @@ int cpu_exec(CPUState *env1) if (unlikely(env->singlestep_enabled & SSTEP_NOIRQ)) { /* Mask out external interrupts for this step. */ interrupt_request &= ~(CPU_INTERRUPT_HARD | + CPU_INTERRUPT_TIMER | CPU_INTERRUPT_FIQ | CPU_INTERRUPT_SMI | CPU_INTERRUPT_NMI);
This would affect Sparc as well. Signed-off-by: Richard Henderson <rth@twiddle.net> Cc: Blue Swirl <blauwirbel@gmail.com> --- cpu-exec.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)