| Message ID | 20190501233815.32643-1-digetx@gmail.com |
|---|---|
| Headers | show |
| Series | NVIDIA Tegra devfreq improvements and Tegra20/30 support | expand |
Hi Dmitry, On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote: > Changelog: > > v4: Addressed all review comments that were made by Chanwoo Choi to v3: > > - changed the driver removal order to match the probe exactly > - added clarifying comment for 1/8 ratio to the Tegra20 driver > > Chanwoo, please also note that the clk patch that should fix > compilation problem that was reported the kbuild-test-robot is already > applied and available in the recent linux-next. I knew that Stephen picked up your path about clock. > > v3: Addressed all review comments that were made by Chanwoo Choi to v2. > > Patch "Synchronize IRQ after masking it in hardware" morphed into > "Properly disable interrupts", which disables interrupts more solidly. > > Added new minor patch: "Rename tegra-devfreq.c to tegra30-devfreq.c". > > Added missed error handlings for dev_pm_opp_add(). > > v2: The patchset was quite heavily reworked since v1, few patches we > dropped or squashed into the new ones and more patches we added. > In a result more bugs and potential problems are fixed now, driver's > code got more clean up. > > The Tegra20 driver-addition patch is now a part of this series, it has > no changes since v1. > > Dmitry Osipenko (16): > PM / devfreq: tegra: Fix kHz to Hz conversion > PM / devfreq: tegra: Replace readl-writel with relaxed versions > PM / devfreq: tegra: Replace write memory barrier with the read > barrier > PM / devfreq: tegra: Don't ignore clk errors > PM / devfreq: tegra: Don't set EMC clock rate to maximum on probe > PM / devfreq: tegra: Drop primary interrupt handler > PM / devfreq: tegra: Properly disable interrupts > PM / devfreq: tegra: Clean up driver's probe / remove > PM / devfreq: tegra: Avoid inconsistency of current frequency value > PM / devfreq: tegra: Mark ACTMON's governor as immutable > PM / devfreq: tegra: Move governor registration to driver's probe > PM / devfreq: tegra: Reconfigure hardware on governor's restart > PM / devfreq: tegra: Support Tegra30 > PM / devfreq: tegra: Enable COMPILE_TEST for the driver > PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c > PM / devfreq: Introduce driver for NVIDIA Tegra20 > > MAINTAINERS | 8 + > drivers/devfreq/Kconfig | 15 +- > drivers/devfreq/Makefile | 3 +- > drivers/devfreq/tegra20-devfreq.c | 212 ++++++++++++ > .../{tegra-devfreq.c => tegra30-devfreq.c} | 315 ++++++++---------- > 5 files changed, 379 insertions(+), 174 deletions(-) > create mode 100644 drivers/devfreq/tegra20-devfreq.c > rename drivers/devfreq/{tegra-devfreq.c => tegra30-devfreq.c} (81%) >
03.05.2019 3:31, Chanwoo Choi пишет: > Hi Dmitry, > > On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote: >> Changelog: >> >> v4: Addressed all review comments that were made by Chanwoo Choi to v3: >> >> - changed the driver removal order to match the probe exactly >> - added clarifying comment for 1/8 ratio to the Tegra20 driver >> >> Chanwoo, please also note that the clk patch that should fix >> compilation problem that was reported the kbuild-test-robot is already >> applied and available in the recent linux-next. > > I knew that Stephen picked up your path about clock. Hi Chanwoo, Okay, good. Thank you very much for reviewing this series! I assume it's too late now for v5.2, but it should be good to go for v5.3.
03.05.2019 3:52, Dmitry Osipenko пишет: > 03.05.2019 3:31, Chanwoo Choi пишет: >> Hi Dmitry, >> >> On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote: >>> Changelog: >>> >>> v4: Addressed all review comments that were made by Chanwoo Choi to v3: >>> >>> - changed the driver removal order to match the probe exactly >>> - added clarifying comment for 1/8 ratio to the Tegra20 driver >>> >>> Chanwoo, please also note that the clk patch that should fix >>> compilation problem that was reported the kbuild-test-robot is already >>> applied and available in the recent linux-next. >> >> I knew that Stephen picked up your path about clock. > > Hi Chanwoo, > > Okay, good. Thank you very much for reviewing this series! I assume it's > too late now for v5.2, but it should be good to go for v5.3. > Hello Chanwoo, Will be nice to see the patches in the linux-next before they'll hit mainline. We have tested that everything works fine on a selective devices, but won't hurt to get some extra testing beforehand. AFAIK, at least NVIDIA people are regularly testing -next on theirs dev boards. Please note that this not very important, so don't bother if there is some hurdle with pushing to the tracking branch for now. Also please let me know if you're expecting to see some ACK's on the patches, I'm sure we'll be able to work out that with Thierry and Jon if necessary.
On 19. 6. 4. 오전 1:52, Dmitry Osipenko wrote: > 03.05.2019 3:52, Dmitry Osipenko пишет: >> 03.05.2019 3:31, Chanwoo Choi пишет: >>> Hi Dmitry, >>> >>> On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote: >>>> Changelog: >>>> >>>> v4: Addressed all review comments that were made by Chanwoo Choi to v3: >>>> >>>> - changed the driver removal order to match the probe exactly >>>> - added clarifying comment for 1/8 ratio to the Tegra20 driver >>>> >>>> Chanwoo, please also note that the clk patch that should fix >>>> compilation problem that was reported the kbuild-test-robot is already >>>> applied and available in the recent linux-next. >>> >>> I knew that Stephen picked up your path about clock. >> >> Hi Chanwoo, >> >> Okay, good. Thank you very much for reviewing this series! I assume it's >> too late now for v5.2, but it should be good to go for v5.3. >> > > Hello Chanwoo, > > Will be nice to see the patches in the linux-next before they'll hit mainline. We have tested that > everything works fine on a selective devices, but won't hurt to get some extra testing beforehand. > AFAIK, at least NVIDIA people are regularly testing -next on theirs dev boards. Please note that > this not very important, so don't bother if there is some hurdle with pushing to the tracking branch > for now. Also please let me know if you're expecting to see some ACK's on the patches, I'm sure > we'll be able to work out that with Thierry and Jon if necessary. > > Hi Dmitry, I think that it is enough for applying to mainline branch. The devfreq.git is maintained by Myungjoo. He will be merged or reviewed if there are th remained review point. Hi Myungjoo, I reviewed the Dmitry's patches from v1 to v4 patches. And then I tested them on my testing branch[1] for catching the build warning and error. In result, it is clean. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing Please review or apply these patches for v5.3.
04.06.2019 3:49, Chanwoo Choi пишет: > On 19. 6. 4. 오전 1:52, Dmitry Osipenko wrote: >> 03.05.2019 3:52, Dmitry Osipenko пишет: >>> 03.05.2019 3:31, Chanwoo Choi пишет: >>>> Hi Dmitry, >>>> >>>> On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote: >>>>> Changelog: >>>>> >>>>> v4: Addressed all review comments that were made by Chanwoo Choi to v3: >>>>> >>>>> - changed the driver removal order to match the probe exactly >>>>> - added clarifying comment for 1/8 ratio to the Tegra20 driver >>>>> >>>>> Chanwoo, please also note that the clk patch that should fix >>>>> compilation problem that was reported the kbuild-test-robot is already >>>>> applied and available in the recent linux-next. >>>> >>>> I knew that Stephen picked up your path about clock. >>> >>> Hi Chanwoo, >>> >>> Okay, good. Thank you very much for reviewing this series! I assume it's >>> too late now for v5.2, but it should be good to go for v5.3. >>> >> >> Hello Chanwoo, >> >> Will be nice to see the patches in the linux-next before they'll hit mainline. We have tested that >> everything works fine on a selective devices, but won't hurt to get some extra testing beforehand. >> AFAIK, at least NVIDIA people are regularly testing -next on theirs dev boards. Please note that >> this not very important, so don't bother if there is some hurdle with pushing to the tracking branch >> for now. Also please let me know if you're expecting to see some ACK's on the patches, I'm sure >> we'll be able to work out that with Thierry and Jon if necessary. >> >> > > Hi Dmitry, > I think that it is enough for applying to mainline branch. > The devfreq.git is maintained by Myungjoo. He will be merged or > reviewed if there are th remained review point. Thank you very much! > > Hi Myungjoo, > I reviewed the Dmitry's patches from v1 to v4 patches. > And then I tested them on my testing branch[1] for catching > the build warning and error. In result, it is clean. > [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing > > Please review or apply these patches for v5.3. > Hello Myungjoo, I think this patchset should be completed now. Thierry has some extra comments to the patches, but seems nothing critical so far and all the concerns could be addressed in a follow-up series. Please let me know if you're fine with this, I can re-spin v5 as well if necessary.
05.06.2019 2:09, Dmitry Osipenko пишет: > 04.06.2019 3:49, Chanwoo Choi пишет: >> On 19. 6. 4. 오전 1:52, Dmitry Osipenko wrote: >>> 03.05.2019 3:52, Dmitry Osipenko пишет: >>>> 03.05.2019 3:31, Chanwoo Choi пишет: >>>>> Hi Dmitry, >>>>> >>>>> On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote: >>>>>> Changelog: >>>>>> >>>>>> v4: Addressed all review comments that were made by Chanwoo Choi to v3: >>>>>> >>>>>> - changed the driver removal order to match the probe exactly >>>>>> - added clarifying comment for 1/8 ratio to the Tegra20 driver >>>>>> >>>>>> Chanwoo, please also note that the clk patch that should fix >>>>>> compilation problem that was reported the kbuild-test-robot is already >>>>>> applied and available in the recent linux-next. >>>>> >>>>> I knew that Stephen picked up your path about clock. >>>> >>>> Hi Chanwoo, >>>> >>>> Okay, good. Thank you very much for reviewing this series! I assume it's >>>> too late now for v5.2, but it should be good to go for v5.3. >>>> >>> >>> Hello Chanwoo, >>> >>> Will be nice to see the patches in the linux-next before they'll hit mainline. We have tested that >>> everything works fine on a selective devices, but won't hurt to get some extra testing beforehand. >>> AFAIK, at least NVIDIA people are regularly testing -next on theirs dev boards. Please note that >>> this not very important, so don't bother if there is some hurdle with pushing to the tracking branch >>> for now. Also please let me know if you're expecting to see some ACK's on the patches, I'm sure >>> we'll be able to work out that with Thierry and Jon if necessary. >>> >>> >> >> Hi Dmitry, >> I think that it is enough for applying to mainline branch. >> The devfreq.git is maintained by Myungjoo. He will be merged or >> reviewed if there are th remained review point. > > Thank you very much! > >> >> Hi Myungjoo, >> I reviewed the Dmitry's patches from v1 to v4 patches. >> And then I tested them on my testing branch[1] for catching >> the build warning and error. In result, it is clean. >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing >> >> Please review or apply these patches for v5.3. >> > > Hello Myungjoo, > > I think this patchset should be completed now. Thierry has some extra > comments to the patches, but seems nothing critical so far and all the > concerns could be addressed in a follow-up series. Please let me know if > you're fine with this, I can re-spin v5 as well if necessary. > Hello Chanwoo, It looks like Myungjoo is inactive at the moment. Do you know if he'll be back to the time of the merge window opening or you'll be curating the pull request for 5.3 this time? Secondly, I'll send a few more patches on top of this series, addressing Thierry's comments and making more improvements. Please let me know if this causes any problems and I should re-spin the whole series.
Hi Dmitry, On 19. 6. 24. 오전 2:17, Dmitry Osipenko wrote: > 05.06.2019 2:09, Dmitry Osipenko пишет: >> 04.06.2019 3:49, Chanwoo Choi пишет: >>> On 19. 6. 4. 오전 1:52, Dmitry Osipenko wrote: >>>> 03.05.2019 3:52, Dmitry Osipenko пишет: >>>>> 03.05.2019 3:31, Chanwoo Choi пишет: >>>>>> Hi Dmitry, >>>>>> >>>>>> On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote: >>>>>>> Changelog: >>>>>>> >>>>>>> v4: Addressed all review comments that were made by Chanwoo Choi to v3: >>>>>>> >>>>>>> - changed the driver removal order to match the probe exactly >>>>>>> - added clarifying comment for 1/8 ratio to the Tegra20 driver >>>>>>> >>>>>>> Chanwoo, please also note that the clk patch that should fix >>>>>>> compilation problem that was reported the kbuild-test-robot is already >>>>>>> applied and available in the recent linux-next. >>>>>> >>>>>> I knew that Stephen picked up your path about clock. >>>>> >>>>> Hi Chanwoo, >>>>> >>>>> Okay, good. Thank you very much for reviewing this series! I assume it's >>>>> too late now for v5.2, but it should be good to go for v5.3. >>>>> >>>> >>>> Hello Chanwoo, >>>> >>>> Will be nice to see the patches in the linux-next before they'll hit mainline. We have tested that >>>> everything works fine on a selective devices, but won't hurt to get some extra testing beforehand. >>>> AFAIK, at least NVIDIA people are regularly testing -next on theirs dev boards. Please note that >>>> this not very important, so don't bother if there is some hurdle with pushing to the tracking branch >>>> for now. Also please let me know if you're expecting to see some ACK's on the patches, I'm sure >>>> we'll be able to work out that with Thierry and Jon if necessary. >>>> >>>> >>> >>> Hi Dmitry, >>> I think that it is enough for applying to mainline branch. >>> The devfreq.git is maintained by Myungjoo. He will be merged or >>> reviewed if there are th remained review point. >> >> Thank you very much! >> >>> >>> Hi Myungjoo, >>> I reviewed the Dmitry's patches from v1 to v4 patches. >>> And then I tested them on my testing branch[1] for catching >>> the build warning and error. In result, it is clean. >>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing >>> >>> Please review or apply these patches for v5.3. >>> >> >> Hello Myungjoo, >> >> I think this patchset should be completed now. Thierry has some extra >> comments to the patches, but seems nothing critical so far and all the >> concerns could be addressed in a follow-up series. Please let me know if >> you're fine with this, I can re-spin v5 as well if necessary. >> > > Hello Chanwoo, > > It looks like Myungjoo is inactive at the moment. Do you know if he'll > be back to the time of the merge window opening or you'll be curating > the pull request for 5.3 this time? Myungoo works in the same place. I'll talk with him. > > Secondly, I'll send a few more patches on top of this series, addressing > Thierry's comments and making more improvements. Please let me know if > this causes any problems and I should re-spin the whole series. OK. I'll review them.
24.06.2019 2:50, Chanwoo Choi пишет: > Hi Dmitry, > > On 19. 6. 24. 오전 2:17, Dmitry Osipenko wrote: >> 05.06.2019 2:09, Dmitry Osipenko пишет: >>> 04.06.2019 3:49, Chanwoo Choi пишет: >>>> On 19. 6. 4. 오전 1:52, Dmitry Osipenko wrote: >>>>> 03.05.2019 3:52, Dmitry Osipenko пишет: >>>>>> 03.05.2019 3:31, Chanwoo Choi пишет: >>>>>>> Hi Dmitry, >>>>>>> >>>>>>> On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote: >>>>>>>> Changelog: >>>>>>>> >>>>>>>> v4: Addressed all review comments that were made by Chanwoo Choi to v3: >>>>>>>> >>>>>>>> - changed the driver removal order to match the probe exactly >>>>>>>> - added clarifying comment for 1/8 ratio to the Tegra20 driver >>>>>>>> >>>>>>>> Chanwoo, please also note that the clk patch that should fix >>>>>>>> compilation problem that was reported the kbuild-test-robot is already >>>>>>>> applied and available in the recent linux-next. >>>>>>> >>>>>>> I knew that Stephen picked up your path about clock. >>>>>> >>>>>> Hi Chanwoo, >>>>>> >>>>>> Okay, good. Thank you very much for reviewing this series! I assume it's >>>>>> too late now for v5.2, but it should be good to go for v5.3. >>>>>> >>>>> >>>>> Hello Chanwoo, >>>>> >>>>> Will be nice to see the patches in the linux-next before they'll hit mainline. We have tested that >>>>> everything works fine on a selective devices, but won't hurt to get some extra testing beforehand. >>>>> AFAIK, at least NVIDIA people are regularly testing -next on theirs dev boards. Please note that >>>>> this not very important, so don't bother if there is some hurdle with pushing to the tracking branch >>>>> for now. Also please let me know if you're expecting to see some ACK's on the patches, I'm sure >>>>> we'll be able to work out that with Thierry and Jon if necessary. >>>>> >>>>> >>>> >>>> Hi Dmitry, >>>> I think that it is enough for applying to mainline branch. >>>> The devfreq.git is maintained by Myungjoo. He will be merged or >>>> reviewed if there are th remained review point. >>> >>> Thank you very much! >>> >>>> >>>> Hi Myungjoo, >>>> I reviewed the Dmitry's patches from v1 to v4 patches. >>>> And then I tested them on my testing branch[1] for catching >>>> the build warning and error. In result, it is clean. >>>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing >>>> >>>> Please review or apply these patches for v5.3. >>>> >>> >>> Hello Myungjoo, >>> >>> I think this patchset should be completed now. Thierry has some extra >>> comments to the patches, but seems nothing critical so far and all the >>> concerns could be addressed in a follow-up series. Please let me know if >>> you're fine with this, I can re-spin v5 as well if necessary. >>> >> >> Hello Chanwoo, >> >> It looks like Myungjoo is inactive at the moment. Do you know if he'll >> be back to the time of the merge window opening or you'll be curating >> the pull request for 5.3 this time? > > Myungoo works in the same place. I'll talk with him. > >> >> Secondly, I'll send a few more patches on top of this series, addressing >> Thierry's comments and making more improvements. Please let me know if >> this causes any problems and I should re-spin the whole series. > > OK. I'll review them. Thank you!
Changelog: v4: Addressed all review comments that were made by Chanwoo Choi to v3: - changed the driver removal order to match the probe exactly - added clarifying comment for 1/8 ratio to the Tegra20 driver Chanwoo, please also note that the clk patch that should fix compilation problem that was reported the kbuild-test-robot is already applied and available in the recent linux-next. v3: Addressed all review comments that were made by Chanwoo Choi to v2. Patch "Synchronize IRQ after masking it in hardware" morphed into "Properly disable interrupts", which disables interrupts more solidly. Added new minor patch: "Rename tegra-devfreq.c to tegra30-devfreq.c". Added missed error handlings for dev_pm_opp_add(). v2: The patchset was quite heavily reworked since v1, few patches we dropped or squashed into the new ones and more patches we added. In a result more bugs and potential problems are fixed now, driver's code got more clean up. The Tegra20 driver-addition patch is now a part of this series, it has no changes since v1. Dmitry Osipenko (16): PM / devfreq: tegra: Fix kHz to Hz conversion PM / devfreq: tegra: Replace readl-writel with relaxed versions PM / devfreq: tegra: Replace write memory barrier with the read barrier PM / devfreq: tegra: Don't ignore clk errors PM / devfreq: tegra: Don't set EMC clock rate to maximum on probe PM / devfreq: tegra: Drop primary interrupt handler PM / devfreq: tegra: Properly disable interrupts PM / devfreq: tegra: Clean up driver's probe / remove PM / devfreq: tegra: Avoid inconsistency of current frequency value PM / devfreq: tegra: Mark ACTMON's governor as immutable PM / devfreq: tegra: Move governor registration to driver's probe PM / devfreq: tegra: Reconfigure hardware on governor's restart PM / devfreq: tegra: Support Tegra30 PM / devfreq: tegra: Enable COMPILE_TEST for the driver PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c PM / devfreq: Introduce driver for NVIDIA Tegra20 MAINTAINERS | 8 + drivers/devfreq/Kconfig | 15 +- drivers/devfreq/Makefile | 3 +- drivers/devfreq/tegra20-devfreq.c | 212 ++++++++++++ .../{tegra-devfreq.c => tegra30-devfreq.c} | 315 ++++++++---------- 5 files changed, 379 insertions(+), 174 deletions(-) create mode 100644 drivers/devfreq/tegra20-devfreq.c rename drivers/devfreq/{tegra-devfreq.c => tegra30-devfreq.c} (81%)