Message ID | 1559334700-51970-1-git-send-email-anoo@linux.ibm.com |
---|---|
State | Not Applicable |
Headers | show |
Series | [dev-5.1] ARM: dts: aspeed: swift: Add VDD (IR35219) devices | expand |
On Fri, 31 May 2019 at 20:31, Adriana Kobylak <anoo@linux.ibm.com> wrote: > > From: Adriana Kobylak <anoo@us.ibm.com> > > Add the VDD (IR35219) devices to the Swift device tree. > > + ir35219@70 { > + compatible = "infineon,ir35219"; There's no driver for these in our tree. Do you have one coming?
On 2019-06-03 04:06, Joel Stanley wrote: > On Fri, 31 May 2019 at 20:31, Adriana Kobylak <anoo@linux.ibm.com> > wrote: >> >> From: Adriana Kobylak <anoo@us.ibm.com> >> >> Add the VDD (IR35219) devices to the Swift device tree. >> >> + ir35219@70 { >> + compatible = "infineon,ir35219"; > > There's no driver for these in our tree. Do you have one coming? Eddie will be writing one [Swift VDD VRM device driver #311](https://github.com/ibm-openbmc/dev/issues/311) Should we put this patch on hold until the driver is done?
On Mon, 3 Jun 2019 at 19:37, Adriana Kobylak <anoo@linux.ibm.com> wrote: > > On 2019-06-03 04:06, Joel Stanley wrote: > > On Fri, 31 May 2019 at 20:31, Adriana Kobylak <anoo@linux.ibm.com> > > wrote: > >> > >> From: Adriana Kobylak <anoo@us.ibm.com> > >> > >> Add the VDD (IR35219) devices to the Swift device tree. > >> > >> + ir35219@70 { > >> + compatible = "infineon,ir35219"; > > > > There's no driver for these in our tree. Do you have one coming? > > Eddie will be writing one [Swift VDD VRM device driver > #311](https://github.com/ibm-openbmc/dev/issues/311) > Should we put this patch on hold until the driver is done? Yes. We generally don't put things in the device tree if there's no driver. Cheers, Joel
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts index 270c923..8590e6b 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts @@ -723,6 +723,11 @@ reg = <0x4c>; }; + ir35219@70 { + compatible = "infineon,ir35219"; + reg = <0x70>; + }; + ir35221@71 { compatible = "infineon,ir35221"; reg = <0x71>; @@ -820,6 +825,11 @@ reg = <0x4c>; }; + ir35219@70 { + compatible = "infineon,ir35219"; + reg = <0x70>; + }; + ir35221@71 { compatible = "infineon,ir35221"; reg = <0x71>;