| Message ID | 1557305915-11247-3-git-send-email-guoren@kernel.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V2,1/9] arch/csky: Add VDSP and FLOAT_ABI compiler options. | expand |
On Wed, 8 May 2019 16:58:29 +0800 guoren@kernel.org wrote: > From: Guo Ren <ren_guo@c-sky.com> > > Enable csky buildroot build toolchain in framework. > > Signed-off-by: Guo Ren <ren_guo@c-sky.com> > --- > arch/Config.in | 1 - > package/Makefile.in | 9 +++++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/Config.in b/arch/Config.in > index d82803c..db1199c 100644 > --- a/arch/Config.in > +++ b/arch/Config.in > @@ -77,7 +77,6 @@ config BR2_aarch64_be > > config BR2_csky > bool "csky" > - select BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT The ordering is not good: you can't remove this "select" until all the toolchain components have C-SKY support added. So this patch should come later in the series, it should actually be one of the last patch, and should be: "arch/csky: enable internal toolchain backend" or something like that. > diff --git a/package/Makefile.in b/package/Makefile.in > index dc818a2..f05b9cc 100644 > --- a/package/Makefile.in > +++ b/package/Makefile.in > @@ -70,6 +70,15 @@ ABI := $(ABI)hf > endif > endif > > +# For C-SKY abiv1 & abiv2 > +ifeq ($(BR2_csky),y) > +ifeq ($(BR2_ck610),y) > +ABI = abiv1 > +else > +ABI = abiv2 > +endif > +endif This should be a separate patch. Best regards, Thomas
On Sun, May 26, 2019 at 10:44:52PM +0200, Thomas Petazzoni wrote: > On Wed, 8 May 2019 16:58:29 +0800 > guoren@kernel.org wrote: > > > From: Guo Ren <ren_guo@c-sky.com> > > > > Enable csky buildroot build toolchain in framework. > > > > Signed-off-by: Guo Ren <ren_guo@c-sky.com> > > --- > > arch/Config.in | 1 - > > package/Makefile.in | 9 +++++++++ > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/arch/Config.in b/arch/Config.in > > index d82803c..db1199c 100644 > > --- a/arch/Config.in > > +++ b/arch/Config.in > > @@ -77,7 +77,6 @@ config BR2_aarch64_be > > > > config BR2_csky > > bool "csky" > > - select BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT > > The ordering is not good: you can't remove this "select" until all the > toolchain components have C-SKY support added. So this patch should > come later in the series, it should actually be one of the last patch, > and should be: "arch/csky: enable internal toolchain backend" or > something like that. Ok. > > > diff --git a/package/Makefile.in b/package/Makefile.in > > index dc818a2..f05b9cc 100644 > > --- a/package/Makefile.in > > +++ b/package/Makefile.in > > @@ -70,6 +70,15 @@ ABI := $(ABI)hf > > endif > > endif > > > > +# For C-SKY abiv1 & abiv2 > > +ifeq ($(BR2_csky),y) > > +ifeq ($(BR2_ck610),y) > > +ABI = abiv1 > > +else > > +ABI = abiv2 > > +endif > > +endif > > This should be a separate patch. Ok. Best Regards Guo Ren
diff --git a/arch/Config.in b/arch/Config.in index d82803c..db1199c 100644 --- a/arch/Config.in +++ b/arch/Config.in @@ -77,7 +77,6 @@ config BR2_aarch64_be config BR2_csky bool "csky" - select BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT select BR2_ARCH_HAS_MMU_MANDATORY help csky is processor IP from china. diff --git a/package/Makefile.in b/package/Makefile.in index dc818a2..f05b9cc 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -70,6 +70,15 @@ ABI := $(ABI)hf endif endif +# For C-SKY abiv1 & abiv2 +ifeq ($(BR2_csky),y) +ifeq ($(BR2_ck610),y) +ABI = abiv1 +else +ABI = abiv2 +endif +endif + # For FSL PowerPC there's SPE ifeq ($(BR2_powerpc_SPE),y) ABI = spe