| Message ID | 20190514204053.124122-4-swboyd@chromium.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | Cleanup some unused functions in fdt.c | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, 14 May 2019 13:40:53 -0700, Stephen Boyd wrote: > The FDT pointer, i.e. initial_boot_params, shouldn't be changed after > init. It's only set by boot code and then the only user of the FDT is > the raw sysfs reading API. Mark this pointer with __ro_after_init so > that the pointer can't be changed after init. > > Cc: Hsin-Yi Wang <hsinyi@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/of/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. Rob
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 93414b89735f..f131a1b8588b 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -516,7 +516,7 @@ EXPORT_SYMBOL_GPL(of_fdt_unflatten_tree); int __initdata dt_root_addr_cells; int __initdata dt_root_size_cells; -void *initial_boot_params; +void *initial_boot_params __ro_after_init; #ifdef CONFIG_OF_EARLY_FLATTREE
The FDT pointer, i.e. initial_boot_params, shouldn't be changed after init. It's only set by boot code and then the only user of the FDT is the raw sysfs reading API. Mark this pointer with __ro_after_init so that the pointer can't be changed after init. Cc: Hsin-Yi Wang <hsinyi@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/of/fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)