| Message ID | 20190418124758.24022-2-glaroque@baylibre.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add drive-strength in Meson pinctrl driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Apr 18, 2019 at 2:48 PM Guillaume La Roque <glaroque@baylibre.com> wrote: > This property allow drive-strength parameter in uA instead of mA. > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> I'm fine with this but I need the DT maintainers to ACK it explicitly. Yours, Linus Walleij
On Thu, Apr 18, 2019 at 2:48 PM Guillaume La Roque <glaroque@baylibre.com> wrote: > > This property allow drive-strength parameter in uA instead of mA. > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> personally I'm happy with this if the DT maintainers give their ACK. based on that: Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Rob, Guillaume La Roque <glaroque@baylibre.com> writes: > This property allow drive-strength parameter in uA instead of mA. > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > index cef2b5855d60..fc7018459aa2 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > @@ -258,6 +258,7 @@ drive-push-pull - drive actively high and low > drive-open-drain - drive with open drain > drive-open-source - drive with open source > drive-strength - sink or source at most X mA > +drive-strength-uA - sink or source at most X uA > input-enable - enable input on pin (no effect on output, such as > enabling an input buffer) > input-disable - disable input on pin (no effect on output, such as > @@ -326,6 +327,8 @@ arguments are described below. > > - drive-strength takes as argument the target strength in mA. > > +- drive-strength-uA takes as argument the target strength in uA. > + > - input-debounce takes the debounce time in usec as argument > or 0 to disable debouncing Can we get your input on this? Linus W. is OK with this[1], but wants opinion/approval from DT maintainers first. Thanks, Kevin [1] https://lore.kernel.org/lkml/CACRpkdZ2dPzrtJQkxmN7V=f6+qYZAvrF+b0J77cN9hoRAgFqrw@mail.gmail.com/T/#u
On Thu, Apr 18, 2019 at 02:47:55PM +0200, Guillaume La Roque wrote: > This property allow drive-strength parameter in uA instead of mA. > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > index cef2b5855d60..fc7018459aa2 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > @@ -258,6 +258,7 @@ drive-push-pull - drive actively high and low > drive-open-drain - drive with open drain > drive-open-source - drive with open source > drive-strength - sink or source at most X mA > +drive-strength-uA - sink or source at most X uA > input-enable - enable input on pin (no effect on output, such as > enabling an input buffer) > input-disable - disable input on pin (no effect on output, such as > @@ -326,6 +327,8 @@ arguments are described below. > > - drive-strength takes as argument the target strength in mA. > > +- drive-strength-uA takes as argument the target strength in uA. > + We have standard unit suffixes defined in bindings/property-units.txt. Use them please. Rob
Hi Rob, On 4/30/19 5:12 PM, Rob Herring wrote: > On Thu, Apr 18, 2019 at 02:47:55PM +0200, Guillaume La Roque wrote: >> This property allow drive-strength parameter in uA instead of mA. >> >> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> >> --- >> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt >> index cef2b5855d60..fc7018459aa2 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt >> @@ -258,6 +258,7 @@ drive-push-pull - drive actively high and low >> drive-open-drain - drive with open drain >> drive-open-source - drive with open source >> drive-strength - sink or source at most X mA >> +drive-strength-uA - sink or source at most X uA >> input-enable - enable input on pin (no effect on output, such as >> enabling an input buffer) >> input-disable - disable input on pin (no effect on output, such as >> @@ -326,6 +327,8 @@ arguments are described below. >> >> - drive-strength takes as argument the target strength in mA. >> >> +- drive-strength-uA takes as argument the target strength in uA. >> + > We have standard unit suffixes defined in bindings/property-units.txt. > Use them please. thanks for your feedback and sorry i don't see this doc. According to it i will update patch series with drive-strength-microamp > Rob Guillaume
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt index cef2b5855d60..fc7018459aa2 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt @@ -258,6 +258,7 @@ drive-push-pull - drive actively high and low drive-open-drain - drive with open drain drive-open-source - drive with open source drive-strength - sink or source at most X mA +drive-strength-uA - sink or source at most X uA input-enable - enable input on pin (no effect on output, such as enabling an input buffer) input-disable - disable input on pin (no effect on output, such as @@ -326,6 +327,8 @@ arguments are described below. - drive-strength takes as argument the target strength in mA. +- drive-strength-uA takes as argument the target strength in uA. + - input-debounce takes the debounce time in usec as argument or 0 to disable debouncing
This property allow drive-strength parameter in uA instead of mA. Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> --- Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 3 +++ 1 file changed, 3 insertions(+)