diff mbox series

powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

Message ID 20190423143533.26952-1-yuehaibing@huawei.com (mailing list archive)
State Superseded
Headers show
Series powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog() | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch next (26ad26718dfaa7cf49d106d212ebf2370076c253)
snowpatch_ozlabs/build-ppc64le fail build failed!
snowpatch_ozlabs/build-ppc64be fail build failed!
snowpatch_ozlabs/build-ppc64e success Build succeeded
snowpatch_ozlabs/build-pmac32 success Build succeeded
snowpatch_ozlabs/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked

Commit Message

Yue Haibing April 23, 2019, 2:35 p.m. UTC 
From: YueHaibing <yuehaibing@huawei.com>

rtas_parse_epow_errlog() should pass 'modifier' to
handle_system_shutdown, because event modifier only use
bottom 4 bits.

Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/powerpc/platforms/pseries/ras.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Russell Currey April 24, 2019, 1:29 a.m. UTC | #1 
On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
> 
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
> interrupts")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Hello,

This fails to compile.

arch/powerpc/platforms/pseries/ras.c: In function
'rtas_parse_epow_errlog':
arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
undeclared (first use in this function); did you mean 'modifier'?
   handle_system_shutdown(event_modifier);
                          ^~~~~~~~~~~~~~
                          modifier

So yes, I assume you meant "modifier" instead of "event_modifier" as
mentioned in your commit message.  Did you compile this before sending?

(found by snowpatch)

- Russell
Yue Haibing April 24, 2019, 1:48 a.m. UTC | #2 
On 2019/4/24 9:29, Russell Currey wrote:
> On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> rtas_parse_epow_errlog() should pass 'modifier' to
>> handle_system_shutdown, because event modifier only use
>> bottom 4 bits.
>>
>> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
>> interrupts")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Hello,
> 
> This fails to compile.
> 
> arch/powerpc/platforms/pseries/ras.c: In function
> 'rtas_parse_epow_errlog':
> arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
> undeclared (first use in this function); did you mean 'modifier'?
>    handle_system_shutdown(event_modifier);
>                           ^~~~~~~~~~~~~~
>                           modifier

Yes, this should be 'modifier'

> 
> So yes, I assume you meant "modifier" instead of "event_modifier" as
> mentioned in your commit message.  Did you compile this before sending?

I am very sorry for this, this is not my compiled version,
I forgot to check again before sending.

> 
> (found by snowpatch)
> 
> - Russell
> 
> 
> .
>
diff mbox series

Patch

diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index c97d153..744604d 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -285,7 +285,7 @@  static void rtas_parse_epow_errlog(struct rtas_error_log *log)
 		break;
 
 	case EPOW_SYSTEM_SHUTDOWN:
-		handle_system_shutdown(epow_log->event_modifier);
+		handle_system_shutdown(event_modifier);
 		break;
 
 	case EPOW_SYSTEM_HALT: