| Message ID | 20190417205439.17685-12-jacek.anaszewski@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add generic support for composing LED class device name | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Jacek On 4/17/19 3:54 PM, Jacek Anaszewski wrote: > Refer to new "function" and "color" properties and mark "label" > as deprecated. > > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Dan Murphy <dmurphy@ti.com> I gave reviewed-by for DT docs and tested-by for code for the TI parts affected. Dan <snip>
On 4/18/19 2:28 PM, Dan Murphy wrote: > Jacek > > On 4/17/19 3:54 PM, Jacek Anaszewski wrote: >> Refer to new "function" and "color" properties and mark "label" >> as deprecated. >> >> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> >> Cc: Dan Murphy <dmurphy@ti.com> > > I gave reviewed-by for DT docs and tested-by for code for the TI parts affected. I know, but still there is change in one struct property name in the patches. I take your ack as granted then.
On Wed, 17 Apr 2019 22:54:24 +0200, Jacek Anaszewski wrote: > Refer to new "function" and "color" properties and mark "label" > as deprecated. > > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Dan Murphy <dmurphy@ti.com> > --- > Documentation/devicetree/bindings/leds/leds-lp8860.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt index 5f0e892ad759..9863220db4ba 100644 --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt @@ -20,12 +20,16 @@ Required child properties: - reg : 0 Optional child properties: - - label : see Documentation/devicetree/bindings/leds/common.txt + - function : see Documentation/devicetree/bindings/leds/common.txt + - color : see Documentation/devicetree/bindings/leds/common.txt + - label : see Documentation/devicetree/bindings/leds/common.txt (deprecated) - linux,default-trigger : see Documentation/devicetree/bindings/leds/common.txt Example: +#include <dt-bindings/leds/common.h> + led-controller@2d { compatible = "ti,lp8860"; #address-cells = <1>; @@ -36,7 +40,8 @@ led-controller@2d { led@0 { reg = <0>; - label = "white:backlight"; + function = LED_FUNCTION_BACKLIGHT; + color = <LED_COLOR_ID_WHITE>; linux,default-trigger = "backlight"; }; }
Refer to new "function" and "color" properties and mark "label" as deprecated. Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Dan Murphy <dmurphy@ti.com> --- Documentation/devicetree/bindings/leds/leds-lp8860.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)